mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] tpm: Check for availability of chip->ops before requesting locality
@ 2023-06-07 16:16 Stefan Berger
  0 siblings, 0 replies; only message in thread
From: Stefan Berger @ 2023-06-07 16:16 UTC (permalink / raw)
  To: linux-integrity, linux-kernel, jarkko; +Cc: Stefan Berger

When executing kexec on ppc64 tpm_class_shutdown() is called before
tpm_chip_unregister() and therefore chip->ops is NULL when
tpm_amd_is_rng_defective() is called. Check for chip->ops before
requesting the locality in tpm_amd_is_rng_defective() to avoid a
crash.

Fixes: bd8621ca1510 ("tpm: Add !tpm_amd_is_rng_defective() to the hwrng_unregister() call site")
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
---
 drivers/char/tpm/tpm-chip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c
index cd48033b804a..bc1ec1632fd8 100644
--- a/drivers/char/tpm/tpm-chip.c
+++ b/drivers/char/tpm/tpm-chip.c
@@ -524,7 +524,7 @@ static bool tpm_amd_is_rng_defective(struct tpm_chip *chip)
 	u64 version;
 	int ret;
 
-	if (!(chip->flags & TPM_CHIP_FLAG_TPM2))
+	if (!chip->ops || !(chip->flags & TPM_CHIP_FLAG_TPM2))
 		return false;
 
 	ret = tpm_request_locality(chip);
-- 
2.39.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-06-07 16:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-07 16:16 [PATCH] tpm: Check for availability of chip->ops before requesting locality Stefan Berger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®