[PATCH 0/5] hwmon: Update single register drivers to use maple tree register cache

[PATCH 0/5] hwmon: Update single register drivers to use maple tree register cache

[Mark Brown]

A number of hwmon drivers only support single register I/O and therefore
gain no benefit from using the more modern maple tree register cache
over the rbtree cache, convert them to maple tree.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
Mark Brown (5):
      hwmon: (lm75) Use maple tree register cache
      hwmon: (lm95245) Use maple tree register cache
      hwmon: (tmp102) Use maple tree register cache
      hwmon: (tmp108) Use maple tree register cache
      hwmon: (tmp464) Use maple tree register cache

 drivers/hwmon/lm75.c    | 2 +-
 drivers/hwmon/lm95245.c | 2 +-
 drivers/hwmon/tmp102.c  | 2 +-
 drivers/hwmon/tmp108.c  | 2 +-
 drivers/hwmon/tmp464.c  | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)
---
base-commit: 9561de3a55bed6bdd44a12820ba81ec416e705a7
change-id: 20230609-hwmon-maple-89029163bed2

Best regards,
-- 
Mark Brown <broonie@kernel.org>

[PATCH 1/5] hwmon: (lm75) Use maple tree register cache

[Mark Brown]

The lm75 is only capable of performing single register read and write
operations which means it gains no advantage from using a rbtree register
cache, convert it to using the more modern maple tree register cache
instead. This should be more efficient.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/hwmon/lm75.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
index dbb99ea4a0ec..ab73b9af5c71 100644
--- a/drivers/hwmon/lm75.c
+++ b/drivers/hwmon/lm75.c
@@ -548,7 +548,7 @@ static const struct regmap_config lm75_regmap_config = {
 	.writeable_reg = lm75_is_writeable_reg,
 	.volatile_reg = lm75_is_volatile_reg,
 	.val_format_endian = REGMAP_ENDIAN_BIG,
-	.cache_type = REGCACHE_RBTREE,
+	.cache_type = REGCACHE_MAPLE,
 	.use_single_read = true,
 	.use_single_write = true,
 };

-- 
2.30.2

[PATCH 2/5] hwmon: (lm95245) Use maple tree register cache

[Mark Brown]

The lm95245 is only capable of performing single register read and write
operations which means it gains no advantage from using a rbtree register
cache, convert it to using the more modern maple tree register cache
instead. This should be more efficient.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/hwmon/lm95245.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/lm95245.c b/drivers/hwmon/lm95245.c
index 4236d1e0544d..a7dc84e997f1 100644
--- a/drivers/hwmon/lm95245.c
+++ b/drivers/hwmon/lm95245.c
@@ -518,7 +518,7 @@ static const struct regmap_config lm95245_regmap_config = {
 	.val_bits = 8,
 	.writeable_reg = lm95245_is_writeable_reg,
 	.volatile_reg = lm95245_is_volatile_reg,
-	.cache_type = REGCACHE_RBTREE,
+	.cache_type = REGCACHE_MAPLE,
 	.use_single_read = true,
 	.use_single_write = true,
 };

-- 
2.30.2

[PATCH 3/5] hwmon: (tmp102) Use maple tree register cache

[Mark Brown]

The tmp102 is only capable of performing single register read and write
operations which means it gains no advantage from using a rbtree register
cache, convert it to using the more modern maple tree register cache
instead. This should be more efficient.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/hwmon/tmp102.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/tmp102.c b/drivers/hwmon/tmp102.c
index e271556efe0b..9563e1328b74 100644
--- a/drivers/hwmon/tmp102.c
+++ b/drivers/hwmon/tmp102.c
@@ -184,7 +184,7 @@ static const struct regmap_config tmp102_regmap_config = {
 	.writeable_reg = tmp102_is_writeable_reg,
 	.volatile_reg = tmp102_is_volatile_reg,
 	.val_format_endian = REGMAP_ENDIAN_BIG,
-	.cache_type = REGCACHE_RBTREE,
+	.cache_type = REGCACHE_MAPLE,
 	.use_single_read = true,
 	.use_single_write = true,
 };

-- 
2.30.2

[PATCH 4/5] hwmon: (tmp108) Use maple tree register cache

[Mark Brown]

The tmp108 is only capable of performing single register read and write
operations which means it gains no advantage from using a rbtree register
cache, convert it to using the more modern maple tree register cache
instead. This should be more efficient.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/hwmon/tmp108.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/tmp108.c b/drivers/hwmon/tmp108.c
index 43784c289a9e..f5a80d133048 100644
--- a/drivers/hwmon/tmp108.c
+++ b/drivers/hwmon/tmp108.c
@@ -318,7 +318,7 @@ static const struct regmap_config tmp108_regmap_config = {
 	.writeable_reg = tmp108_is_writeable_reg,
 	.volatile_reg = tmp108_is_volatile_reg,
 	.val_format_endian = REGMAP_ENDIAN_BIG,
-	.cache_type = REGCACHE_RBTREE,
+	.cache_type = REGCACHE_MAPLE,
 	.use_single_read = true,
 	.use_single_write = true,
 };

-- 
2.30.2

[PATCH 5/5] hwmon: (tmp464) Use maple tree register cache

[Mark Brown]

The tmp464 is only capable of performing single register read and write
operations which means it gains no advantage from using a rbtree register
cache, convert it to using the more modern maple tree register cache
instead. This should be more efficient.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/hwmon/tmp464.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/tmp464.c b/drivers/hwmon/tmp464.c
index 9213a493a590..ef50f43d12e6 100644
--- a/drivers/hwmon/tmp464.c
+++ b/drivers/hwmon/tmp464.c
@@ -644,7 +644,7 @@ static const struct regmap_config tmp464_regmap_config = {
 	.max_register = TMP464_DEVICE_ID_REG,
 	.volatile_reg = tmp464_is_volatile_reg,
 	.val_format_endian = REGMAP_ENDIAN_BIG,
-	.cache_type = REGCACHE_RBTREE,
+	.cache_type = REGCACHE_MAPLE,
 	.use_single_read = true,
 	.use_single_write = true,
 };

-- 
2.30.2

Re: [PATCH 0/5] hwmon: Update single register drivers to use maple tree register cache

[Guenter Roeck]

On 6/10/23 06:59, Mark Brown wrote:
> A number of hwmon drivers only support single register I/O and therefore
> gain no benefit from using the more modern maple tree register cache
> over the rbtree cache, convert them to maple tree.
> 

"gain no benefit from using the more modern maple tree register cache
over the rbtree cache, convert them to maple tree."

Is that really what you wanted to say ?

Guenter

> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> Mark Brown (5):
>        hwmon: (lm75) Use maple tree register cache
>        hwmon: (lm95245) Use maple tree register cache
>        hwmon: (tmp102) Use maple tree register cache
>        hwmon: (tmp108) Use maple tree register cache
>        hwmon: (tmp464) Use maple tree register cache
> 
>   drivers/hwmon/lm75.c    | 2 +-
>   drivers/hwmon/lm95245.c | 2 +-
>   drivers/hwmon/tmp102.c  | 2 +-
>   drivers/hwmon/tmp108.c  | 2 +-
>   drivers/hwmon/tmp464.c  | 2 +-
>   5 files changed, 5 insertions(+), 5 deletions(-)
> ---
> base-commit: 9561de3a55bed6bdd44a12820ba81ec416e705a7
> change-id: 20230609-hwmon-maple-89029163bed2
> 
> Best regards,

Re: [PATCH 0/5] hwmon: Update single register drivers to use maple tree register cache

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

On Sat, Jun 10, 2023 at 07:15:48AM -0700, Guenter Roeck wrote:
> On 6/10/23 06:59, Mark Brown wrote:
> > A number of hwmon drivers only support single register I/O and therefore
> > gain no benefit from using the more modern maple tree register cache
> > over the rbtree cache, convert them to maple tree.

> "gain no benefit from using the more modern maple tree register cache
> over the rbtree cache, convert them to maple tree."

> Is that really what you wanted to say ?

Sorry, other way around - gain no benefit from using rbtree over maple
tree.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 0/5] hwmon: Update single register drivers to use maple tree register cache

[Guenter Roeck]

On 6/10/23 07:24, Mark Brown wrote:
> On Sat, Jun 10, 2023 at 07:15:48AM -0700, Guenter Roeck wrote:
>> On 6/10/23 06:59, Mark Brown wrote:
>>> A number of hwmon drivers only support single register I/O and therefore
>>> gain no benefit from using the more modern maple tree register cache
>>> over the rbtree cache, convert them to maple tree.
> 
>> "gain no benefit from using the more modern maple tree register cache
>> over the rbtree cache, convert them to maple tree."
> 
>> Is that really what you wanted to say ?
> 
> Sorry, other way around - gain no benefit from using rbtree over maple
> tree.

That makes (much) more sense. I'll apply the series.

Thanks,
Guenter