[PATCH] nfs: don't report STATX_BTIME in ->getattr

[PATCH] nfs: don't report STATX_BTIME in ->getattr

[Jeff Layton]

NFS doesn't properly support reporting the btime in getattr (yet), but
61a968b4f05e mistakenly added it to the request_mask. This causes statx
for STATX_BTIME to report a zeroed out btime instead of properly
clearing the flag.

Cc: stable@vger.kernel.org # v6.3+
Fixes: 61a968b4f05e ("nfs: report the inode version in getattr if requested")
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 fs/nfs/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
index bc4cac08bb24..9b51ffd7281d 100644
--- a/fs/nfs/inode.c
+++ b/fs/nfs/inode.c
@@ -846,7 +846,7 @@ int nfs_getattr(struct mnt_idmap *idmap, const struct path *path,
 
 	request_mask &= STATX_TYPE | STATX_MODE | STATX_NLINK | STATX_UID |
 			STATX_GID | STATX_ATIME | STATX_MTIME | STATX_CTIME |
-			STATX_INO | STATX_SIZE | STATX_BLOCKS | STATX_BTIME |
+			STATX_INO | STATX_SIZE | STATX_BLOCKS |
 			STATX_CHANGE_COOKIE;
 
 	if ((query_flags & AT_STATX_DONT_SYNC) && !force_sync) {
-- 
2.40.1

Re: [PATCH] nfs: don't report STATX_BTIME in ->getattr

[Jeff Layton]

On Mon, 2023-06-12 at 09:34 -0400, Jeff Layton wrote:
> NFS doesn't properly support reporting the btime in getattr (yet), but
> 61a968b4f05e mistakenly added it to the request_mask. This causes statx
> for STATX_BTIME to report a zeroed out btime instead of properly
> clearing the flag.
> 
> Cc: stable@vger.kernel.org # v6.3+
> Fixes: 61a968b4f05e ("nfs: report the inode version in getattr if requested")
> Signed-off-by: Jeff Layton <jlayton@kernel.org>


Trond/Anna,

If this patch looks OK, could you also add these tags to the commit log?

    Link: https://bugzilla.redhat.com/show_bug.cgi?id=2214134
    Reported-by: Boyang Xue <bxue@redhat.com>

I forgot to tack them on before sending.

Thanks!

> ---
>  fs/nfs/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
> index bc4cac08bb24..9b51ffd7281d 100644
> --- a/fs/nfs/inode.c
> +++ b/fs/nfs/inode.c
> @@ -846,7 +846,7 @@ int nfs_getattr(struct mnt_idmap *idmap, const struct path *path,
>  
>  	request_mask &= STATX_TYPE | STATX_MODE | STATX_NLINK | STATX_UID |
>  			STATX_GID | STATX_ATIME | STATX_MTIME | STATX_CTIME |
> -			STATX_INO | STATX_SIZE | STATX_BLOCKS | STATX_BTIME |
> +			STATX_INO | STATX_SIZE | STATX_BLOCKS |
>  			STATX_CHANGE_COOKIE;
>  
>  	if ((query_flags & AT_STATX_DONT_SYNC) && !force_sync) {
-- 
Jeff Layton <jlayton@kernel.org>