From: Greg KH <gregkh@linuxfoundation.org>
To: Abhijit Gangurde <abhijit.gangurde@amd.com>
Cc: nikhil.agarwal@amd.com, Nipun.Gupta@amd.com,
geert@linux-m68k.org, linux-kernel@vger.kernel.org, git@amd.com,
michal.simek@amd.com
Subject: Re: [PATCH v4] cdx: Replace custom mcdi logging with print_hex_dump_debug()
Date: Tue, 13 Jun 2023 09:40:32 +0200 [thread overview]
Message-ID: <2023061300-mouth-suffering-8c20@gregkh> (raw)
In-Reply-To: <20230613065231.19932-1-abhijit.gangurde@amd.com>
On Tue, Jun 13, 2023 at 12:22:31PM +0530, Abhijit Gangurde wrote:
> Replace custom mcdi logging for send and receive requests
> with dynamic debug method print_hex_dump_debug().
>
> Fixes: eb96b740192b ("cdx: add MCDI protocol interface for firmware interaction")
This isn't a "fix", right?
> Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
> Closes: https://lore.kernel.org/lkml/CAMuHMdWTCdQagFFANygMgA8D0sWaoGxWv2AjibC3vwSd0UxuRw@mail.gmail.com/
This wasn't a "bug report" this was a "the code should be changed to not
do this" type of thing. Part of normal development.
Other than those nits, looks good, want to fix this up and resend a v5?
thanks,
greg k-h
prev parent reply other threads:[~2023-06-13 7:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 6:52 Abhijit Gangurde
2023-06-13 7:40 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023061300-mouth-suffering-8c20@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Nipun.Gupta@amd.com \
--cc=abhijit.gangurde@amd.com \
--cc=geert@linux-m68k.org \
--cc=git@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=nikhil.agarwal@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®