From: Anshuman Khandual <anshuman.khandual@arm.com>
To: linux-arm-kernel@lists.infradead.org, broonie@kernel.org
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
Rob Herring <robh@kernel.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
James Morse <james.morse@arm.com>,
kvmarm@lists.linux.dev, coresight@lists.linaro.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 03/14] arm64/sysreg: Rename TRBBASER_EL1 fields per auto-gen tools format
Date: Wed, 14 Jun 2023 12:29:38 +0530 [thread overview]
Message-ID: <20230614065949.146187-4-anshuman.khandual@arm.com> (raw)
In-Reply-To: <20230614065949.146187-1-anshuman.khandual@arm.com>
This renames TRBBASER_EL1 register fields per auto-gen tools format without
causing any functional change in the TRBE driver.
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: James Morse <james.morse@arm.com>
Cc: kvmarm@lists.linux.dev
Cc: coresight@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
arch/arm64/include/asm/sysreg.h | 4 ++--
drivers/hwtracing/coresight/coresight-trbe.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h
index b7a0d7d0f4d6..896b9b6334b4 100644
--- a/arch/arm64/include/asm/sysreg.h
+++ b/arch/arm64/include/asm/sysreg.h
@@ -262,8 +262,8 @@
#define TRBLIMITR_EL1_E BIT(0)
#define TRBPTR_EL1_PTR_MASK GENMASK_ULL(63, 0)
#define TRBPTR_EL1_PTR_SHIFT 0
-#define TRBBASER_BASE_MASK GENMASK_ULL(51, 0)
-#define TRBBASER_BASE_SHIFT 12
+#define TRBBASER_EL1_BASE_MASK GENMASK_ULL(63, 12)
+#define TRBBASER_EL1_BASE_SHIFT 12
#define TRBSR_EC_MASK GENMASK(5, 0)
#define TRBSR_EC_SHIFT 26
#define TRBSR_IRQ BIT(22)
diff --git a/drivers/hwtracing/coresight/coresight-trbe.h b/drivers/hwtracing/coresight/coresight-trbe.h
index 8ea7079d60bb..0b73d9d10aa8 100644
--- a/drivers/hwtracing/coresight/coresight-trbe.h
+++ b/drivers/hwtracing/coresight/coresight-trbe.h
@@ -131,7 +131,7 @@ static inline unsigned long get_trbe_limit_pointer(void)
static inline unsigned long get_trbe_base_pointer(void)
{
u64 trbbaser = read_sysreg_s(SYS_TRBBASER_EL1);
- unsigned long addr = trbbaser & (TRBBASER_BASE_MASK << TRBBASER_BASE_SHIFT);
+ unsigned long addr = trbbaser & TRBBASER_EL1_BASE_MASK;
WARN_ON(!IS_ALIGNED(addr, PAGE_SIZE));
return addr;
@@ -140,7 +140,7 @@ static inline unsigned long get_trbe_base_pointer(void)
static inline void set_trbe_base_pointer(unsigned long addr)
{
WARN_ON(is_trbe_enabled());
- WARN_ON(!IS_ALIGNED(addr, (1UL << TRBBASER_BASE_SHIFT)));
+ WARN_ON(!IS_ALIGNED(addr, (1UL << TRBBASER_EL1_BASE_SHIFT)));
WARN_ON(!IS_ALIGNED(addr, PAGE_SIZE));
write_sysreg_s(addr, SYS_TRBBASER_EL1);
}
--
2.25.1
next prev parent reply other threads:[~2023-06-14 7:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 6:59 [PATCH V3 00/14] arm64/sysreg: Convert TRBE registers to automatic generation Anshuman Khandual
2023-06-14 6:59 ` [PATCH V3 01/14] arm64/sysreg: Rename TRBLIMITR_EL1 fields per auto-gen tools format Anshuman Khandual
2023-06-14 6:59 ` [PATCH V3 02/14] arm64/sysreg: Rename TRBPTR_EL1 " Anshuman Khandual
2023-06-14 6:59 ` Anshuman Khandual [this message]
2023-06-14 6:59 ` [PATCH V3 04/14] arm64/sysreg: Rename TRBSR_EL1 " Anshuman Khandual
2023-06-14 6:59 ` [PATCH V3 05/14] arm64/sysreg: Rename TRBMAR_EL1 " Anshuman Khandual
2023-06-14 6:59 ` [PATCH V3 06/14] arm64/sysreg: Rename TRBTRG_EL1 " Anshuman Khandual
2023-06-14 6:59 ` [PATCH V3 07/14] arm64/sysreg: Rename TRBIDR_EL1 " Anshuman Khandual
2023-06-14 6:59 ` [PATCH V3 08/14] arm64/sysreg: Convert TRBLIMITR_EL1 register to automatic generation Anshuman Khandual
2023-06-14 11:39 ` Mark Brown
2023-06-14 6:59 ` [PATCH V3 09/14] arm64/sysreg: Convert TRBPTR_EL1 " Anshuman Khandual
2023-06-14 11:40 ` Mark Brown
2023-06-14 6:59 ` [PATCH V3 10/14] arm64/sysreg: Convert TRBBASER_EL1 " Anshuman Khandual
2023-06-14 11:41 ` Mark Brown
2023-06-14 6:59 ` [PATCH V3 11/14] arm64/sysreg: Convert TRBSR_EL1 " Anshuman Khandual
2023-06-14 11:43 ` Mark Brown
2023-06-14 6:59 ` [PATCH V3 12/14] arm64/sysreg: Convert TRBMAR_EL1 " Anshuman Khandual
2023-06-14 11:44 ` Mark Brown
2023-06-14 6:59 ` [PATCH V3 13/14] arm64/sysreg: Convert TRBTRG_EL1 " Anshuman Khandual
2023-06-14 11:44 ` Mark Brown
2023-06-14 6:59 ` [PATCH V3 14/14] arm64/sysreg: Convert TRBIDR_EL1 " Anshuman Khandual
2023-06-14 11:45 ` Mark Brown
2023-06-14 11:54 ` [PATCH V3 00/14] arm64/sysreg: Convert TRBE registers " Suzuki K Poulose
2023-06-14 17:19 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230614065949.146187-4-anshuman.khandual@arm.com \
--to=anshuman.khandual@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=coresight@lists.linaro.org \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®