* [PATCH] x86/smpboot: Remove a stray comment about CPU hotplug
@ 2023-06-14 20:13 Sohil Mehta
0 siblings, 0 replies; only message in thread
From: Sohil Mehta @ 2023-06-14 20:13 UTC (permalink / raw)
To: x86; +Cc: linux-kernel, Thomas Gleixner, Peter Zijlstra, Sohil Mehta
This old comment is irrelavant to the logic of disabling interrupts and
could be misleading. Remove it.
Some history - commit 'e1367daf3eed5 ("[PATCH] cpu state clean after hot
remove")' introduced this comment a while back. However, while
refactoring the play_dead code, commit 'a21f5d88c17a ("x86: unify x86_32
and x86_64 play_dead into one function")' missed moving it to the
appropriate location.
Now, hlt_play_dead() resembles the code that the comment was initially
added for, but, it doesn't make sense anymore because an offlined cpu
could also be put into other states such as mwait.
Signed-off-by: Sohil Mehta <sohil.mehta@intel.com>
---
arch/x86/kernel/smpboot.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 352f0ce1ece4..64dd4703c1ff 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -1734,9 +1734,6 @@ void play_dead_common(void)
/* Ack it */
(void)cpu_report_death();
- /*
- * With physical CPU hotplug, we should halt the cpu
- */
local_irq_disable();
}
--
2.34.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-06-14 20:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-14 20:13 [PATCH] x86/smpboot: Remove a stray comment about CPU hotplug Sohil Mehta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®