From: Peter Zijlstra <peterz@infradead.org>
To: Hao Jia <jiahao.os@bytedance.com>
Cc: mingo@redhat.com, mingo@kernel.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, vschneid@redhat.com,
mgorman@techsingularity.net, linux-kernel@vger.kernel.org
Subject: Re: [External] Re: [PATCH v5 2/4] sched/core: Avoid double calling update_rq_clock() in __balance_push_cpu_stop()
Date: Fri, 16 Jun 2023 11:18:05 +0200 [thread overview]
Message-ID: <20230616091805.GJ83892@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <b4fcf354-f6ee-be68-1608-8b874511785a@bytedance.com>
On Fri, Jun 16, 2023 at 03:56:25PM +0800, Hao Jia wrote:
> I'm afraid not, the rq clock also needs to be updated before
> select_fallback_rq() is called.
> If we just remove update_rq_clock() from __balance_push_cpu_stop(), we will
> get this warning.
>
>
> [ 1260.960166] rq->clock_update_flags < RQCF_ACT_SKIP
> [ 1260.960170] WARNING: CPU: 25 PID: 196 at kernel/sched/sched.h:1496
> update_curr+0xf6/0x1f0
>
> [ 1260.960318] Call Trace:
> [ 1260.960320] <TASK>
> [ 1260.960359] dequeue_entity+0x3b/0x410
> [ 1260.960361] dequeue_task_fair+0xc7/0x3c0
> [ 1260.960363] dequeue_task+0x30/0xf0
> [ 1260.960365] __do_set_cpus_allowed+0x94/0x130
> [ 1260.960366] do_set_cpus_allowed+0x38/0x60
> [ 1260.960368] cpuset_cpus_allowed_fallback+0x70/0x80
> [ 1260.960372] select_fallback_rq+0x20f/0x250 <----
Urgh... :-(
next prev parent reply other threads:[~2023-06-16 9:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 8:20 [PATCH v5 0/4] Fix some warnings about rq clock Hao Jia
2023-06-13 8:20 ` [PATCH v5 1/4] sched/core: Fixed missing rq clock update before calling set_rq_offline() Hao Jia
2023-06-13 8:31 ` Hao Jia
2023-06-13 9:13 ` Vincent Guittot
2023-06-19 11:04 ` [tip: sched/core] " tip-bot2 for Hao Jia
2023-06-13 8:20 ` [PATCH v5 2/4] sched/core: Avoid double calling update_rq_clock() in __balance_push_cpu_stop() Hao Jia
2023-06-15 12:39 ` Peter Zijlstra
2023-06-16 7:56 ` [External] " Hao Jia
2023-06-16 9:18 ` Peter Zijlstra [this message]
2023-06-19 11:04 ` [tip: sched/core] " tip-bot2 for Hao Jia
2023-06-19 12:18 ` [External] " Hao Jia
2023-06-13 8:20 ` [PATCH v5 3/4] sched/core: Avoid multiple calling update_rq_clock() in __cfsb_csd_unthrottle() Hao Jia
2023-06-19 11:04 ` [tip: sched/core] " tip-bot2 for Hao Jia
2023-06-13 8:20 ` [PATCH v5 4/4] sched/core: Avoid multiple calling update_rq_clock() in unthrottle_offline_cfs_rqs() Hao Jia
2023-06-13 21:52 ` Benjamin Segall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230616091805.GJ83892@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jiahao.os@bytedance.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mgorman@techsingularity.net \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®