* [PATCH] nvdimm: make security_show static
@ 2023-06-16 16:09 Ben Dooks
2023-06-16 16:14 ` Dave Jiang
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2023-06-16 16:09 UTC (permalink / raw)
To: nvdimm
Cc: linux-kernel, dan.j.williams, vishal.l.verma, dave.jiang,
ira.weiny, Ben Dooks
The security_show function is not used outsid of drivers/nvdimm/dimm_devs.c
and the attribute it is for is also already static. Silence the sparse
warning for this not being declared by making it static. Fixes:
drivers/nvdimm/dimm_devs.c:352:9: warning: symbol 'security_show' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
drivers/nvdimm/dimm_devs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c
index 957f7c3d17ba..1273873582be 100644
--- a/drivers/nvdimm/dimm_devs.c
+++ b/drivers/nvdimm/dimm_devs.c
@@ -349,8 +349,8 @@ static ssize_t available_slots_show(struct device *dev,
}
static DEVICE_ATTR_RO(available_slots);
-ssize_t security_show(struct device *dev,
- struct device_attribute *attr, char *buf)
+static ssize_t security_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
{
struct nvdimm *nvdimm = to_nvdimm(dev);
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] nvdimm: make security_show static
2023-06-16 16:09 [PATCH] nvdimm: make security_show static Ben Dooks
@ 2023-06-16 16:14 ` Dave Jiang
0 siblings, 0 replies; 2+ messages in thread
From: Dave Jiang @ 2023-06-16 16:14 UTC (permalink / raw)
To: Ben Dooks, nvdimm; +Cc: linux-kernel, dan.j.williams, vishal.l.verma, ira.weiny
On 6/16/23 09:09, Ben Dooks wrote:
> The security_show function is not used outsid of drivers/nvdimm/dimm_devs.c
s/outsid/outside/
> and the attribute it is for is also already static. Silence the sparse
> warning for this not being declared by making it static. Fixes:
>
> drivers/nvdimm/dimm_devs.c:352:9: warning: symbol 'security_show' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/nvdimm/dimm_devs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c
> index 957f7c3d17ba..1273873582be 100644
> --- a/drivers/nvdimm/dimm_devs.c
> +++ b/drivers/nvdimm/dimm_devs.c
> @@ -349,8 +349,8 @@ static ssize_t available_slots_show(struct device *dev,
> }
> static DEVICE_ATTR_RO(available_slots);
>
> -ssize_t security_show(struct device *dev,
> - struct device_attribute *attr, char *buf)
> +static ssize_t security_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> {
> struct nvdimm *nvdimm = to_nvdimm(dev);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-16 16:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-16 16:09 [PATCH] nvdimm: make security_show static Ben Dooks
2023-06-16 16:14 ` Dave Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®