mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: pinctrl: qcom,sdx65-tlmm: add pcie_clkreq function
@ 2023-06-17 11:18 Krzysztof Kozlowski
  2023-06-17 20:42 ` Conor Dooley
  2023-06-19  8:53 ` Linus Walleij
  0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-17 11:18 UTC (permalink / raw)
  To: Bjorn Andersson, Andy Gross, Konrad Dybcio, Linus Walleij,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, krishna Lanka,
	linux-arm-msm, linux-gpio, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

DTS and driver already support pcie_clkreq function for a pin.  Add it
to fix dtbs_check warning:

  qcom-sdx65-mtp.dtb: pinctrl@f100000: pcie-ep-clkreq-default-state: 'oneOf' conditional failed, one must be fixed:
    'bias-disable', 'drive-strength', 'function', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
    'pcie_clkreq' is not one of ['blsp_uart1', 'blsp_spi1', ... 'gpio']

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/pinctrl/qcom,sdx65-tlmm.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-tlmm.yaml
index 2ef793ae4038..27319782d94b 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-tlmm.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-tlmm.yaml
@@ -85,7 +85,7 @@ $defs:
                 qdss_tracectl_a, dac_calib13, qdss_traceclk_a, dac_calib14,
                 dac_calib15, hdmi_rcv, dac_calib16, hdmi_cec, pwr_modem,
                 dac_calib17, hdmi_ddc, pwr_nav, dac_calib18, pwr_crypto,
-                dac_calib19, hdmi_hot, dac_calib20, dac_calib21, pci_e0,
+                dac_calib19, hdmi_hot, dac_calib20, dac_calib21, pci_e0, pcie_clkreq,
                 dac_calib22, dac_calib23, dac_calib24, tsif1_sync, dac_calib25,
                 sd_write, tsif1_error, blsp_spi2, blsp_uart2, blsp_uim2,
                 qdss_cti, blsp_i2c2, blsp_spi3, blsp_uart3, blsp_uim3, blsp_i2c3,
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: pinctrl: qcom,sdx65-tlmm: add pcie_clkreq function
  2023-06-17 11:18 [PATCH] dt-bindings: pinctrl: qcom,sdx65-tlmm: add pcie_clkreq function Krzysztof Kozlowski
@ 2023-06-17 20:42 ` Conor Dooley
  2023-06-19  8:53 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2023-06-17 20:42 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Linus Walleij,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, krishna Lanka,
	linux-arm-msm, linux-gpio, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1806 bytes --]

On Sat, Jun 17, 2023 at 01:18:09PM +0200, Krzysztof Kozlowski wrote:
> DTS and driver already support pcie_clkreq function for a pin.  Add it
> to fix dtbs_check warning:
> 
>   qcom-sdx65-mtp.dtb: pinctrl@f100000: pcie-ep-clkreq-default-state: 'oneOf' conditional failed, one must be fixed:
>     'bias-disable', 'drive-strength', 'function', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
>     'pcie_clkreq' is not one of ['blsp_uart1', 'blsp_spi1', ... 'gpio']
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> ---
>  Documentation/devicetree/bindings/pinctrl/qcom,sdx65-tlmm.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-tlmm.yaml
> index 2ef793ae4038..27319782d94b 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-tlmm.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-tlmm.yaml
> @@ -85,7 +85,7 @@ $defs:
>                  qdss_tracectl_a, dac_calib13, qdss_traceclk_a, dac_calib14,
>                  dac_calib15, hdmi_rcv, dac_calib16, hdmi_cec, pwr_modem,
>                  dac_calib17, hdmi_ddc, pwr_nav, dac_calib18, pwr_crypto,
> -                dac_calib19, hdmi_hot, dac_calib20, dac_calib21, pci_e0,
> +                dac_calib19, hdmi_hot, dac_calib20, dac_calib21, pci_e0, pcie_clkreq,
>                  dac_calib22, dac_calib23, dac_calib24, tsif1_sync, dac_calib25,
>                  sd_write, tsif1_error, blsp_spi2, blsp_uart2, blsp_uim2,
>                  qdss_cti, blsp_i2c2, blsp_spi3, blsp_uart3, blsp_uim3, blsp_i2c3,
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: pinctrl: qcom,sdx65-tlmm: add pcie_clkreq function
  2023-06-17 11:18 [PATCH] dt-bindings: pinctrl: qcom,sdx65-tlmm: add pcie_clkreq function Krzysztof Kozlowski
  2023-06-17 20:42 ` Conor Dooley
@ 2023-06-19  8:53 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2023-06-19  8:53 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, krishna Lanka, linux-arm-msm,
	linux-gpio, devicetree, linux-kernel

On Sat, Jun 17, 2023 at 1:18 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:

> DTS and driver already support pcie_clkreq function for a pin.  Add it
> to fix dtbs_check warning:
>
>   qcom-sdx65-mtp.dtb: pinctrl@f100000: pcie-ep-clkreq-default-state: 'oneOf' conditional failed, one must be fixed:
>     'bias-disable', 'drive-strength', 'function', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
>     'pcie_clkreq' is not one of ['blsp_uart1', 'blsp_spi1', ... 'gpio']
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Patch applied!

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-06-19  8:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-17 11:18 [PATCH] dt-bindings: pinctrl: qcom,sdx65-tlmm: add pcie_clkreq function Krzysztof Kozlowski
2023-06-17 20:42 ` Conor Dooley
2023-06-19  8:53 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®