[PATCH 0/2] hwmon: (oxp-sensors) Minor cleanup of driver code

[PATCH 0/2] hwmon: (oxp-sensors) Minor cleanup of driver code

[Joaquín Ignacio Aramendía]

Make some cleanup of the driver removing unnecesary header and some
duplicated return on error logic.

Joaquín Ignacio Aramendía (2):
  hwmon: (oxp-sensors) Remove unused header
  hwmon: (oxp-sensors) Simplify logic of error return

 drivers/hwmon/oxp-sensors.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

-- 
2.41.0

[PATCH 1/2] hwmon: (oxp-sensors) Remove unused header

[Joaquín Ignacio Aramendía]

We are not using <dev_printk.h>, remove that.

Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>
---
 drivers/hwmon/oxp-sensors.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/hwmon/oxp-sensors.c b/drivers/hwmon/oxp-sensors.c
index be36d38f13d9..584e48d8106e 100644
--- a/drivers/hwmon/oxp-sensors.c
+++ b/drivers/hwmon/oxp-sensors.c
@@ -16,7 +16,6 @@
  */
 
 #include <linux/acpi.h>
-#include <linux/dev_printk.h>
 #include <linux/dmi.h>
 #include <linux/hwmon.h>
 #include <linux/init.h>
-- 
2.41.0

Re: [PATCH 1/2] hwmon: (oxp-sensors) Remove unused header

[Guenter Roeck]

On Sat, Jun 17, 2023 at 03:11:42PM -0300, Joaquín Ignacio Aramendía wrote:
> We are not using <dev_printk.h>, remove that.
> 
> Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/oxp-sensors.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hwmon/oxp-sensors.c b/drivers/hwmon/oxp-sensors.c
> index be36d38f13d9..584e48d8106e 100644
> --- a/drivers/hwmon/oxp-sensors.c
> +++ b/drivers/hwmon/oxp-sensors.c
> @@ -16,7 +16,6 @@
>   */
>  
>  #include <linux/acpi.h>
> -#include <linux/dev_printk.h>
>  #include <linux/dmi.h>
>  #include <linux/hwmon.h>
>  #include <linux/init.h>

[PATCH 2/2] hwmon: (oxp-sensors) Simplify logic of error return

[Joaquín Ignacio Aramendía]

Take return logic on error out of if-else, eliminating
duplicated code in tt_togle_store() function.

Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>
---
 drivers/hwmon/oxp-sensors.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/hwmon/oxp-sensors.c b/drivers/hwmon/oxp-sensors.c
index 584e48d8106e..1e59d97219c4 100644
--- a/drivers/hwmon/oxp-sensors.c
+++ b/drivers/hwmon/oxp-sensors.c
@@ -226,13 +226,12 @@ static ssize_t tt_toggle_store(struct device *dev,
 
 	if (value) {
 		rval = tt_toggle_enable();
-		if (rval)
-			return rval;
 	} else {
 		rval = tt_toggle_disable();
-		if (rval)
-			return rval;
 	}
+	if (rval)
+		return rval;
+
 	return count;
 }
 
-- 
2.41.0

Re: [PATCH 2/2] hwmon: (oxp-sensors) Simplify logic of error return

[Guenter Roeck]

On Sat, Jun 17, 2023 at 03:11:43PM -0300, Joaquín Ignacio Aramendía wrote:
> Take return logic on error out of if-else, eliminating
> duplicated code in tt_togle_store() function.
> 
> Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/oxp-sensors.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/hwmon/oxp-sensors.c b/drivers/hwmon/oxp-sensors.c
> index 584e48d8106e..1e59d97219c4 100644
> --- a/drivers/hwmon/oxp-sensors.c
> +++ b/drivers/hwmon/oxp-sensors.c
> @@ -226,13 +226,12 @@ static ssize_t tt_toggle_store(struct device *dev,
>  
>  	if (value) {
>  		rval = tt_toggle_enable();
> -		if (rval)
> -			return rval;
>  	} else {
>  		rval = tt_toggle_disable();
> -		if (rval)
> -			return rval;
>  	}
> +	if (rval)
> +		return rval;
> +
>  	return count;
>  }
>