* [PATCH] drm/amdgpu: Add missing MODULE_FIRMWARE macro
@ 2023-06-16 12:11 Juerg Haefliger
2023-06-16 12:53 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Juerg Haefliger @ 2023-06-16 12:11 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, Xinhui.Pan, airlied, daniel,
amd-gfx, dri-devel
Cc: linux-kernel, Hawking.Zhang, mario.limonciello, lijo.lazar,
YiPeng.Chai, Bokun.Zhang, Likun.Gao, Juerg Haefliger
Add the missing MODULE_FIRMWARE macro for "amdgpu/fiji_smc.bin".
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 5c7d40873ee2..1f83a939d641 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -92,6 +92,7 @@ MODULE_FIRMWARE("amdgpu/picasso_gpu_info.bin");
MODULE_FIRMWARE("amdgpu/raven2_gpu_info.bin");
MODULE_FIRMWARE("amdgpu/arcturus_gpu_info.bin");
MODULE_FIRMWARE("amdgpu/navi12_gpu_info.bin");
+MODULE_FIRMWARE("amdgpu/fiji_smc.bin");
#define AMDGPU_RESUME_MS 2000
#define AMDGPU_MAX_RETRY_LIMIT 2
--
2.37.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: Add missing MODULE_FIRMWARE macro
2023-06-16 12:11 [PATCH] drm/amdgpu: Add missing MODULE_FIRMWARE macro Juerg Haefliger
@ 2023-06-16 12:53 ` Alex Deucher
2023-06-19 14:42 ` Juerg Haefliger
0 siblings, 1 reply; 3+ messages in thread
From: Alex Deucher @ 2023-06-16 12:53 UTC (permalink / raw)
To: Juerg Haefliger
Cc: alexander.deucher, christian.koenig, Xinhui.Pan, airlied, daniel,
amd-gfx, dri-devel, Bokun.Zhang, lijo.lazar, linux-kernel,
YiPeng.Chai, mario.limonciello, Likun.Gao, Hawking.Zhang
On Fri, Jun 16, 2023 at 8:11 AM Juerg Haefliger
<juerg.haefliger@canonical.com> wrote:
>
> Add the missing MODULE_FIRMWARE macro for "amdgpu/fiji_smc.bin".
>
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 5c7d40873ee2..1f83a939d641 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -92,6 +92,7 @@ MODULE_FIRMWARE("amdgpu/picasso_gpu_info.bin");
> MODULE_FIRMWARE("amdgpu/raven2_gpu_info.bin");
> MODULE_FIRMWARE("amdgpu/arcturus_gpu_info.bin");
> MODULE_FIRMWARE("amdgpu/navi12_gpu_info.bin");
> +MODULE_FIRMWARE("amdgpu/fiji_smc.bin");
This is already specified in smumgr.c.
Alex
>
> #define AMDGPU_RESUME_MS 2000
> #define AMDGPU_MAX_RETRY_LIMIT 2
> --
> 2.37.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: Add missing MODULE_FIRMWARE macro
2023-06-16 12:53 ` Alex Deucher
@ 2023-06-19 14:42 ` Juerg Haefliger
0 siblings, 0 replies; 3+ messages in thread
From: Juerg Haefliger @ 2023-06-19 14:42 UTC (permalink / raw)
To: Alex Deucher
Cc: alexander.deucher, christian.koenig, Xinhui.Pan, airlied, daniel,
amd-gfx, dri-devel, Bokun.Zhang, lijo.lazar, linux-kernel,
YiPeng.Chai, mario.limonciello, Likun.Gao, Hawking.Zhang
[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]
On Fri, 16 Jun 2023 08:53:20 -0400
Alex Deucher <alexdeucher@gmail.com> wrote:
> On Fri, Jun 16, 2023 at 8:11 AM Juerg Haefliger
> <juerg.haefliger@canonical.com> wrote:
> >
> > Add the missing MODULE_FIRMWARE macro for "amdgpu/fiji_smc.bin".
> >
> > Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > index 5c7d40873ee2..1f83a939d641 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > @@ -92,6 +92,7 @@ MODULE_FIRMWARE("amdgpu/picasso_gpu_info.bin");
> > MODULE_FIRMWARE("amdgpu/raven2_gpu_info.bin");
> > MODULE_FIRMWARE("amdgpu/arcturus_gpu_info.bin");
> > MODULE_FIRMWARE("amdgpu/navi12_gpu_info.bin");
> > +MODULE_FIRMWARE("amdgpu/fiji_smc.bin");
>
> This is already specified in smumgr.c.
It sure is. Sorry for the noise :-(
Thanks for looking at it.
..Juerg
> Alex
>
> >
> > #define AMDGPU_RESUME_MS 2000
> > #define AMDGPU_MAX_RETRY_LIMIT 2
> > --
> > 2.37.2
> >
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-19 14:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-16 12:11 [PATCH] drm/amdgpu: Add missing MODULE_FIRMWARE macro Juerg Haefliger
2023-06-16 12:53 ` Alex Deucher
2023-06-19 14:42 ` Juerg Haefliger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®