mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] fs: Fix bug in lock_rename_child that can cause deadlock
@ 2023-06-19 13:37 Li Dong
  2023-06-20  9:44 ` Christian Brauner
  0 siblings, 1 reply; 2+ messages in thread
From: Li Dong @ 2023-06-19 13:37 UTC (permalink / raw)
  To: Alexander Viro, Christian Brauner,
	open list:FILESYSTEMS (VFS and infrastructure),
	open list
  Cc: opensource.kernel, lidong

Function xx causes a deadlock,because s_vfs_rename_mutex was not released when return

Signed-off-by: Li Dong <lidong@vivo.com>
---
 fs/namei.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/namei.c b/fs/namei.c
index 91171da719c5..63b3fd05fef2 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -3076,8 +3076,10 @@ struct dentry *lock_rename_child(struct dentry *c1, struct dentry *p2)
 	/*
 	 * nobody can move out of any directories on this fs.
 	 */
-	if (likely(c1->d_parent != p2))
+	if (likely(c1->d_parent != p2)) {
+		mutex_unlock(&c1->d_sb->s_vfs_rename_mutex);
 		return lock_two_directories(c1->d_parent, p2);
+	}
 
 	/*
 	 * c1 got moved into p2 while we were taking locks;
-- 
2.31.1.windows.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-20  9:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-19 13:37 [PATCH] fs: Fix bug in lock_rename_child that can cause deadlock Li Dong
2023-06-20  9:44 ` Christian Brauner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®