* [PATCH][next] pipe: remove redundant initialization of pointer buf
@ 2023-06-22 8:18 Colin Ian King
0 siblings, 0 replies; only message in thread
From: Colin Ian King @ 2023-06-22 8:18 UTC (permalink / raw)
To: Alexander Viro, Christian Brauner; +Cc: kernel-janitors, linux-kernel
The pointer buf is being initialized with a value that is never
read. Buf is being re-assigned later on, the initialization is
redundant and can be removed. Cleans up clang scan build warning:
fs/pipe.c:492:24: warning: Value stored to 'buf' during its
initialization is never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
fs/pipe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/pipe.c b/fs/pipe.c
index 2d88f73f585a..71b6b0545e0f 100644
--- a/fs/pipe.c
+++ b/fs/pipe.c
@@ -489,7 +489,7 @@ pipe_write(struct kiocb *iocb, struct iov_iter *from)
head = pipe->head;
if (!pipe_full(head, pipe->tail, pipe->max_usage)) {
unsigned int mask = pipe->ring_size - 1;
- struct pipe_buffer *buf = &pipe->bufs[head & mask];
+ struct pipe_buffer *buf;
struct page *page = pipe->tmp_page;
int copied;
--
2.39.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-06-22 8:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-22 8:18 [PATCH][next] pipe: remove redundant initialization of pointer buf Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®