[PATCH V2 0/3] correct the lpuart compatible for imx8dxl and imx93

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

* [PATCH V2 0/3] correct the lpuart compatible for imx8dxl and imx93
@ 2023-06-26  4:48 Sherry Sun
  2023-06-26  4:48 ` [PATCH V2 1/3] arm64: dts: imx8dxl: remove "fsl,imx7ulp-lpuart" compatible for imx8dxl Sherry Sun
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Sherry Sun @ 2023-06-26  4:48 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer,
	festevam, shenwei.wang, gregkh
  Cc: devicetree, linux-arm-kernel, kernel, linux-serial, linux-kernel,
	linux-imx

This patch set corrects the lpuart compatible for imx8dxl and imx93 platforms,
also add the imx8ulp compatible string in fsl-lpuart dt-binding doc. 

---
Changes in V2
1. drop the imx8ulp dts changes in last version patch set
2. add both "fsl,imx8ulp-lpuart" and "fsl,imx7ulp-lpuart" for imx93
3. correct the dt-bindings for imx93 lpuart compatible
---

Sherry Sun (3):
  arm64: dts: imx8dxl: remove "fsl,imx7ulp-lpuart" compatible for
    imx8dxl
  arm64: dts: imx93: add "fsl,imx8ulp-lpuart" compatible for imx93
  dt-bindings: serial: fsl-lpuart: add imx8ulp compatible string

 .../devicetree/bindings/serial/fsl-lpuart.yaml   |  9 ++++++---
 .../boot/dts/freescale/imx8dxl-ss-adma.dtsi      |  8 ++++----
 arch/arm64/boot/dts/freescale/imx93.dtsi         | 16 ++++++++--------
 3 files changed, 18 insertions(+), 15 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH V2 1/3] arm64: dts: imx8dxl: remove "fsl,imx7ulp-lpuart" compatible for imx8dxl
  2023-06-26  4:48 [PATCH V2 0/3] correct the lpuart compatible for imx8dxl and imx93 Sherry Sun
@ 2023-06-26  4:48 ` Sherry Sun
  2023-06-26  4:48 ` [PATCH V2 2/3] arm64: dts: imx93: add "fsl,imx8ulp-lpuart" compatible for imx93 Sherry Sun
  2023-06-26  4:48 ` [PATCH V2 3/3] dt-bindings: serial: fsl-lpuart: add imx8ulp compatible string Sherry Sun
  2 siblings, 0 replies; 6+ messages in thread
From: Sherry Sun @ 2023-06-26  4:48 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer,
	festevam, shenwei.wang, gregkh
  Cc: devicetree, linux-arm-kernel, kernel, linux-serial, linux-kernel,
	linux-imx

Drop the i.MX8DXL backwards compatibility with i.MX7ULP since they
differ from clocks handling point of view.

dtbs_check has the following warnings:
linux-next/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: serial@5a060000: compatible: 'oneOf' conditional failed, one must be fixed:
        ['fsl,imx8qxp-lpuart', 'fsl,imx7ulp-lpuart'] is too long
        'fsl,imx93-lpuart' was expected
        'fsl,imx8qxp-lpuart' is not one of ['fsl,imx8qm-lpuart', 'fsl,imx8dxl-lpuart']
        'fsl,imxrt1050-lpuart' was expected
        'fsl,imx8ulp-lpuart' was expected
        'fsl,imx8qxp-lpuart' was expected
        'fsl,imxrt1170-lpuart' was expected
        From schema: linux-next/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml

Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi b/arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi
index 6881330ab4c6..e2eeddf38aa3 100644
--- a/arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi
@@ -36,22 +36,22 @@
 };
 
 &lpuart0 {
-	compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+	compatible = "fsl,imx8dxl-lpuart", "fsl,imx8qxp-lpuart";
 	interrupts = <GIC_SPI 228 IRQ_TYPE_LEVEL_HIGH>;
 };
 
 &lpuart1 {
-	compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+	compatible = "fsl,imx8dxl-lpuart", "fsl,imx8qxp-lpuart";
 	interrupts = <GIC_SPI 229 IRQ_TYPE_LEVEL_HIGH>;
 };
 
 &lpuart2 {
-	compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+	compatible = "fsl,imx8dxl-lpuart", "fsl,imx8qxp-lpuart";
 	interrupts = <GIC_SPI 230 IRQ_TYPE_LEVEL_HIGH>;
 };
 
 &lpuart3 {
-	compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+	compatible = "fsl,imx8dxl-lpuart", "fsl,imx8qxp-lpuart";
 	interrupts = <GIC_SPI 231 IRQ_TYPE_LEVEL_HIGH>;
 };
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH V2 2/3] arm64: dts: imx93: add "fsl,imx8ulp-lpuart" compatible for imx93
  2023-06-26  4:48 [PATCH V2 0/3] correct the lpuart compatible for imx8dxl and imx93 Sherry Sun
  2023-06-26  4:48 ` [PATCH V2 1/3] arm64: dts: imx8dxl: remove "fsl,imx7ulp-lpuart" compatible for imx8dxl Sherry Sun
@ 2023-06-26  4:48 ` Sherry Sun
  2023-06-26  4:48 ` [PATCH V2 3/3] dt-bindings: serial: fsl-lpuart: add imx8ulp compatible string Sherry Sun
  2 siblings, 0 replies; 6+ messages in thread
From: Sherry Sun @ 2023-06-26  4:48 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer,
	festevam, shenwei.wang, gregkh
  Cc: devicetree, linux-arm-kernel, kernel, linux-serial, linux-kernel,
	linux-imx

i.MX93 and i.MX8ULP lpuart add some new featurs based on i.MX7ULP, for
example, i.MX93 and i.MX8ULP can support EOP(end-of-packet) function
while i.MX7ULP doesn't support, so add "fsl,imx8ulp-lpuart" compatible
string for i.MX93 to support those new features.

Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx93.dtsi | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index 8643612ace8c..16da5ef578c5 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -252,7 +252,7 @@
 			};
 
 			lpuart1: serial@44380000 {
-				compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart";
+				compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart";
 				reg = <0x44380000 0x1000>;
 				interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clk IMX93_CLK_LPUART1_GATE>;
@@ -261,7 +261,7 @@
 			};
 
 			lpuart2: serial@44390000 {
-				compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart";
+				compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart";
 				reg = <0x44390000 0x1000>;
 				interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clk IMX93_CLK_LPUART2_GATE>;
@@ -486,7 +486,7 @@
 			};
 
 			lpuart3: serial@42570000 {
-				compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart";
+				compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart";
 				reg = <0x42570000 0x1000>;
 				interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clk IMX93_CLK_LPUART3_GATE>;
@@ -495,7 +495,7 @@
 			};
 
 			lpuart4: serial@42580000 {
-				compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart";
+				compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart";
 				reg = <0x42580000 0x1000>;
 				interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clk IMX93_CLK_LPUART4_GATE>;
@@ -504,7 +504,7 @@
 			};
 
 			lpuart5: serial@42590000 {
-				compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart";
+				compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart";
 				reg = <0x42590000 0x1000>;
 				interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clk IMX93_CLK_LPUART5_GATE>;
@@ -513,7 +513,7 @@
 			};
 
 			lpuart6: serial@425a0000 {
-				compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart";
+				compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart";
 				reg = <0x425a0000 0x1000>;
 				interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clk IMX93_CLK_LPUART6_GATE>;
@@ -551,7 +551,7 @@
 			};
 
 			lpuart7: serial@42690000 {
-				compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart";
+				compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart";
 				reg = <0x42690000 0x1000>;
 				interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clk IMX93_CLK_LPUART7_GATE>;
@@ -560,7 +560,7 @@
 			};
 
 			lpuart8: serial@426a0000 {
-				compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart";
+				compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart";
 				reg = <0x426a0000 0x1000>;
 				interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clk IMX93_CLK_LPUART8_GATE>;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH V2 3/3] dt-bindings: serial: fsl-lpuart: add imx8ulp compatible string
  2023-06-26  4:48 [PATCH V2 0/3] correct the lpuart compatible for imx8dxl and imx93 Sherry Sun
  2023-06-26  4:48 ` [PATCH V2 1/3] arm64: dts: imx8dxl: remove "fsl,imx7ulp-lpuart" compatible for imx8dxl Sherry Sun
  2023-06-26  4:48 ` [PATCH V2 2/3] arm64: dts: imx93: add "fsl,imx8ulp-lpuart" compatible for imx93 Sherry Sun
@ 2023-06-26  4:48 ` Sherry Sun
  2023-06-26 15:46   ` Krzysztof Kozlowski
  2 siblings, 1 reply; 6+ messages in thread
From: Sherry Sun @ 2023-06-26  4:48 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer,
	festevam, shenwei.wang, gregkh
  Cc: devicetree, linux-arm-kernel, kernel, linux-serial, linux-kernel,
	linux-imx

Add imx8ulp compatible string in lpuart dt-binding, also correct the
imx93 compatible here, imx93/imx8ulp add some new features based on
imx7ulp lpuart, so need to add "fsl,imx8ulp-lpuart" for imx93 to enable
those new features.

Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
index 93062403276b..272bfbb1cdfc 100644
--- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
+++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
@@ -21,12 +21,15 @@ properties:
           - fsl,ls1021a-lpuart
           - fsl,ls1028a-lpuart
           - fsl,imx7ulp-lpuart
+          - fsl,imx8ulp-lpuart
           - fsl,imx8qxp-lpuart
           - fsl,imxrt1050-lpuart
       - items:
-          - enum:
-              - fsl,imx93-lpuart
-              - fsl,imx8ulp-lpuart
+          - const: fsl,imx8ulp-lpuart
+          - const: fsl,imx7ulp-lpuart
+      - items:
+          - const: fsl,imx93-lpuart
+          - const: fsl,imx8ulp-lpuart
           - const: fsl,imx7ulp-lpuart
       - items:
           - enum:
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH V2 3/3] dt-bindings: serial: fsl-lpuart: add imx8ulp compatible string
  2023-06-26  4:48 ` [PATCH V2 3/3] dt-bindings: serial: fsl-lpuart: add imx8ulp compatible string Sherry Sun
@ 2023-06-26 15:46   ` Krzysztof Kozlowski
  2023-06-27  2:23     ` Sherry Sun
  0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-26 15:46 UTC (permalink / raw)
  To: Sherry Sun, robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo,
	s.hauer, festevam, shenwei.wang, gregkh
  Cc: devicetree, linux-arm-kernel, kernel, linux-serial, linux-kernel,
	linux-imx

On 26/06/2023 06:48, Sherry Sun wrote:
> Add imx8ulp compatible string in lpuart dt-binding, also correct the
> imx93 compatible here, imx93/imx8ulp add some new features based on
> imx7ulp lpuart, so need to add "fsl,imx8ulp-lpuart" for imx93 to enable
> those new features.
> 
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> ---
>  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> index 93062403276b..272bfbb1cdfc 100644
> --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> @@ -21,12 +21,15 @@ properties:
>            - fsl,ls1021a-lpuart
>            - fsl,ls1028a-lpuart
>            - fsl,imx7ulp-lpuart
> +          - fsl,imx8ulp-lpuart

I don't understand this. Commit msg also does not explain this.

>            - fsl,imx8qxp-lpuart
>            - fsl,imxrt1050-lpuart
>        - items:
> -          - enum:
> -              - fsl,imx93-lpuart
> -              - fsl,imx8ulp-lpuart

This could have stayed as enum with one entry which would make your diff
more readable.

> +          - const: fsl,imx8ulp-lpuart
> +          - const: fsl,imx7ulp-lpuart


Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH V2 3/3] dt-bindings: serial: fsl-lpuart: add imx8ulp compatible string
  2023-06-26 15:46   ` Krzysztof Kozlowski
@ 2023-06-27  2:23     ` Sherry Sun
  0 siblings, 0 replies; 6+ messages in thread
From: Sherry Sun @ 2023-06-27  2:23 UTC (permalink / raw)
  To: Krzysztof Kozlowski, robh+dt, krzysztof.kozlowski+dt, conor+dt,
	shawnguo, s.hauer, festevam, Shenwei Wang, gregkh
  Cc: devicetree, linux-arm-kernel, kernel, linux-serial, linux-kernel,
	dl-linux-imx



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: 2023年6月26日 23:47
> To: Sherry Sun <sherry.sun@nxp.com>; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
> shawnguo@kernel.org; s.hauer@pengutronix.de; festevam@gmail.com;
> Shenwei Wang <shenwei.wang@nxp.com>; gregkh@linuxfoundation.org
> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> kernel@pengutronix.de; linux-serial@vger.kernel.org; linux-
> kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH V2 3/3] dt-bindings: serial: fsl-lpuart: add imx8ulp
> compatible string
> 
> On 26/06/2023 06:48, Sherry Sun wrote:
> > Add imx8ulp compatible string in lpuart dt-binding, also correct the
> > imx93 compatible here, imx93/imx8ulp add some new features based on
> > imx7ulp lpuart, so need to add "fsl,imx8ulp-lpuart" for imx93 to
> > enable those new features.
> >
> > Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 9
> > ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > index 93062403276b..272bfbb1cdfc 100644
> > --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > @@ -21,12 +21,15 @@ properties:
> >            - fsl,ls1021a-lpuart
> >            - fsl,ls1028a-lpuart
> >            - fsl,imx7ulp-lpuart
> > +          - fsl,imx8ulp-lpuart
> 
> I don't understand this. Commit msg also does not explain this.

Hi Krzysztof,
Thanks for the catch, seems this is not needed as we have the below 8ulp+7ulp entry for this, will remove it in V3.

> 
> >            - fsl,imx8qxp-lpuart
> >            - fsl,imxrt1050-lpuart
> >        - items:
> > -          - enum:
> > -              - fsl,imx93-lpuart
> > -              - fsl,imx8ulp-lpuart
> 
> This could have stayed as enum with one entry which would make your diff
> more readable.
> 
> > +          - const: fsl,imx8ulp-lpuart
> > +          - const: fsl,imx7ulp-lpuart
> 
Sure, will change it to enum, thanks.

Best Regards
Sherry

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-06-27  2:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-26  4:48 [PATCH V2 0/3] correct the lpuart compatible for imx8dxl and imx93 Sherry Sun
2023-06-26  4:48 ` [PATCH V2 1/3] arm64: dts: imx8dxl: remove "fsl,imx7ulp-lpuart" compatible for imx8dxl Sherry Sun
2023-06-26  4:48 ` [PATCH V2 2/3] arm64: dts: imx93: add "fsl,imx8ulp-lpuart" compatible for imx93 Sherry Sun
2023-06-26  4:48 ` [PATCH V2 3/3] dt-bindings: serial: fsl-lpuart: add imx8ulp compatible string Sherry Sun
2023-06-26 15:46   ` Krzysztof Kozlowski
2023-06-27  2:23     ` Sherry Sun

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®