* [PATCH] ALSA: hda/realtek: Add quirks for Unis H3C Desktop B760 & Q760
@ 2023-06-29 3:00 dengxiang
2023-06-29 5:09 ` kernel test robot
0 siblings, 1 reply; 3+ messages in thread
From: dengxiang @ 2023-06-29 3:00 UTC (permalink / raw)
To: tiwai, yangyingliang, perex; +Cc: linux-kernel, dengxiang
These models use NSIWAY amplifiers for internal speaker, but cannot put
sound outside from these amplifiers. So eapd verbs are needed to initialize
the amplifiers. They can be added during boot to get working sound out
of internal speaker.
Signed-off-by: dengxiang <dengxiang@nfschina.com>
---
sound/pci/hda/patch_realtek.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index afe8253f9a4f..0b944fe8b6ee 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -11201,6 +11201,22 @@ static void alc897_fixup_lenovo_headset_mode(struct hda_codec *codec,
}
}
+static const struct hda_verb alc897_unis_h3c_x500s_eapd_verbs[] = {
+ {0x14, AC_VERB_SET_EAPD_BTLENABLE, 0},
+ { }
+};
+
+static void alc897_fixup_unis_h3c_x500s(struct hda_codec *codec,
+ const struct hda_fixup *fix, int action)
+{
+ struct alc_spec *spec = codec->spec;
+
+ if (action != HDA_FIXUP_ACT_PRE_PROBE)
+ return;
+
+ snd_hda_add_verbs(codec, alc897_unis_h3c_x500s_eapd_verbs);
+}
+
static const struct coef_fw alc668_coefs[] = {
WRITE_COEF(0x01, 0xbebe), WRITE_COEF(0x02, 0xaaaa), WRITE_COEF(0x03, 0x0),
WRITE_COEF(0x04, 0x0180), WRITE_COEF(0x06, 0x0), WRITE_COEF(0x07, 0x0f80),
@@ -11286,6 +11302,7 @@ enum {
ALC897_FIXUP_HP_HSMIC_VERB,
ALC897_FIXUP_LENOVO_HEADSET_MODE,
ALC897_FIXUP_HEADSET_MIC_PIN2,
+ ALC897_FIXUP_UNIS_H3C_X500s,
};
static const struct hda_fixup alc662_fixups[] = {
@@ -11725,6 +11742,10 @@ static const struct hda_fixup alc662_fixups[] = {
.chained = true,
.chain_id = ALC897_FIXUP_LENOVO_HEADSET_MODE
},
+ [ALC897_FIXUP_UNIS_H3C_X500s] = {
+ .type = HDA_FIXUP_FUNC,
+ .v.func = alc897_fixup_unis_h3c_x500s,
+ },
};
static const struct snd_pci_quirk alc662_fixup_tbl[] = {
@@ -11792,6 +11813,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = {
SND_PCI_QUIRK(0x1b35, 0x1234, "CZC ET26", ALC662_FIXUP_CZC_ET26),
SND_PCI_QUIRK(0x1b35, 0x2206, "CZC P10T", ALC662_FIXUP_CZC_P10T),
SND_PCI_QUIRK(0x1c6c, 0x1239, "Compaq N14JP6-V2", ALC897_FIXUP_HP_HSMIC_VERB),
+ SND_PCI_QUIRK(0x10ec, 0x0897, "UNIS H3C X500s", ALC897_FIXUP_UNIS_H3C_X500s),
#if 0
/* Below is a quirk table taken from the old code.
@@ -11886,6 +11908,7 @@ static const struct hda_model_fixup alc662_fixup_models[] = {
{.id = ALC662_FIXUP_USI_HEADSET_MODE, .name = "usi-headset"},
{.id = ALC662_FIXUP_LENOVO_MULTI_CODECS, .name = "dual-codecs"},
{.id = ALC669_FIXUP_ACER_ASPIRE_ETHOS, .name = "aspire-ethos"},
+ {.id = ALC897_FIXUP_UNIS_H3C_X500s, .name = "unis-h3c-x500s"},
{}
};
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ALSA: hda/realtek: Add quirks for Unis H3C Desktop B760 & Q760
2023-06-29 3:00 [PATCH] ALSA: hda/realtek: Add quirks for Unis H3C Desktop B760 & Q760 dengxiang
@ 2023-06-29 5:09 ` kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-06-29 5:09 UTC (permalink / raw)
To: dengxiang, tiwai, yangyingliang, perex
Cc: oe-kbuild-all, linux-kernel, dengxiang
Hi dengxiang,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tiwai-sound/for-next]
[also build test WARNING on tiwai-sound/for-linus linus/master v6.4 next-20230628]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/dengxiang/ALSA-hda-realtek-Add-quirks-for-Unis-H3C-Desktop-B760-Q760/20230629-110147
base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
patch link: https://lore.kernel.org/r/20230629030016.10185-1-dengxiang%40nfschina.com
patch subject: [PATCH] ALSA: hda/realtek: Add quirks for Unis H3C Desktop B760 & Q760
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20230629/202306291229.5w2tIZjA-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230629/202306291229.5w2tIZjA-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306291229.5w2tIZjA-lkp@intel.com/
All warnings (new ones prefixed by >>):
sound/pci/hda/patch_realtek.c: In function 'alc897_fixup_unis_h3c_x500s':
>> sound/pci/hda/patch_realtek.c:11212:26: warning: unused variable 'spec' [-Wunused-variable]
11212 | struct alc_spec *spec = codec->spec;
| ^~~~
vim +/spec +11212 sound/pci/hda/patch_realtek.c
11208
11209 static void alc897_fixup_unis_h3c_x500s(struct hda_codec *codec,
11210 const struct hda_fixup *fix, int action)
11211 {
11212 struct alc_spec *spec = codec->spec;
11213
11214 if (action != HDA_FIXUP_ACT_PRE_PROBE)
11215 return;
11216
11217 snd_hda_add_verbs(codec, alc897_unis_h3c_x500s_eapd_verbs);
11218 }
11219
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ALSA: hda/realtek: Add quirks for Unis H3C Desktop B760 & Q760
@ 2023-06-30 1:26 dengxiang
0 siblings, 0 replies; 3+ messages in thread
From: dengxiang @ 2023-06-30 1:26 UTC (permalink / raw)
To: tiwai, yangyingliang, perex; +Cc: linux-kernel, dengxiang
From: 邓湘 <dengxiang@nfschina.com>
These models use NSIWAY amplifiers for internal speaker, but cannot put
sound outside from these amplifiers. So eapd verbs are needed to initialize
the amplifiers. They can be added during boot to get working sound out
of internal speaker.
Signed-off-by: 邓湘 <dengxiang@nfschina.com>
---
sound/pci/hda/patch_realtek.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index afe8253f9a4f..82f53af2d08a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -11201,6 +11201,20 @@ static void alc897_fixup_lenovo_headset_mode(struct hda_codec *codec,
}
}
+static const struct hda_verb alc897_unis_h3c_x500s_eapd_verbs[] = {
+ {0x14, AC_VERB_SET_EAPD_BTLENABLE, 0},
+ { }
+};
+
+static void alc897_fixup_unis_h3c_x500s(struct hda_codec *codec,
+ const struct hda_fixup *fix, int action)
+{
+ if (action != HDA_FIXUP_ACT_PRE_PROBE)
+ return;
+
+ snd_hda_add_verbs(codec, alc897_unis_h3c_x500s_eapd_verbs);
+}
+
static const struct coef_fw alc668_coefs[] = {
WRITE_COEF(0x01, 0xbebe), WRITE_COEF(0x02, 0xaaaa), WRITE_COEF(0x03, 0x0),
WRITE_COEF(0x04, 0x0180), WRITE_COEF(0x06, 0x0), WRITE_COEF(0x07, 0x0f80),
@@ -11286,6 +11300,7 @@ enum {
ALC897_FIXUP_HP_HSMIC_VERB,
ALC897_FIXUP_LENOVO_HEADSET_MODE,
ALC897_FIXUP_HEADSET_MIC_PIN2,
+ ALC897_FIXUP_UNIS_H3C_X500s,
};
static const struct hda_fixup alc662_fixups[] = {
@@ -11725,6 +11740,10 @@ static const struct hda_fixup alc662_fixups[] = {
.chained = true,
.chain_id = ALC897_FIXUP_LENOVO_HEADSET_MODE
},
+ [ALC897_FIXUP_UNIS_H3C_X500s] = {
+ .type = HDA_FIXUP_FUNC,
+ .v.func = alc897_fixup_unis_h3c_x500s,
+ },
};
static const struct snd_pci_quirk alc662_fixup_tbl[] = {
@@ -11792,6 +11811,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = {
SND_PCI_QUIRK(0x1b35, 0x1234, "CZC ET26", ALC662_FIXUP_CZC_ET26),
SND_PCI_QUIRK(0x1b35, 0x2206, "CZC P10T", ALC662_FIXUP_CZC_P10T),
SND_PCI_QUIRK(0x1c6c, 0x1239, "Compaq N14JP6-V2", ALC897_FIXUP_HP_HSMIC_VERB),
+ SND_PCI_QUIRK(0x10ec, 0x0897, "UNIS H3C X500s", ALC897_FIXUP_UNIS_H3C_X500s),
#if 0
/* Below is a quirk table taken from the old code.
@@ -11886,6 +11906,7 @@ static const struct hda_model_fixup alc662_fixup_models[] = {
{.id = ALC662_FIXUP_USI_HEADSET_MODE, .name = "usi-headset"},
{.id = ALC662_FIXUP_LENOVO_MULTI_CODECS, .name = "dual-codecs"},
{.id = ALC669_FIXUP_ACER_ASPIRE_ETHOS, .name = "aspire-ethos"},
+ {.id = ALC897_FIXUP_UNIS_H3C_X500s, .name = "unis-h3c-x500s"},
{}
};
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-30 1:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-29 3:00 [PATCH] ALSA: hda/realtek: Add quirks for Unis H3C Desktop B760 & Q760 dengxiang
2023-06-29 5:09 ` kernel test robot
2023-06-30 1:26 dengxiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®