From: Mauricio Faria de Oliveira <mfo@canonical.com>
To: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Cc: "Isaac J. Manjarres" <isaacmanjarres@google.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] loop: fix regression from max_loop default value change
Date: Thu, 29 Jun 2023 18:22:54 -0300 [thread overview]
Message-ID: <20230629212256.918239-1-mfo@canonical.com> (raw)
Apparently, there's an unintended consequence of the improvement for max_loop=0
in commit 85c50197716c ("loop: Fix the max_loop commandline argument treatment
when it is set to 0") which might break programs that handle /dev/loop devices.
The (deprecated) autoloading path fails (ENXIO) if the requested minor number
is greater than or equal to the (new) default (CONFIG_BLK_DEV_LOOP_MIN_COUNT),
when [loop.]max_loop is not specified. This behavior used to work previously.
Patch 1/2 just notes the loop driver's autoloading path is deprecated/legacy.
Patch 2/2 detects whether or not max_loop is set to restore default behavior
as before the regression (and keeps the improvement done by the commit above).
More details in the commit message. This does not seem to be urgent, as the
impact is to very specific/custom applications, and most users (eg, losetup)
should not be impacted, as the dynamic add ioctl() is used.
Thanks,
Mauricio
Mauricio Faria de Oliveira (2):
loop: deprecate autoloading callback loop_probe()
loop: do not enforce max_loop hard limit by (new) default
drivers/block/loop.c | 43 ++++++++++++++++++++++++++++++++++++++++---
1 file changed, 40 insertions(+), 3 deletions(-)
--
2.39.2
next reply other threads:[~2023-06-29 21:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 21:22 Mauricio Faria de Oliveira [this message]
2023-06-29 21:22 ` [PATCH 1/2] loop: deprecate autoloading callback loop_probe() Mauricio Faria de Oliveira
2023-06-29 21:22 ` [PATCH 2/2] loop: do not enforce max_loop hard limit by (new) default Mauricio Faria de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230629212256.918239-1-mfo@canonical.com \
--to=mfo@canonical.com \
--cc=axboe@kernel.dk \
--cc=isaacmanjarres@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®