From: Mauricio Faria de Oliveira <mfo@canonical.com>
To: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Cc: "Isaac J. Manjarres" <isaacmanjarres@google.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] loop: deprecate autoloading callback loop_probe()
Date: Thu, 29 Jun 2023 18:22:55 -0300 [thread overview]
Message-ID: <20230629212256.918239-2-mfo@canonical.com> (raw)
In-Reply-To: <20230629212256.918239-1-mfo@canonical.com>
The 'probe' callback in __register_blkdev() is only used
under the CONFIG_BLOCK_LEGACY_AUTOLOAD deprecation guard.
The loop_probe() function is only used for that callback,
so guard it too, accordingly.
See commit fbdee71bb5d8 ("block: deprecate autoloading based on dev_t").
Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
---
drivers/block/loop.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index bc31bb7072a2..21bcd6ffe241 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -2095,6 +2095,7 @@ static void loop_remove(struct loop_device *lo)
put_disk(lo->lo_disk);
}
+#ifdef CONFIG_BLOCK_LEGACY_AUTOLOAD
static void loop_probe(dev_t dev)
{
int idx = MINOR(dev) >> part_shift;
@@ -2103,6 +2104,7 @@ static void loop_probe(dev_t dev)
return;
loop_add(idx);
}
+#endif
static int loop_control_remove(int idx)
{
@@ -2237,8 +2239,11 @@ static int __init loop_init(void)
if (err < 0)
goto err_out;
-
+#ifdef CONFIG_BLOCK_LEGACY_AUTOLOAD
if (__register_blkdev(LOOP_MAJOR, "loop", loop_probe)) {
+#else
+ if (register_blkdev(LOOP_MAJOR, "loop")) {
+#endif
err = -EIO;
goto misc_out;
}
--
2.39.2
next prev parent reply other threads:[~2023-06-29 21:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 21:22 [PATCH 0/2] loop: fix regression from max_loop default value change Mauricio Faria de Oliveira
2023-06-29 21:22 ` Mauricio Faria de Oliveira [this message]
2023-06-29 21:22 ` [PATCH 2/2] loop: do not enforce max_loop hard limit by (new) default Mauricio Faria de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230629212256.918239-2-mfo@canonical.com \
--to=mfo@canonical.com \
--cc=axboe@kernel.dk \
--cc=isaacmanjarres@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®