* [PATCH][next] smb: client: remove redundant pointer 'server'
@ 2023-06-30 11:33 Colin Ian King
2023-07-01 5:23 ` Steve French
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2023-06-30 11:33 UTC (permalink / raw)
To: Steve French, Paulo Alcantara, Ronnie Sahlberg, Shyam Prasad N,
Tom Talpey, linux-cifs, samba-technical
Cc: kernel-janitors, linux-kernel
The pointer 'server' is assigned but never read, the pointer is
redundant and can be removed. Cleans up clang scan build warning:
fs/smb/client/dfs.c:217:3: warning: Value stored to 'server' is
never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
fs/smb/client/dfs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/smb/client/dfs.c b/fs/smb/client/dfs.c
index 26d14dd0482e..1403a2d1ab17 100644
--- a/fs/smb/client/dfs.c
+++ b/fs/smb/client/dfs.c
@@ -143,7 +143,6 @@ static int __dfs_mount_share(struct cifs_mount_ctx *mnt_ctx)
struct smb3_fs_context *ctx = mnt_ctx->fs_ctx;
char *ref_path = NULL, *full_path = NULL;
struct dfs_cache_tgt_iterator *tit;
- struct TCP_Server_Info *server;
struct cifs_tcon *tcon;
char *origin_fullpath = NULL;
char sep = CIFS_DIR_SEP(cifs_sb);
@@ -214,7 +213,6 @@ static int __dfs_mount_share(struct cifs_mount_ctx *mnt_ctx)
} while (rc == -EREMOTE);
if (!rc) {
- server = mnt_ctx->server;
tcon = mnt_ctx->tcon;
spin_lock(&tcon->tc_lock);
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][next] smb: client: remove redundant pointer 'server'
2023-06-30 11:33 [PATCH][next] smb: client: remove redundant pointer 'server' Colin Ian King
@ 2023-07-01 5:23 ` Steve French
0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2023-07-01 5:23 UTC (permalink / raw)
To: Colin Ian King
Cc: Steve French, Paulo Alcantara, Ronnie Sahlberg, Shyam Prasad N,
Tom Talpey, linux-cifs, samba-technical, kernel-janitors,
linux-kernel
merged into cifs-2.6.git for-next
On Fri, Jun 30, 2023 at 6:35 AM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> The pointer 'server' is assigned but never read, the pointer is
> redundant and can be removed. Cleans up clang scan build warning:
>
> fs/smb/client/dfs.c:217:3: warning: Value stored to 'server' is
> never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> fs/smb/client/dfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/smb/client/dfs.c b/fs/smb/client/dfs.c
> index 26d14dd0482e..1403a2d1ab17 100644
> --- a/fs/smb/client/dfs.c
> +++ b/fs/smb/client/dfs.c
> @@ -143,7 +143,6 @@ static int __dfs_mount_share(struct cifs_mount_ctx *mnt_ctx)
> struct smb3_fs_context *ctx = mnt_ctx->fs_ctx;
> char *ref_path = NULL, *full_path = NULL;
> struct dfs_cache_tgt_iterator *tit;
> - struct TCP_Server_Info *server;
> struct cifs_tcon *tcon;
> char *origin_fullpath = NULL;
> char sep = CIFS_DIR_SEP(cifs_sb);
> @@ -214,7 +213,6 @@ static int __dfs_mount_share(struct cifs_mount_ctx *mnt_ctx)
> } while (rc == -EREMOTE);
>
> if (!rc) {
> - server = mnt_ctx->server;
> tcon = mnt_ctx->tcon;
>
> spin_lock(&tcon->tc_lock);
> --
> 2.39.2
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-01 5:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-30 11:33 [PATCH][next] smb: client: remove redundant pointer 'server' Colin Ian King
2023-07-01 5:23 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®