mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] regulator: set variables clkin_name and xin_name storage-class-specifier to static
@ 2023-07-02 13:19 Tom Rix
  0 siblings, 0 replies; only message in thread
From: Tom Rix @ 2023-07-02 13:19 UTC (permalink / raw)
  To: lgirdwood, broonie; +Cc: linux-kernel, Tom Rix

smatch reports
drivers/regulator/raa215300.c:41:12: warning: symbol
  'clkin_name' was not declared. Should it be static?
drivers/regulator/raa215300.c:42:12: warning: symbol
  'xin_name' was not declared. Should it be static?

These variables are only used in their defining file, so it should be static.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/regulator/raa215300.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/raa215300.c b/drivers/regulator/raa215300.c
index 24a1c89f5dbc..d21c6c207226 100644
--- a/drivers/regulator/raa215300.c
+++ b/drivers/regulator/raa215300.c
@@ -38,8 +38,8 @@
 #define RAA215300_REG_BLOCK_EN_RTC_EN	BIT(6)
 #define RAA215300_RTC_DEFAULT_ADDR	0x6f
 
-const char *clkin_name = "clkin";
-const char *xin_name = "xin";
+static const char *clkin_name = "clkin";
+static const char *xin_name = "xin";
 static struct clk *clk;
 
 static const struct regmap_config raa215300_regmap_config = {
-- 
2.27.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-07-02 13:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-02 13:19 [PATCH] regulator: set variables clkin_name and xin_name storage-class-specifier to static Tom Rix

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®