[PATCH] ACPI: fix undeclared variable warnings by including sleep.h

[PATCH] ACPI: fix undeclared variable warnings by including sleep.h

[Ben Dooks]

There are two pieces of data being exported from drivers/acpi/scan.c
(acpi_device_lock and acpi_wakeup_device_list) that don't have their
definitions declared in anything scan.c is including.

Fix the following sparse warnings by including sleep.h to add the
declarations of acpi_device_lock and acpi_wakeup_device_list to
fix the followng sparse warnings:

drivers/acpi/scan.c:42:1: warning: symbol 'acpi_device_lock' was not declared. Should it be static?
drivers/acpi/scan.c:43:1: warning: symbol 'acpi_wakeup_device_list' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
 drivers/acpi/scan.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index 1c3e1e2bb0b5..9556aff69453 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -23,6 +23,7 @@
 #include <linux/dma-direct.h>
 
 #include "internal.h"
+#include "sleep.h"
 
 extern struct acpi_device *acpi_root;
 
-- 
2.40.1

Re: [PATCH] ACPI: fix undeclared variable warnings by including sleep.h

[Rafael J. Wysocki]

On Mon, Jul 3, 2023 at 2:48 PM Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>
> There are two pieces of data being exported from drivers/acpi/scan.c
> (acpi_device_lock and acpi_wakeup_device_list) that don't have their
> definitions declared in anything scan.c is including.
>
> Fix the following sparse warnings by including sleep.h to add the
> declarations of acpi_device_lock and acpi_wakeup_device_list to
> fix the followng sparse warnings:
>
> drivers/acpi/scan.c:42:1: warning: symbol 'acpi_device_lock' was not declared. Should it be static?
> drivers/acpi/scan.c:43:1: warning: symbol 'acpi_wakeup_device_list' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
>  drivers/acpi/scan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index 1c3e1e2bb0b5..9556aff69453 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -23,6 +23,7 @@
>  #include <linux/dma-direct.h>
>
>  #include "internal.h"
> +#include "sleep.h"
>
>  extern struct acpi_device *acpi_root;
>
> --

Applied as 6.5-rc material, thanks!