* [PATCH v2] usb: dwc3: core: set force_gen1 bit in USB31 devices if max speed is SS @ 2023-05-14 14:51 Krishna Kurapati 2023-05-17 0:11 ` Thinh Nguyen 0 siblings, 1 reply; 7+ messages in thread From: Krishna Kurapati @ 2023-05-14 14:51 UTC (permalink / raw) To: Thinh Nguyen, Greg Kroah-Hartman Cc: linux-usb, linux-kernel, quic_ppratap, quic_wcheng, quic_jackp, quic_ugoswami, Krishna Kurapati Currently for dwc3_usb31 controller, if maximum_speed is limited to super-speed in DT, then device mode is limited to SS, but host mode still works in SSP. The documentation for max-speed property is as follows: "Tells USB controllers we want to work up to a certain speed. Incase this isn't passed via DT, USB controllers should default to their maximum HW capability." It doesn't specify that the property is only for device mode. There are cases where we need to limit the host's maximum speed to SuperSpeed only. Use this property for host mode to contrain host's speed to SuperSpeed. Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> --- Link to v1: https://lore.kernel.org/all/20230512170107.18821-1-quic_kriskura@quicinc.com/ Discussion regarding the same at: https://lore.kernel.org/all/e465c69c-3a9d-cbdb-d44e-96b99cfa1a92@quicinc.com/ drivers/usb/dwc3/core.c | 8 ++++++++ drivers/usb/dwc3/core.h | 5 +++++ 2 files changed, 13 insertions(+) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 278cd1c33841..33bc72595e74 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -1262,6 +1262,14 @@ static int dwc3_core_init(struct dwc3 *dwc) } } + if ((hw_mode != DWC3_GHWPARAMS0_MODE_GADGET) && + (DWC3_IP_IS(DWC31)) && + (dwc->maximum_speed == USB_SPEED_SUPER)) { + reg = dwc3_readl(dwc->regs, DWC3_LLUCTL); + reg |= DWC3_LLUCTL_FORCE_GEN1; + dwc3_writel(dwc->regs, DWC3_LLUCTL, reg); + } + return 0; err_power_off_phy: diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index 1968638f29ed..5a251da309d4 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -172,6 +172,8 @@ #define DWC3_OEVTEN 0xcc0C #define DWC3_OSTS 0xcc10 +#define DWC3_LLUCTL 0xd024 + /* Bit fields */ /* Global SoC Bus Configuration INCRx Register 0 */ @@ -655,6 +657,9 @@ #define DWC3_OSTS_VBUSVLD BIT(1) #define DWC3_OSTS_CONIDSTS BIT(0) +/* Force Gen1 speed on Gen2 link */ +#define DWC3_LLUCTL_FORCE_GEN1 BIT(10) + /* Structures */ struct dwc3_trb; -- 2.40.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] usb: dwc3: core: set force_gen1 bit in USB31 devices if max speed is SS 2023-05-14 14:51 [PATCH v2] usb: dwc3: core: set force_gen1 bit in USB31 devices if max speed is SS Krishna Kurapati @ 2023-05-17 0:11 ` Thinh Nguyen 2023-05-17 0:30 ` Thinh Nguyen 2023-07-06 13:48 ` Krishna Kurapati PSSNV 0 siblings, 2 replies; 7+ messages in thread From: Thinh Nguyen @ 2023-05-17 0:11 UTC (permalink / raw) To: Krishna Kurapati Cc: Thinh Nguyen, Greg Kroah-Hartman, linux-usb, linux-kernel, quic_ppratap, quic_wcheng, quic_jackp, quic_ugoswami On Sun, May 14, 2023, Krishna Kurapati wrote: > Currently for dwc3_usb31 controller, if maximum_speed is limited to > super-speed in DT, then device mode is limited to SS, but host mode > still works in SSP. > > The documentation for max-speed property is as follows: > > "Tells USB controllers we want to work up to a certain speed. > Incase this isn't passed via DT, USB controllers should default to > their maximum HW capability." > > It doesn't specify that the property is only for device mode. > There are cases where we need to limit the host's maximum speed to > SuperSpeed only. Use this property for host mode to contrain host's > speed to SuperSpeed. > > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > --- > Link to v1: https://urldefense.com/v3/__https://lore.kernel.org/all/20230512170107.18821-1-quic_kriskura@quicinc.com/__;!!A4F2R9G_pg!dCg_3WK2oNXNb6d0a_VuyjkeeZJTU1aY4dik6g35XB7mtG7EJeR1uPMfxFja49OfXp7Yhsg1yqjnylCYYEg7YCAhqfAZ0Q$ > > Discussion regarding the same at: > https://urldefense.com/v3/__https://lore.kernel.org/all/e465c69c-3a9d-cbdb-d44e-96b99cfa1a92@quicinc.com/__;!!A4F2R9G_pg!dCg_3WK2oNXNb6d0a_VuyjkeeZJTU1aY4dik6g35XB7mtG7EJeR1uPMfxFja49OfXp7Yhsg1yqjnylCYYEg7YCDRLUrJWg$ > > drivers/usb/dwc3/core.c | 8 ++++++++ > drivers/usb/dwc3/core.h | 5 +++++ > 2 files changed, 13 insertions(+) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index 278cd1c33841..33bc72595e74 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -1262,6 +1262,14 @@ static int dwc3_core_init(struct dwc3 *dwc) > } > } > > + if ((hw_mode != DWC3_GHWPARAMS0_MODE_GADGET) && > + (DWC3_IP_IS(DWC31)) && > + (dwc->maximum_speed == USB_SPEED_SUPER)) { > + reg = dwc3_readl(dwc->regs, DWC3_LLUCTL); > + reg |= DWC3_LLUCTL_FORCE_GEN1; > + dwc3_writel(dwc->regs, DWC3_LLUCTL, reg); > + } > + Perhaps this should be done for every usb3 port rather than just the port_0. This patch can go after your multi-port series is added to Greg's branch where you can check for number of usb3 ports. Thanks, Thinh > return 0; > > err_power_off_phy: > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h > index 1968638f29ed..5a251da309d4 100644 > --- a/drivers/usb/dwc3/core.h > +++ b/drivers/usb/dwc3/core.h > @@ -172,6 +172,8 @@ > #define DWC3_OEVTEN 0xcc0C > #define DWC3_OSTS 0xcc10 > > +#define DWC3_LLUCTL 0xd024 > + > /* Bit fields */ > > /* Global SoC Bus Configuration INCRx Register 0 */ > @@ -655,6 +657,9 @@ > #define DWC3_OSTS_VBUSVLD BIT(1) > #define DWC3_OSTS_CONIDSTS BIT(0) > > +/* Force Gen1 speed on Gen2 link */ > +#define DWC3_LLUCTL_FORCE_GEN1 BIT(10) > + > /* Structures */ > > struct dwc3_trb; > -- > 2.40.0 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] usb: dwc3: core: set force_gen1 bit in USB31 devices if max speed is SS 2023-05-17 0:11 ` Thinh Nguyen @ 2023-05-17 0:30 ` Thinh Nguyen 2023-05-17 3:25 ` Krishna Kurapati PSSNV 2023-07-06 13:48 ` Krishna Kurapati PSSNV 1 sibling, 1 reply; 7+ messages in thread From: Thinh Nguyen @ 2023-05-17 0:30 UTC (permalink / raw) To: Krishna Kurapati Cc: Greg Kroah-Hartman, linux-usb, linux-kernel, quic_ppratap, quic_wcheng, quic_jackp, quic_ugoswami On Wed, May 17, 2023, Thinh Nguyen wrote: > On Sun, May 14, 2023, Krishna Kurapati wrote: > > Currently for dwc3_usb31 controller, if maximum_speed is limited to > > super-speed in DT, then device mode is limited to SS, but host mode > > still works in SSP. > > > > The documentation for max-speed property is as follows: > > > > "Tells USB controllers we want to work up to a certain speed. > > Incase this isn't passed via DT, USB controllers should default to > > their maximum HW capability." > > > > It doesn't specify that the property is only for device mode. > > There are cases where we need to limit the host's maximum speed to > > SuperSpeed only. Use this property for host mode to contrain host's > > speed to SuperSpeed. > > > > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > > --- > > Link to v1: https://urldefense.com/v3/__https://lore.kernel.org/all/20230512170107.18821-1-quic_kriskura@quicinc.com/__;!!A4F2R9G_pg!dCg_3WK2oNXNb6d0a_VuyjkeeZJTU1aY4dik6g35XB7mtG7EJeR1uPMfxFja49OfXp7Yhsg1yqjnylCYYEg7YCAhqfAZ0Q$ > > > > Discussion regarding the same at: > > https://urldefense.com/v3/__https://lore.kernel.org/all/e465c69c-3a9d-cbdb-d44e-96b99cfa1a92@quicinc.com/__;!!A4F2R9G_pg!dCg_3WK2oNXNb6d0a_VuyjkeeZJTU1aY4dik6g35XB7mtG7EJeR1uPMfxFja49OfXp7Yhsg1yqjnylCYYEg7YCDRLUrJWg$ > > > > drivers/usb/dwc3/core.c | 8 ++++++++ > > drivers/usb/dwc3/core.h | 5 +++++ > > 2 files changed, 13 insertions(+) > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > index 278cd1c33841..33bc72595e74 100644 > > --- a/drivers/usb/dwc3/core.c > > +++ b/drivers/usb/dwc3/core.c > > @@ -1262,6 +1262,14 @@ static int dwc3_core_init(struct dwc3 *dwc) > > } > > } > > > > + if ((hw_mode != DWC3_GHWPARAMS0_MODE_GADGET) && > > + (DWC3_IP_IS(DWC31)) && > > + (dwc->maximum_speed == USB_SPEED_SUPER)) { > > + reg = dwc3_readl(dwc->regs, DWC3_LLUCTL); > > + reg |= DWC3_LLUCTL_FORCE_GEN1; > > + dwc3_writel(dwc->regs, DWC3_LLUCTL, reg); > > + } > > + > > Perhaps this should be done for every usb3 port rather than just the > port_0. This patch can go after your multi-port series is added to > Greg's branch where you can check for number of usb3 ports. > Can you also add dwc_usb32 settings? It should look something like this: diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 0beaab932e7d..4bd2564aa163 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -1262,6 +1262,40 @@ static int dwc3_core_init(struct dwc3 *dwc) } } + if (hw_mode != DWC3_GHWPARAMS0_MODE_GADGET) { + int i; + + if (DWC3_IP_IS(DWC31) && + dwc->maximum_speed == USB_SPEED_SUPER) { + for (i = 0; i < dwc->num_usb3_ports; i++) { + reg = dwc3_readl(dwc->regs, DWC3_LLUCTL(i)); + reg |= DWC3_LLUCTL_FORCE_GEN1; + dwc3_writel(dwc->regs, DWC3_LLUCTL(i), reg); + } + } + + if (DWC3_IP_IS(DWC32) && + dwc->max_ssp_rate != USB_SSP_GEN_2x2) { + int lsr_speed = -EINVAL; + + if (dwc->maximum_speed == USB_SPEED_SUPER) + lsr_speed = DWC3_LCSR_GEN_1x1; + else if (dwc->max_ssp_rate == USB_SSP_GEN_2x1) + lsr_speed = DWC3_LCSR_GEN_2x1; + else if (dwc->max_ssp_rate == USB_SSP_GEN_1x2) + lsr_speed = DWC3_LCSR_GEN_1x2; + + if (lsr_speed != -EINVAL) { + for (i = 0; i < dwc->num_usb3_ports; i++) { + reg = dwc3_readl(dwc->regs, DWC3_LCSR_USB32CTL(i)); + reg &= ~DWC3_LCSR_USB32CTL_SPEED_MASK; + reg |= lsr_speed; + dwc3_writel(dwc->regs, DWC3_LCSR_USB32CTL(i), reg); + } + } + } + } + return 0; err_power_off_phy: diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index d56457c02996..415e0215fe00 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -170,6 +170,9 @@ #define DWC3_OEVTEN 0xcc0C #define DWC3_OSTS 0xcc10 +#define DWC3_LLUCTL(n) (0xd024 + ((n) * 0x80)) +#define DWC3_LCSR_USB32CTL(n) (0xd07c + ((n) * 0x80)) + /* Bit fields */ /* Global SoC Bus Configuration INCRx Register 0 */ @@ -653,6 +656,16 @@ #define DWC3_OSTS_VBUSVLD BIT(1) #define DWC3_OSTS_CONIDSTS BIT(0) +/* LLUCTL Register */ +#define DWC3_LLUCTL_FORCE_GEN1 BIT(10) + +/* LCSR_USB32CTL Register */ +#define DWC3_LCSR_USB32CTL_SPEED_MASK 0x3 +#define DWC3_LCSR_GEN_1x1 0 +#define DWC3_LCSR_GEN_1x2 1 +#define DWC3_LCSR_GEN_2x1 2 +#define DWC3_LCSR_GEN_2x2 3 + /* Structures */ struct dwc3_trb; -- Thanks, Thinh ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] usb: dwc3: core: set force_gen1 bit in USB31 devices if max speed is SS 2023-05-17 0:30 ` Thinh Nguyen @ 2023-05-17 3:25 ` Krishna Kurapati PSSNV 2023-05-17 23:32 ` Thinh Nguyen 0 siblings, 1 reply; 7+ messages in thread From: Krishna Kurapati PSSNV @ 2023-05-17 3:25 UTC (permalink / raw) To: Thinh Nguyen Cc: Greg Kroah-Hartman, linux-usb, linux-kernel, quic_ppratap, quic_wcheng, quic_jackp, quic_ugoswami On 5/17/2023 6:00 AM, Thinh Nguyen wrote: > On Wed, May 17, 2023, Thinh Nguyen wrote: >> On Sun, May 14, 2023, Krishna Kurapati wrote: >>> Currently for dwc3_usb31 controller, if maximum_speed is limited to >>> super-speed in DT, then device mode is limited to SS, but host mode >>> still works in SSP. >>> >>> The documentation for max-speed property is as follows: >>> >>> "Tells USB controllers we want to work up to a certain speed. >>> Incase this isn't passed via DT, USB controllers should default to >>> their maximum HW capability." >>> >>> It doesn't specify that the property is only for device mode. >>> There are cases where we need to limit the host's maximum speed to >>> SuperSpeed only. Use this property for host mode to contrain host's >>> speed to SuperSpeed. >>> >>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> >>> --- >>> Link to v1: https://urldefense.com/v3/__https://lore.kernel.org/all/20230512170107.18821-1-quic_kriskura@quicinc.com/__;!!A4F2R9G_pg!dCg_3WK2oNXNb6d0a_VuyjkeeZJTU1aY4dik6g35XB7mtG7EJeR1uPMfxFja49OfXp7Yhsg1yqjnylCYYEg7YCAhqfAZ0Q$ >>> >>> Discussion regarding the same at: >>> https://urldefense.com/v3/__https://lore.kernel.org/all/e465c69c-3a9d-cbdb-d44e-96b99cfa1a92@quicinc.com/__;!!A4F2R9G_pg!dCg_3WK2oNXNb6d0a_VuyjkeeZJTU1aY4dik6g35XB7mtG7EJeR1uPMfxFja49OfXp7Yhsg1yqjnylCYYEg7YCDRLUrJWg$ >>> >>> drivers/usb/dwc3/core.c | 8 ++++++++ >>> drivers/usb/dwc3/core.h | 5 +++++ >>> 2 files changed, 13 insertions(+) >>> >>> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c >>> index 278cd1c33841..33bc72595e74 100644 >>> --- a/drivers/usb/dwc3/core.c >>> +++ b/drivers/usb/dwc3/core.c >>> @@ -1262,6 +1262,14 @@ static int dwc3_core_init(struct dwc3 *dwc) >>> } >>> } >>> >>> + if ((hw_mode != DWC3_GHWPARAMS0_MODE_GADGET) && >>> + (DWC3_IP_IS(DWC31)) && >>> + (dwc->maximum_speed == USB_SPEED_SUPER)) { >>> + reg = dwc3_readl(dwc->regs, DWC3_LLUCTL); >>> + reg |= DWC3_LLUCTL_FORCE_GEN1; >>> + dwc3_writel(dwc->regs, DWC3_LLUCTL, reg); >>> + } >>> + >> >> Perhaps this should be done for every usb3 port rather than just the >> port_0. This patch can go after your multi-port series is added to >> Greg's branch where you can check for number of usb3 ports. >> > > Can you also add dwc_usb32 settings? It should look something like this: > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index 0beaab932e7d..4bd2564aa163 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -1262,6 +1262,40 @@ static int dwc3_core_init(struct dwc3 *dwc) > } > } > > + if (hw_mode != DWC3_GHWPARAMS0_MODE_GADGET) { > + int i; > + > + if (DWC3_IP_IS(DWC31) && > + dwc->maximum_speed == USB_SPEED_SUPER) { > + for (i = 0; i < dwc->num_usb3_ports; i++) { > + reg = dwc3_readl(dwc->regs, DWC3_LLUCTL(i)); > + reg |= DWC3_LLUCTL_FORCE_GEN1; > + dwc3_writel(dwc->regs, DWC3_LLUCTL(i), reg); > + } > + } > + > + if (DWC3_IP_IS(DWC32) && > + dwc->max_ssp_rate != USB_SSP_GEN_2x2) { > + int lsr_speed = -EINVAL; > + > + if (dwc->maximum_speed == USB_SPEED_SUPER) > + lsr_speed = DWC3_LCSR_GEN_1x1; > + else if (dwc->max_ssp_rate == USB_SSP_GEN_2x1) > + lsr_speed = DWC3_LCSR_GEN_2x1; > + else if (dwc->max_ssp_rate == USB_SSP_GEN_1x2) > + lsr_speed = DWC3_LCSR_GEN_1x2; > + > + if (lsr_speed != -EINVAL) { > + for (i = 0; i < dwc->num_usb3_ports; i++) { > + reg = dwc3_readl(dwc->regs, DWC3_LCSR_USB32CTL(i)); > + reg &= ~DWC3_LCSR_USB32CTL_SPEED_MASK; > + reg |= lsr_speed; > + dwc3_writel(dwc->regs, DWC3_LCSR_USB32CTL(i), reg); > + } > + } > + } > + } > + > return 0; > > err_power_off_phy: > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h > index d56457c02996..415e0215fe00 100644 > --- a/drivers/usb/dwc3/core.h > +++ b/drivers/usb/dwc3/core.h > @@ -170,6 +170,9 @@ > #define DWC3_OEVTEN 0xcc0C > #define DWC3_OSTS 0xcc10 > > +#define DWC3_LLUCTL(n) (0xd024 + ((n) * 0x80)) > +#define DWC3_LCSR_USB32CTL(n) (0xd07c + ((n) * 0x80)) > + > /* Bit fields */ > > /* Global SoC Bus Configuration INCRx Register 0 */ > @@ -653,6 +656,16 @@ > #define DWC3_OSTS_VBUSVLD BIT(1) > #define DWC3_OSTS_CONIDSTS BIT(0) > > +/* LLUCTL Register */ > +#define DWC3_LLUCTL_FORCE_GEN1 BIT(10) > + > +/* LCSR_USB32CTL Register */ > +#define DWC3_LCSR_USB32CTL_SPEED_MASK 0x3 > +#define DWC3_LCSR_GEN_1x1 0 > +#define DWC3_LCSR_GEN_1x2 1 > +#define DWC3_LCSR_GEN_2x1 2 > +#define DWC3_LCSR_GEN_2x2 3 > + > /* Structures */ > > struct dwc3_trb; > > -- > > Thanks, > Thinh Hi Thinh, Sure, will split it up into two patches and send as a series. But might need your help in testing SSP patch as I don't have any device supporting ssp. Regards, Krishna, ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] usb: dwc3: core: set force_gen1 bit in USB31 devices if max speed is SS 2023-05-17 3:25 ` Krishna Kurapati PSSNV @ 2023-05-17 23:32 ` Thinh Nguyen 0 siblings, 0 replies; 7+ messages in thread From: Thinh Nguyen @ 2023-05-17 23:32 UTC (permalink / raw) To: Krishna Kurapati PSSNV Cc: Thinh Nguyen, Greg Kroah-Hartman, linux-usb, linux-kernel, quic_ppratap, quic_wcheng, quic_jackp, quic_ugoswami On Wed, May 17, 2023, Krishna Kurapati PSSNV wrote: > > > On 5/17/2023 6:00 AM, Thinh Nguyen wrote: > > On Wed, May 17, 2023, Thinh Nguyen wrote: > > > On Sun, May 14, 2023, Krishna Kurapati wrote: > > > > Currently for dwc3_usb31 controller, if maximum_speed is limited to > > > > super-speed in DT, then device mode is limited to SS, but host mode > > > > still works in SSP. > > > > > > > > The documentation for max-speed property is as follows: > > > > > > > > "Tells USB controllers we want to work up to a certain speed. > > > > Incase this isn't passed via DT, USB controllers should default to > > > > their maximum HW capability." > > > > > > > > It doesn't specify that the property is only for device mode. > > > > There are cases where we need to limit the host's maximum speed to > > > > SuperSpeed only. Use this property for host mode to contrain host's > > > > speed to SuperSpeed. > > > > > > > > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > > > > --- > > > > Link to v1: https://urldefense.com/v3/__https://lore.kernel.org/all/20230512170107.18821-1-quic_kriskura@quicinc.com/__;!!A4F2R9G_pg!dCg_3WK2oNXNb6d0a_VuyjkeeZJTU1aY4dik6g35XB7mtG7EJeR1uPMfxFja49OfXp7Yhsg1yqjnylCYYEg7YCAhqfAZ0Q$ > > > > > > > > Discussion regarding the same at: > > > > https://urldefense.com/v3/__https://lore.kernel.org/all/e465c69c-3a9d-cbdb-d44e-96b99cfa1a92@quicinc.com/__;!!A4F2R9G_pg!dCg_3WK2oNXNb6d0a_VuyjkeeZJTU1aY4dik6g35XB7mtG7EJeR1uPMfxFja49OfXp7Yhsg1yqjnylCYYEg7YCDRLUrJWg$ > > > > > > > > drivers/usb/dwc3/core.c | 8 ++++++++ > > > > drivers/usb/dwc3/core.h | 5 +++++ > > > > 2 files changed, 13 insertions(+) > > > > > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > > > index 278cd1c33841..33bc72595e74 100644 > > > > --- a/drivers/usb/dwc3/core.c > > > > +++ b/drivers/usb/dwc3/core.c > > > > @@ -1262,6 +1262,14 @@ static int dwc3_core_init(struct dwc3 *dwc) > > > > } > > > > } > > > > + if ((hw_mode != DWC3_GHWPARAMS0_MODE_GADGET) && > > > > + (DWC3_IP_IS(DWC31)) && > > > > + (dwc->maximum_speed == USB_SPEED_SUPER)) { > > > > + reg = dwc3_readl(dwc->regs, DWC3_LLUCTL); > > > > + reg |= DWC3_LLUCTL_FORCE_GEN1; > > > > + dwc3_writel(dwc->regs, DWC3_LLUCTL, reg); > > > > + } > > > > + > > > > > > Perhaps this should be done for every usb3 port rather than just the > > > port_0. This patch can go after your multi-port series is added to > > > Greg's branch where you can check for number of usb3 ports. > > > > > > > Can you also add dwc_usb32 settings? It should look something like this: > > > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > index 0beaab932e7d..4bd2564aa163 100644 > > --- a/drivers/usb/dwc3/core.c > > +++ b/drivers/usb/dwc3/core.c > > @@ -1262,6 +1262,40 @@ static int dwc3_core_init(struct dwc3 *dwc) > > } > > } > > + if (hw_mode != DWC3_GHWPARAMS0_MODE_GADGET) { > > + int i; > > + > > + if (DWC3_IP_IS(DWC31) && > > + dwc->maximum_speed == USB_SPEED_SUPER) { > > + for (i = 0; i < dwc->num_usb3_ports; i++) { > > + reg = dwc3_readl(dwc->regs, DWC3_LLUCTL(i)); > > + reg |= DWC3_LLUCTL_FORCE_GEN1; > > + dwc3_writel(dwc->regs, DWC3_LLUCTL(i), reg); > > + } > > + } > > + > > + if (DWC3_IP_IS(DWC32) && > > + dwc->max_ssp_rate != USB_SSP_GEN_2x2) { > > + int lsr_speed = -EINVAL; > > + > > + if (dwc->maximum_speed == USB_SPEED_SUPER) > > + lsr_speed = DWC3_LCSR_GEN_1x1; > > + else if (dwc->max_ssp_rate == USB_SSP_GEN_2x1) > > + lsr_speed = DWC3_LCSR_GEN_2x1; > > + else if (dwc->max_ssp_rate == USB_SSP_GEN_1x2) > > + lsr_speed = DWC3_LCSR_GEN_1x2; > > + > > + if (lsr_speed != -EINVAL) { > > + for (i = 0; i < dwc->num_usb3_ports; i++) { > > + reg = dwc3_readl(dwc->regs, DWC3_LCSR_USB32CTL(i)); > > + reg &= ~DWC3_LCSR_USB32CTL_SPEED_MASK; > > + reg |= lsr_speed; > > + dwc3_writel(dwc->regs, DWC3_LCSR_USB32CTL(i), reg); > > + } > > + } > > + } > > + } > > + > > return 0; > > err_power_off_phy: > > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h > > index d56457c02996..415e0215fe00 100644 > > --- a/drivers/usb/dwc3/core.h > > +++ b/drivers/usb/dwc3/core.h > > @@ -170,6 +170,9 @@ > > #define DWC3_OEVTEN 0xcc0C > > #define DWC3_OSTS 0xcc10 > > +#define DWC3_LLUCTL(n) (0xd024 + ((n) * 0x80)) > > +#define DWC3_LCSR_USB32CTL(n) (0xd07c + ((n) * 0x80)) > > + > > /* Bit fields */ > > /* Global SoC Bus Configuration INCRx Register 0 */ > > @@ -653,6 +656,16 @@ > > #define DWC3_OSTS_VBUSVLD BIT(1) > > #define DWC3_OSTS_CONIDSTS BIT(0) > > +/* LLUCTL Register */ > > +#define DWC3_LLUCTL_FORCE_GEN1 BIT(10) > > + > > +/* LCSR_USB32CTL Register */ > > +#define DWC3_LCSR_USB32CTL_SPEED_MASK 0x3 > > +#define DWC3_LCSR_GEN_1x1 0 > > +#define DWC3_LCSR_GEN_1x2 1 > > +#define DWC3_LCSR_GEN_2x1 2 > > +#define DWC3_LCSR_GEN_2x2 3 > > + > > /* Structures */ > > struct dwc3_trb; > > > > -- > > > > Thanks, > > Thinh > > > Hi Thinh, > > Sure, will split it up into two patches and send as a series. But might > need your help in testing SSP patch as I don't have any device supporting > ssp. > Sure. I can do that. btw, it doesn't have to be SSP dwc_usb3x device. SSP devices are pretty common nowadays. Thanks, Thinh ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] usb: dwc3: core: set force_gen1 bit in USB31 devices if max speed is SS 2023-05-17 0:11 ` Thinh Nguyen 2023-05-17 0:30 ` Thinh Nguyen @ 2023-07-06 13:48 ` Krishna Kurapati PSSNV 2023-07-06 22:34 ` Thinh Nguyen 1 sibling, 1 reply; 7+ messages in thread From: Krishna Kurapati PSSNV @ 2023-07-06 13:48 UTC (permalink / raw) To: Thinh Nguyen Cc: Greg Kroah-Hartman, linux-usb, linux-kernel, quic_ppratap, quic_wcheng, quic_jackp, quic_ugoswami On 5/17/2023 5:41 AM, Thinh Nguyen wrote: > On Sun, May 14, 2023, Krishna Kurapati wrote: >> Currently for dwc3_usb31 controller, if maximum_speed is limited to >> super-speed in DT, then device mode is limited to SS, but host mode >> still works in SSP. >> >> The documentation for max-speed property is as follows: >> >> "Tells USB controllers we want to work up to a certain speed. >> Incase this isn't passed via DT, USB controllers should default to >> their maximum HW capability." >> >> It doesn't specify that the property is only for device mode. >> There are cases where we need to limit the host's maximum speed to >> SuperSpeed only. Use this property for host mode to contrain host's >> speed to SuperSpeed. >> >> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> >> --- >> Link to v1: https://urldefense.com/v3/__https://lore.kernel.org/all/20230512170107.18821-1-quic_kriskura@quicinc.com/__;!!A4F2R9G_pg!dCg_3WK2oNXNb6d0a_VuyjkeeZJTU1aY4dik6g35XB7mtG7EJeR1uPMfxFja49OfXp7Yhsg1yqjnylCYYEg7YCAhqfAZ0Q$ >> >> Discussion regarding the same at: >> https://urldefense.com/v3/__https://lore.kernel.org/all/e465c69c-3a9d-cbdb-d44e-96b99cfa1a92@quicinc.com/__;!!A4F2R9G_pg!dCg_3WK2oNXNb6d0a_VuyjkeeZJTU1aY4dik6g35XB7mtG7EJeR1uPMfxFja49OfXp7Yhsg1yqjnylCYYEg7YCDRLUrJWg$ >> >> drivers/usb/dwc3/core.c | 8 ++++++++ >> drivers/usb/dwc3/core.h | 5 +++++ >> 2 files changed, 13 insertions(+) >> >> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c >> index 278cd1c33841..33bc72595e74 100644 >> --- a/drivers/usb/dwc3/core.c >> +++ b/drivers/usb/dwc3/core.c >> @@ -1262,6 +1262,14 @@ static int dwc3_core_init(struct dwc3 *dwc) >> } >> } >> >> + if ((hw_mode != DWC3_GHWPARAMS0_MODE_GADGET) && >> + (DWC3_IP_IS(DWC31)) && >> + (dwc->maximum_speed == USB_SPEED_SUPER)) { >> + reg = dwc3_readl(dwc->regs, DWC3_LLUCTL); >> + reg |= DWC3_LLUCTL_FORCE_GEN1; >> + dwc3_writel(dwc->regs, DWC3_LLUCTL, reg); >> + } >> + > > Perhaps this should be done for every usb3 port rather than just the > port_0. This patch can go after your multi-port series is added to > Greg's branch where you can check for number of usb3 ports. > > Thanks, > Thinh > Hi Thinh, Seems like multiport would take little more time and I need this patch to be ported to ACK for fixing customer issue. Would it be possible to take this patch as is ? Once multiport is done, I will send another patch to include the changes for mutliport as well. Regards, Krishna, ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] usb: dwc3: core: set force_gen1 bit in USB31 devices if max speed is SS 2023-07-06 13:48 ` Krishna Kurapati PSSNV @ 2023-07-06 22:34 ` Thinh Nguyen 0 siblings, 0 replies; 7+ messages in thread From: Thinh Nguyen @ 2023-07-06 22:34 UTC (permalink / raw) To: Krishna Kurapati PSSNV Cc: Thinh Nguyen, Greg Kroah-Hartman, linux-usb, linux-kernel, quic_ppratap, quic_wcheng, quic_jackp, quic_ugoswami On Thu, Jul 06, 2023, Krishna Kurapati PSSNV wrote: > > > On 5/17/2023 5:41 AM, Thinh Nguyen wrote: > > On Sun, May 14, 2023, Krishna Kurapati wrote: > > > Currently for dwc3_usb31 controller, if maximum_speed is limited to > > > super-speed in DT, then device mode is limited to SS, but host mode > > > still works in SSP. > > > > > > The documentation for max-speed property is as follows: > > > > > > "Tells USB controllers we want to work up to a certain speed. > > > Incase this isn't passed via DT, USB controllers should default to > > > their maximum HW capability." > > > > > > It doesn't specify that the property is only for device mode. > > > There are cases where we need to limit the host's maximum speed to > > > SuperSpeed only. Use this property for host mode to contrain host's > > > speed to SuperSpeed. > > > > > > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > > > --- > > > Link to v1: https://urldefense.com/v3/__https://lore.kernel.org/all/20230512170107.18821-1-quic_kriskura@quicinc.com/__;!!A4F2R9G_pg!dCg_3WK2oNXNb6d0a_VuyjkeeZJTU1aY4dik6g35XB7mtG7EJeR1uPMfxFja49OfXp7Yhsg1yqjnylCYYEg7YCAhqfAZ0Q$ > > > > > > Discussion regarding the same at: > > > https://urldefense.com/v3/__https://lore.kernel.org/all/e465c69c-3a9d-cbdb-d44e-96b99cfa1a92@quicinc.com/__;!!A4F2R9G_pg!dCg_3WK2oNXNb6d0a_VuyjkeeZJTU1aY4dik6g35XB7mtG7EJeR1uPMfxFja49OfXp7Yhsg1yqjnylCYYEg7YCDRLUrJWg$ > > > > > > drivers/usb/dwc3/core.c | 8 ++++++++ > > > drivers/usb/dwc3/core.h | 5 +++++ > > > 2 files changed, 13 insertions(+) > > > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > > index 278cd1c33841..33bc72595e74 100644 > > > --- a/drivers/usb/dwc3/core.c > > > +++ b/drivers/usb/dwc3/core.c > > > @@ -1262,6 +1262,14 @@ static int dwc3_core_init(struct dwc3 *dwc) > > > } > > > } > > > + if ((hw_mode != DWC3_GHWPARAMS0_MODE_GADGET) && > > > + (DWC3_IP_IS(DWC31)) && > > > + (dwc->maximum_speed == USB_SPEED_SUPER)) { > > > + reg = dwc3_readl(dwc->regs, DWC3_LLUCTL); > > > + reg |= DWC3_LLUCTL_FORCE_GEN1; > > > + dwc3_writel(dwc->regs, DWC3_LLUCTL, reg); > > > + } > > > + > > > > Perhaps this should be done for every usb3 port rather than just the > > port_0. This patch can go after your multi-port series is added to > > Greg's branch where you can check for number of usb3 ports. > > > > Thanks, > > Thinh > > > > Hi Thinh, > > Seems like multiport would take little more time and I need this patch to > be ported to ACK for fixing customer issue. Would it be possible to take > this patch as is ? Once multiport is done, I will send another patch to > include the changes for mutliport as well. > This is not a fix patch. It will not be upstreamed until the next release even if I Ack it now. Do you think we can get your multi-port series in for the next release along with this? If not, then we can Ack this version first (with a note to update for multi-port later). I think it makes more sense wait and see if we can get your multi-port series for the next release first. What do you think? Thanks, Thinh ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-07-06 22:34 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-05-14 14:51 [PATCH v2] usb: dwc3: core: set force_gen1 bit in USB31 devices if max speed is SS Krishna Kurapati 2023-05-17 0:11 ` Thinh Nguyen 2023-05-17 0:30 ` Thinh Nguyen 2023-05-17 3:25 ` Krishna Kurapati PSSNV 2023-05-17 23:32 ` Thinh Nguyen 2023-07-06 13:48 ` Krishna Kurapati PSSNV 2023-07-06 22:34 ` Thinh Nguyen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®