From: Michal Wilczynski <michal.wilczynski@intel.com>
To: linux-acpi@vger.kernel.org
Cc: rafael@kernel.org, andriy.shevchenko@intel.com,
artem.bityutskiy@linux.intel.com, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com, lenb@kernel.org,
jgross@suse.com, linux-kernel@vger.kernel.org, x86@kernel.org,
Michal Wilczynski <michal.wilczynski@intel.com>
Subject: [PATCH v4 0/9] Prefer using _OSC method over deprecated _PDC
Date: Mon, 10 Jul 2023 17:03:28 +0300 [thread overview]
Message-ID: <20230710140337.1434060-1-michal.wilczynski@intel.com> (raw)
ACPI 3.0 introduced a new Operating System Capabilities _OSC control
method. This method is similar to _PDC, which was marked as deprecated
in ACPI 3.0.
Prefer using _OSC method over deprecated _PDC in the acpi_bus_init(). In
case of the failure of the _OSC, try using _PDC as a fallback.
Testing done:
Tested on physical server with BIOS implementing _OSC methods. In this
case acpi_processor_osc() was executed for each CPU core. acpi_run_osc()
returned success indicating that _OSC method succeeded.
Tested on qemu VM to check whether the code would work on a SeaBios (the
default for qemu, doesn't support _OSC methods, or _PDC). This way I was
able to see how code behaves in case BIOS doesn't implement _OSC. In
that case the function
acpi_run_osc() returned failure, which propagated all the way up to
acpi_early_processor_osc(). The logic responsible for triggering _PDC
execution was triggered correctly.
Tested this using debug messages with printk.
v4:
- move setting processor capabilities bits into arch code
- move workaround for mwait to acpi/x86 directory
- rename ACPI_PDC* constants to more generic ACPI_PROC_CAP*
- introduce new function acpi_early_processor_control_setup()
v3:
- split into more commits to make review easier
- changed "_UID" to METHOD_NAME_UID
- changed hard-coded constant to ACPI_PDC_COLLAB_PROC_PERF
- added Suggested-by tags
- fixed style issues
- fixed whitespaces
- refactored code
v2:
- fixed compilation issues on ia64 and arm
Michal Wilczynski (9):
acpi: Move mwait quirk out of acpi_processor.c
acpi: Move processor_physically_present() to acpi_processor.c
acpi: Refactor arch_acpi_set_pdc_bits()
acpi: Rename ACPI_PDC constants
acpi: Clear C_C2C3_FFH and C_C1_FFH in arch_acpi_set_proc_cap_bits()
acpi: Move setting CAP_SMP_T_SWCOORD to arch_acpi_set_proc_cap_bits()
acpi: Introduce acpi_processor_osc()
acpi: Use _OSC method to convey processor OSPM capabilities
acpi: Remove acpi_hwp_native_thermal_lvt_osc()
arch/ia64/include/asm/acpi.h | 6 +-
arch/x86/include/asm/acpi.h | 24 ++++---
arch/x86/xen/enlighten_pv.c | 8 +--
drivers/acpi/acpi_processor.c | 121 +++++++++++++++++++++++++---------
drivers/acpi/bus.c | 5 +-
drivers/acpi/internal.h | 10 ++-
drivers/acpi/processor_pdc.c | 97 +--------------------------
drivers/acpi/x86/utils.c | 35 ++++++++++
include/acpi/pdc_intel.h | 36 ----------
include/acpi/proc_cap_intel.h | 40 +++++++++++
10 files changed, 194 insertions(+), 188 deletions(-)
delete mode 100644 include/acpi/pdc_intel.h
create mode 100644 include/acpi/proc_cap_intel.h
--
2.41.0
next reply other threads:[~2023-07-10 14:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 14:03 Michal Wilczynski [this message]
2023-07-10 14:03 ` [PATCH v4 1/9] acpi: Move mwait quirk out of acpi_processor.c Michal Wilczynski
2023-07-10 14:03 ` [PATCH v4 2/9] acpi: Move processor_physically_present() to acpi_processor.c Michal Wilczynski
2023-07-10 14:03 ` [PATCH v4 3/9] acpi: Refactor arch_acpi_set_pdc_bits() Michal Wilczynski
2023-07-10 14:03 ` [PATCH v4 4/9] acpi: Rename ACPI_PDC constants Michal Wilczynski
2023-07-10 14:20 ` Andy Shevchenko
2023-07-10 14:03 ` [PATCH v4 5/9] acpi: Clear C_C2C3_FFH and C_C1_FFH in arch_acpi_set_proc_cap_bits() Michal Wilczynski
2023-07-10 14:03 ` [PATCH v4 6/9] acpi: Move setting CAP_SMP_T_SWCOORD to arch_acpi_set_proc_cap_bits() Michal Wilczynski
2023-07-10 14:03 ` [PATCH v4 7/9] acpi: Introduce acpi_processor_osc() Michal Wilczynski
2023-07-10 14:03 ` [PATCH v4 8/9] acpi: Use _OSC method to convey processor OSPM capabilities Michal Wilczynski
2023-07-10 14:03 ` [PATCH v4 9/9] acpi: Remove acpi_hwp_native_thermal_lvt_osc() Michal Wilczynski
2023-07-14 16:12 ` [PATCH v4 0/9] Prefer using _OSC method over deprecated _PDC Rafael J. Wysocki
2023-07-17 10:49 ` Wilczynski, Michal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230710140337.1434060-1-michal.wilczynski@intel.com \
--to=michal.wilczynski@intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rafael@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®