* [PATCH] kernel: kprobes: Remove unnecessary ‘0’ values
@ 2023-07-11 18:53 Li zeming
2023-07-10 9:48 ` Masami Hiramatsu
0 siblings, 1 reply; 2+ messages in thread
From: Li zeming @ 2023-07-11 18:53 UTC (permalink / raw)
To: naveen.n.rao, anil.s.keshavamurthy, davem, mhiramat
Cc: linux-kernel, linux-trace-kernel, Li zeming
it is assigned first, so it does not need to initialize the assignment.
Signed-off-by: Li zeming <zeming@nfschina.com>
---
kernel/kprobes.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index 00e177de91cc..83e6f76fca04 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -1072,7 +1072,7 @@ static int kprobe_ftrace_enabled;
static int __arm_kprobe_ftrace(struct kprobe *p, struct ftrace_ops *ops,
int *cnt)
{
- int ret = 0;
+ int ret;
lockdep_assert_held(&kprobe_mutex);
@@ -1110,7 +1110,7 @@ static int arm_kprobe_ftrace(struct kprobe *p)
static int __disarm_kprobe_ftrace(struct kprobe *p, struct ftrace_ops *ops,
int *cnt)
{
- int ret = 0;
+ int ret;
lockdep_assert_held(&kprobe_mutex);
@@ -2692,7 +2692,7 @@ void kprobe_free_init_mem(void)
static int __init init_kprobes(void)
{
- int i, err = 0;
+ int i, err;
/* FIXME allocate the probe table, currently defined statically */
/* initialize all list heads */
--
2.18.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] kernel: kprobes: Remove unnecessary ‘0’ values
2023-07-11 18:53 [PATCH] kernel: kprobes: Remove unnecessary ‘0’ values Li zeming
@ 2023-07-10 9:48 ` Masami Hiramatsu
0 siblings, 0 replies; 2+ messages in thread
From: Masami Hiramatsu @ 2023-07-10 9:48 UTC (permalink / raw)
To: Li zeming
Cc: naveen.n.rao, anil.s.keshavamurthy, davem, linux-kernel,
linux-trace-kernel
On Wed, 12 Jul 2023 02:53:53 +0800
Li zeming <zeming@nfschina.com> wrote:
> it is assigned first, so it does not need to initialize the assignment.
>
Looks good to me.
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thanks!
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
> kernel/kprobes.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index 00e177de91cc..83e6f76fca04 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -1072,7 +1072,7 @@ static int kprobe_ftrace_enabled;
> static int __arm_kprobe_ftrace(struct kprobe *p, struct ftrace_ops *ops,
> int *cnt)
> {
> - int ret = 0;
> + int ret;
>
> lockdep_assert_held(&kprobe_mutex);
>
> @@ -1110,7 +1110,7 @@ static int arm_kprobe_ftrace(struct kprobe *p)
> static int __disarm_kprobe_ftrace(struct kprobe *p, struct ftrace_ops *ops,
> int *cnt)
> {
> - int ret = 0;
> + int ret;
>
> lockdep_assert_held(&kprobe_mutex);
>
> @@ -2692,7 +2692,7 @@ void kprobe_free_init_mem(void)
>
> static int __init init_kprobes(void)
> {
> - int i, err = 0;
> + int i, err;
>
> /* FIXME allocate the probe table, currently defined statically */
> /* initialize all list heads */
> --
> 2.18.2
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-10 9:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-11 18:53 [PATCH] kernel: kprobes: Remove unnecessary ‘0’ values Li zeming
2023-07-10 9:48 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®