* [PATCH v1] android:Fix error checking for debugfs_create_dir() in binder_init()
@ 2023-07-12 13:39 Wang Ming
2023-07-12 16:35 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Wang Ming @ 2023-07-12 13:39 UTC (permalink / raw)
To: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Martijn Coenen, Joel Fernandes, Christian Brauner, Carlos Llamas,
Suren Baghdasaryan, linux-kernel
Cc: opensource.kernel, Wang Ming
debugfs_create_dir() does not return NULL,but it is
possible to return error pointer. Most incorrect error checks
were fixed,but the one in binder_init() was forgotten.
Fix the remaining error check.
Signed-off-by: Wang Ming <machel@vivo.com>
---
drivers/android/binder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 486c8271cab7..3b5309484df6 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -6566,7 +6566,7 @@ static int __init binder_init(void)
atomic_set(&binder_transaction_log_failed.cur, ~0U);
binder_debugfs_dir_entry_root = debugfs_create_dir("binder", NULL);
- if (binder_debugfs_dir_entry_root) {
+ if (!IS_ERR(binder_debugfs_dir_entry_root)) {
const struct binder_debugfs_entry *db_entry;
binder_for_each_debugfs_entry(db_entry)
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1] android:Fix error checking for debugfs_create_dir() in binder_init()
2023-07-12 13:39 [PATCH v1] android:Fix error checking for debugfs_create_dir() in binder_init() Wang Ming
@ 2023-07-12 16:35 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2023-07-12 16:35 UTC (permalink / raw)
To: Wang Ming
Cc: Arve Hjønnevåg, Todd Kjos, Martijn Coenen,
Joel Fernandes, Christian Brauner, Carlos Llamas,
Suren Baghdasaryan, linux-kernel, opensource.kernel
On Wed, Jul 12, 2023 at 09:39:07PM +0800, Wang Ming wrote:
> debugfs_create_dir() does not return NULL,but it is
> possible to return error pointer. Most incorrect error checks
> were fixed,but the one in binder_init() was forgotten.
>
> Fix the remaining error check.
>
> Signed-off-by: Wang Ming <machel@vivo.com>
> ---
> drivers/android/binder.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 486c8271cab7..3b5309484df6 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -6566,7 +6566,7 @@ static int __init binder_init(void)
> atomic_set(&binder_transaction_log_failed.cur, ~0U);
>
> binder_debugfs_dir_entry_root = debugfs_create_dir("binder", NULL);
> - if (binder_debugfs_dir_entry_root) {
> + if (!IS_ERR(binder_debugfs_dir_entry_root)) {
Again, no need to check this at all.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-12 16:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-12 13:39 [PATCH v1] android:Fix error checking for debugfs_create_dir() in binder_init() Wang Ming
2023-07-12 16:35 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®