* [PATCH v2] tracing/histograms: Return an error if we fail to add histogram to hist_vars list
[not found] <a9ae750e-5ea5-ff07-d031-51f4abefb89d@web.de>
@ 2023-07-14 20:33 ` Mohamed Khalfella
0 siblings, 0 replies; only message in thread
From: Mohamed Khalfella @ 2023-07-14 20:33 UTC (permalink / raw)
To: mhiramat
Cc: Mohamed Khalfella, stable, Steven Rostedt, open list:TRACING,
open list:TRACING
Commit 6018b585e8c6 ("tracing/histograms: Add histograms to hist_vars if
they have referenced variables") added a check to fail histogram creation
if save_hist_vars() failed to add histogram to hist_vars list. But the
commit failed to set ret to failed return code before jumping to
unregister histogram, fix it.
Cc: stable@vger.kernel.org
Fixes: 6018b585e8c6 ("tracing/histograms: Add histograms to hist_vars if they have referenced variables")
Signed-off-by: Mohamed Khalfella <mkhalfella@purestorage.com>
---
kernel/trace/trace_events_hist.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
index c8c61381eba4..d06938ae0717 100644
--- a/kernel/trace/trace_events_hist.c
+++ b/kernel/trace/trace_events_hist.c
@@ -6668,7 +6668,8 @@ static int event_hist_trigger_parse(struct event_command *cmd_ops,
goto out_unreg;
if (has_hist_vars(hist_data) || hist_data->n_var_refs) {
- if (save_hist_vars(hist_data))
+ ret = save_hist_vars(hist_data);
+ if (ret)
goto out_unreg;
}
--
2.34.1
^ permalink raw reply [flat|nested] only message in thread