* [PATCH v2] firmware: Fix an NULL vs IS_ERR() bug in probe
@ 2023-07-16 1:52 Wang Ming
2023-07-16 5:44 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Wang Ming @ 2023-07-16 1:52 UTC (permalink / raw)
To: Dinh Nguyen, Alan Tull, Greg Kroah-Hartman, Richard Gong, linux-kernel
Cc: opensource.kernel, Wang Ming
The devm_memremap() function returns error pointers.
It never returns NULL. Fix the check.
Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver")
Signed-off-by: Wang Ming <machel@vivo.com>
---
drivers/firmware/stratix10-svc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c
index 2d674126160f..935bc0cf913f 100644
--- a/drivers/firmware/stratix10-svc.c
+++ b/drivers/firmware/stratix10-svc.c
@@ -756,7 +756,8 @@ svc_create_memory_pool(struct platform_device *pdev,
paddr = begin;
size = end - begin;
va = devm_memremap(dev, paddr, size, MEMREMAP_WC);
- if (!va) {
+
+ if (IS_ERR(va)) {
dev_err(dev, "fail to remap shared memory\n");
return ERR_PTR(-EINVAL);
}
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] firmware: Fix an NULL vs IS_ERR() bug in probe
2023-07-16 1:52 [PATCH v2] firmware: Fix an NULL vs IS_ERR() bug in probe Wang Ming
@ 2023-07-16 5:44 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2023-07-16 5:44 UTC (permalink / raw)
To: Wang Ming
Cc: Dinh Nguyen, Alan Tull, Richard Gong, linux-kernel, opensource.kernel
On Sun, Jul 16, 2023 at 09:52:57AM +0800, Wang Ming wrote:
> The devm_memremap() function returns error pointers.
> It never returns NULL. Fix the check.
>
> Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver")
> Signed-off-by: Wang Ming <machel@vivo.com>
> ---
> drivers/firmware/stratix10-svc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c
> index 2d674126160f..935bc0cf913f 100644
> --- a/drivers/firmware/stratix10-svc.c
> +++ b/drivers/firmware/stratix10-svc.c
> @@ -756,7 +756,8 @@ svc_create_memory_pool(struct platform_device *pdev,
> paddr = begin;
> size = end - begin;
> va = devm_memremap(dev, paddr, size, MEMREMAP_WC);
> - if (!va) {
> +
> + if (IS_ERR(va)) {
Why did you add an extra blank line?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-16 5:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-16 1:52 [PATCH v2] firmware: Fix an NULL vs IS_ERR() bug in probe Wang Ming
2023-07-16 5:44 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®