From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Krzysztof Hałasa" <khalasa@piap.pl>,
"Wolfram Sang" <wsa@kernel.org>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"open list:WOLFSON MICROELECTRONICS DRIVERS"
<patches@opensource.cirrus.com>,
"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
"open list" <linux-kernel@vger.kernel.org>,
imx@lists.linux.dev, shengjiu.wang@nxp.com
Subject: Re: [PATCH 1/1] ASoC: codec: wm8960: add additional probe check for codec identification
Date: Mon, 17 Jul 2023 09:52:54 +0000 [thread overview]
Message-ID: <20230717095254.GA103419@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20230713222513.1636591-1-Frank.Li@nxp.com>
On Thu, Jul 13, 2023 at 06:25:12PM -0400, Frank Li wrote:
> The wm8960 codec is not readable, resulting in a NACK for address 0x3d (8-bit).
> This can partially indicate it. For example: wm8962 codec use the same address
> but is readable. This additional probe check will help prevent loading the wm8960
> module incorrectly on wm8962 hardware.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
Seems reasonable to me:
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2023-07-17 9:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 22:25 Frank Li
2023-07-17 9:52 ` Charles Keepax [this message]
2023-07-18 12:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230717095254.GA103419@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=Frank.Li@nxp.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=imx@lists.linux.dev \
--cc=khalasa@piap.pl \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®