From: Vladimir Oltean <olteanv@gmail.com>
To: Ante Knezic <ante.knezic@helmholz.de>
Cc: pabeni@redhat.com, andrew@lunn.ch, davem@davemloft.net,
edumazet@google.com, f.fainelli@gmail.com, kuba@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: dsa: mv88e6xxx: Add erratum 3.14 for 88E6390X and 88E6190X
Date: Tue, 18 Jul 2023 18:01:33 +0300 [thread overview]
Message-ID: <20230718150133.4wpnmtks46yxg5lz@skbuf> (raw)
In-Reply-To: <20230718144310.4887-1-ante.knezic@helmholz.de>
On Tue, Jul 18, 2023 at 04:43:10PM +0200, Ante Knezic wrote:
> > It does not apply cleanly to net-next. Please respin. You can retain
> > Andrew's Reviewed-by tag.
>
> Respin might need a complete rework of the patch as with the
> conversion of 88e639x to phylink_pcs (introduced with commit
> e5b732a275f5fae0f1342fb8cf76de654cd51e50) the original code flow
> has completely changed so it will not be as simple as finding a new
> place to stick the patch.
> The new phylink mostly hides away mv88e6xxx_chip struct which is needed
> to identify the correct device and writing to relevant registers has also
> changed in favor of mv88e639x_pcs struct etc.
> I think you can see where I am going with this. In this sense I am not sure
> about keeping the Reviewed-by tag, more likely a complete rewrite
> should be done.
> I will repost V3 once I figure out how to make it work with the new
> framework.
>
Can't you simply replicate the positioning of mv88e6393x_erratum_4_6()
from mv88e6393x_pcs_init()?
next prev parent reply other threads:[~2023-07-18 15:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 16:06 Ante Knezic
2023-07-14 18:42 ` Andrew Lunn
2023-07-18 9:13 ` Paolo Abeni
2023-07-18 14:43 ` Ante Knezic
2023-07-18 15:01 ` Vladimir Oltean [this message]
2023-07-18 15:25 ` Ante Knezic
2023-07-18 15:56 ` Vladimir Oltean
2023-07-19 9:08 ` Ante Knezic
2023-07-19 12:31 ` Ante Knezic
2023-07-18 15:59 ` Andrew Lunn
2023-07-19 9:10 ` Ante Knezic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718150133.4wpnmtks46yxg5lz@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=ante.knezic@helmholz.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®