From: Andrew Lunn <andrew@lunn.ch>
To: Ante Knezic <ante.knezic@helmholz.de>
Cc: olteanv@gmail.com, davem@davemloft.net, edumazet@google.com,
f.fainelli@gmail.com, kuba@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com
Subject: Re: [PATCH net-next v2] net: dsa: mv88e6xxx: Add erratum 3.14 for 88E6390X and 88E6190X
Date: Tue, 18 Jul 2023 17:59:47 +0200 [thread overview]
Message-ID: <61e40941-5e2b-48b5-bbc4-fdd94967aaf1@lunn.ch> (raw)
In-Reply-To: <20230718152512.6848-1-ante.knezic@helmholz.de>
> I don't think so. The erratum from the patch needs to be applied on each
> SERDES reconfiguration or reset. For example, when replugging different
> SFPs (sgmii - 10g - sgmii interface). Erratum 4_6 is done only once?
> My guess is to put it in mv88e639x_sgmii_pcs_post_config but still I
> need the device product number
You might be able to read the product number from the ID registers of
the SERDES, registers 2 and 3 ? That is kind of cleaner. It is the
SERDES which needs the workaround, so look at the SERDES ID ...
- maybe embedding a pointer to the
> mv88e6xxx_chip chip inside the mv88e639x_pcs struct would be the cleanest way.
That would also work.
Andrew
next prev parent reply other threads:[~2023-07-18 16:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 16:06 Ante Knezic
2023-07-14 18:42 ` Andrew Lunn
2023-07-18 9:13 ` Paolo Abeni
2023-07-18 14:43 ` Ante Knezic
2023-07-18 15:01 ` Vladimir Oltean
2023-07-18 15:25 ` Ante Knezic
2023-07-18 15:56 ` Vladimir Oltean
2023-07-19 9:08 ` Ante Knezic
2023-07-19 12:31 ` Ante Knezic
2023-07-18 15:59 ` Andrew Lunn [this message]
2023-07-19 9:10 ` Ante Knezic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61e40941-5e2b-48b5-bbc4-fdd94967aaf1@lunn.ch \
--to=andrew@lunn.ch \
--cc=ante.knezic@helmholz.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®