From: Peter Zijlstra <peterz@infradead.org>
To: luoben@linux.alibaba.com
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
pbonzini@redhat.com, mikelley@microsoft.com, yu.c.chen@intel.com,
"Kenan.Liu" <Kenan.Liu@linux.alibaba.com>,
mingo@redhat.com, juri.lelli@redhat.com,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] Adjust CFS loadbalance to adapt QEMU CPU topology.
Date: Mon, 24 Jul 2023 16:07:46 +0200 [thread overview]
Message-ID: <20230724140746.GB3735636@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <70494547-a538-baf5-0554-6788ac2b45e8@linux.alibaba.com>
On Mon, Jul 24, 2023 at 02:57:57PM +0800, luoben@linux.alibaba.com wrote:
> > Right, why is this a problem? Hyperthreads are supposed to be symmetric,
> > it doesn't matter which of the two are active, the important thing is to
> > only have one active if we can.
> >
> > (Unlike Power7, they have asymmetric SMT)
> >
>
> hi Peter and Vincent,
>
> Some upper-level monitoring logic may take the CPU usage as a metric for
> computing resource scaling. Imbalanced scheduling can create the illusion
> of CPU resource scarcity, leading to more frequent triggering of resource
> expansion by the upper-level scheduling system. However, this is actually
> a waste of resources. So, we think this may be a problem.
This is a problem of your monitoring logic -- there is absolutely no
functional problem with the kernel AFAICT.
Teach the thing about SMT instead.
> Could you please take a further look at PATCH#2? We found that the default
> 'nr' value did not perform well under our scenario, and we believe that
> adjustable variables would be more appropriate.
That patch is tweaking default disabled code -- which we should be
removing sometime soon I suppose. So no.
next prev parent reply other threads:[~2023-07-24 14:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 8:34 Kenan.Liu
2023-07-20 8:34 ` [RFC PATCH 1/2] sched/fair: Adjust CFS loadbalance for machine with qemu native " Kenan.Liu
2023-07-20 8:34 ` [RFC PATCH 2/2] sched/fair: Export a param to control the traverse len when select idle cpu Kenan.Liu
2023-07-20 8:50 ` [RFC PATCH 0/2] Adjust CFS loadbalance to adapt QEMU CPU topology Peter Zijlstra
2023-07-21 2:58 ` Kenan.Liu
2023-07-21 8:33 ` Vincent Guittot
2023-07-21 9:13 ` Peter Zijlstra
2023-07-24 6:57 ` luoben
2023-07-24 14:07 ` Peter Zijlstra [this message]
2023-07-21 9:11 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724140746.GB3735636@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Kenan.Liu@linux.alibaba.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luoben@linux.alibaba.com \
--cc=mgorman@suse.de \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®