* [PATCH] ata: pata_ns87415: mark ns87560_tf_read static
@ 2023-07-26 15:10 Arnd Bergmann
2023-07-26 17:00 ` Sergey Shtylyov
2023-07-27 12:23 ` Serge Semin
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2023-07-26 15:10 UTC (permalink / raw)
To: Damien Le Moal, Jeff Garzik, Alan Cox
Cc: Arnd Bergmann, Sergey Shtylyov, Serge Semin, Bart Van Assche,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The global function triggers a warning because of the missing prototype
drivers/parport/parport_gsc.c: At top level:
drivers/parport/parport_gsc.c:415:5: warning: no previous prototype for 'parport_gsc_init' [-Wmissing-prototypes]
There are no other references to this, so just make it static.
Fixes: c4b5b7b6c4423 ("pata_ns87415: Initial cut at 87415/87560 IDE support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/ata/pata_ns87415.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_ns87415.c b/drivers/ata/pata_ns87415.c
index d60e1f69d7b02..c697219a61a2d 100644
--- a/drivers/ata/pata_ns87415.c
+++ b/drivers/ata/pata_ns87415.c
@@ -260,7 +260,7 @@ static u8 ns87560_check_status(struct ata_port *ap)
* LOCKING:
* Inherited from caller.
*/
-void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
+static void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
{
struct ata_ioports *ioaddr = &ap->ioaddr;
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ata: pata_ns87415: mark ns87560_tf_read static
2023-07-26 15:10 [PATCH] ata: pata_ns87415: mark ns87560_tf_read static Arnd Bergmann
@ 2023-07-26 17:00 ` Sergey Shtylyov
2023-07-27 12:23 ` Serge Semin
1 sibling, 0 replies; 3+ messages in thread
From: Sergey Shtylyov @ 2023-07-26 17:00 UTC (permalink / raw)
To: Arnd Bergmann, Damien Le Moal, Jeff Garzik, Alan Cox
Cc: Arnd Bergmann, Serge Semin, Bart Van Assche, linux-kernel
On 7/26/23 6:10 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The global function triggers a warning because of the missing prototype
>
> drivers/parport/parport_gsc.c: At top level:
> drivers/parport/parport_gsc.c:415:5: warning: no previous prototype for 'parport_gsc_init' [-Wmissing-prototypes]
Wrong pasting? :-)
> There are no other references to this, so just make it static.
>
> Fixes: c4b5b7b6c4423 ("pata_ns87415: Initial cut at 87415/87560 IDE support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
With the messages fixed:
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ata: pata_ns87415: mark ns87560_tf_read static
2023-07-26 15:10 [PATCH] ata: pata_ns87415: mark ns87560_tf_read static Arnd Bergmann
2023-07-26 17:00 ` Sergey Shtylyov
@ 2023-07-27 12:23 ` Serge Semin
1 sibling, 0 replies; 3+ messages in thread
From: Serge Semin @ 2023-07-27 12:23 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Damien Le Moal, Jeff Garzik, Alan Cox, Arnd Bergmann,
Sergey Shtylyov, Bart Van Assche, linux-kernel
On Wed, Jul 26, 2023 at 05:10:23PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The global function triggers a warning because of the missing prototype
>
> drivers/parport/parport_gsc.c: At top level:
> drivers/parport/parport_gsc.c:415:5: warning: no previous prototype for 'parport_gsc_init' [-Wmissing-prototypes]
>
> There are no other references to this, so just make it static.
>
> Fixes: c4b5b7b6c4423 ("pata_ns87415: Initial cut at 87415/87560 IDE support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Looking good.
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
-Serge(y)
> ---
> drivers/ata/pata_ns87415.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_ns87415.c b/drivers/ata/pata_ns87415.c
> index d60e1f69d7b02..c697219a61a2d 100644
> --- a/drivers/ata/pata_ns87415.c
> +++ b/drivers/ata/pata_ns87415.c
> @@ -260,7 +260,7 @@ static u8 ns87560_check_status(struct ata_port *ap)
> * LOCKING:
> * Inherited from caller.
> */
> -void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
> +static void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
> {
> struct ata_ioports *ioaddr = &ap->ioaddr;
>
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-27 12:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-26 15:10 [PATCH] ata: pata_ns87415: mark ns87560_tf_read static Arnd Bergmann
2023-07-26 17:00 ` Sergey Shtylyov
2023-07-27 12:23 ` Serge Semin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome