mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Qais Yousef <qyousef@layalina.io>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
	mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
	rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
	bristot@redhat.com, vschneid@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/fair: remove util_est boosting
Date: Thu, 27 Jul 2023 12:56:26 +0100	[thread overview]
Message-ID: <20230727115626.kmln3cnka3ddpgpp@airbuntu> (raw)
In-Reply-To: <cb0ddea0-2c85-f0ec-f726-14a29cf51fad@arm.com>

On 07/24/23 23:11, Dietmar Eggemann wrote:

> Reran the Jankbench test with the patch (fix) on exactly the same
> platform (Pixel6, Android 12) I used for v3 (base, runnable):
> 
> https://lkml.kernel.org/r/20230515115735.296329-1-dietmar.eggemann@arm.com
> 
> Max_frame_duration:
> +-----------------+------------+
> |     kernel      | value [ms] |
> +-----------------+------------+
> |      base       |   163.1    |
> |    runnable     |   162.0    |
> |       fix       |   157.1    |
> +-----------------+------------+
> 
> Mean_frame_duration:
> +-----------------+------------+----------+
> |     kernel      | value [ms] | diff [%] |
> +-----------------+------------+----------+
> |      base       |    18.0    |    0.0   |
> |    runnable     |    12.7    |  -29.43  |
> |       fix       |    13.0    |  -27.78  |
> +-----------------+------------+----------+
> 
> Jank percentage (Jank deadline 16ms):
> +-----------------+------------+----------+
> |     kernel      | value [%]  | diff [%] |
> +-----------------+------------+----------+
> |      base       |     3.6    |    0.0   |
> |    runnable     |     1.0    |  -68.86  |
> |       fix       |     1.0    |  -68.86  |
> +-----------------+------------+----------+
> 
> Power usage [mW] (total - all CPUs):
> +-----------------+------------+----------+
> |     kernel      | value [mW] | diff [%] |
> +-----------------+------------+----------+
> |      base       |    129.5   |    0.0   |
> |    runnable     |    134.3   |   3.71   |
> |       fix       |    129.9   |   0.31   |
> +-----------------+------------+----------+
> 
> Test results look good to me.
> 
> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Tested-by: Dietmar Eggemann <dietmar.eggemann@arm.com>

Thanks for re-running the test!


Cheers

--
Qais Yousef

  reply	other threads:[~2023-07-27 11:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06 13:51 Vincent Guittot
2023-07-11 15:47 ` Qais Yousef
2023-07-12 15:30   ` Vincent Guittot
2023-07-21 16:09     ` Dietmar Eggemann
2023-07-24 13:06       ` Vincent Guittot
2023-07-24 21:11         ` Dietmar Eggemann
2023-07-27 11:56           ` Qais Yousef [this message]
2023-07-31 10:19 ` [tip: sched/core] " tip-bot2 for Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230727115626.kmln3cnka3ddpgpp@airbuntu \
    --to=qyousef@layalina.io \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®