From: Mark O'Donovan <shiftee@posteo.net>
To: linux-kernel@vger.kernel.org
Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de,
axboe@kernel.dk, kbusch@kernel.org, hare@suse.de,
Mark O'Donovan <shiftee@posteo.net>
Subject: [PATCH 1/2] nvme-auth: unlock mutex in one place only
Date: Thu, 27 Jul 2023 13:47:47 +0000 [thread overview]
Message-ID: <20230727134748.4163796-1-shiftee@posteo.net> (raw)
Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
---
drivers/nvme/host/auth.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c
index daf5d144a8ea..e1a98647c3a2 100644
--- a/drivers/nvme/host/auth.c
+++ b/drivers/nvme/host/auth.c
@@ -758,12 +758,11 @@ static void nvme_queue_auth_work(struct work_struct *work)
__func__, chap->qid);
mutex_lock(&ctrl->dhchap_auth_mutex);
ret = nvme_auth_dhchap_setup_host_response(ctrl, chap);
+ mutex_unlock(&ctrl->dhchap_auth_mutex);
if (ret) {
- mutex_unlock(&ctrl->dhchap_auth_mutex);
chap->error = ret;
goto fail2;
}
- mutex_unlock(&ctrl->dhchap_auth_mutex);
/* DH-HMAC-CHAP Step 3: send reply */
dev_dbg(ctrl->device, "%s: qid %d send reply\n",
--
2.39.2
next reply other threads:[~2023-07-27 13:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 13:47 Mark O'Donovan [this message]
2023-07-27 13:47 ` [PATCH 2/2] nvme-auth: set explanation code for failure2 msgs Mark O'Donovan
2023-07-31 5:58 ` Christoph Hellwig
2023-07-31 16:17 ` Hannes Reinecke
2023-07-31 5:55 ` [PATCH 1/2] nvme-auth: unlock mutex in one place only Christoph Hellwig
2023-07-31 13:51 ` Sagi Grimberg
[not found] ` <28d11fc5-743f-0810-8ab7-3fa2a3f98c65@web.de>
2023-07-31 13:51 ` Christoph Hellwig
[not found] ` <d51771bc-32a6-7424-ba02-bcc8ab9bf3f8@web.de>
2023-07-31 18:18 ` [1/2] " Keith Busch
[not found] ` <f551a681-7893-b2a2-9565-8a4c1bd01e33@web.de>
2023-07-31 18:43 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230727134748.4163796-1-shiftee@posteo.net \
--to=shiftee@posteo.net \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®