From: Peter Zijlstra <peterz@infradead.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: anna-maria@linutronix.de, tglx@linutronix.de,
frederic@kernel.org, gautham.shenoy@amd.com,
linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org,
linux-pm@vger.kernel.org, mingo@redhat.com,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com
Subject: Re: [RFC][PATCH 3/3] cpuidle,teo: Improve state selection
Date: Sat, 29 Jul 2023 10:46:44 +0200 [thread overview]
Message-ID: <20230729084644.GC3945851@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAJZ5v0jk9DApNSo7Nq3ZMJh93NT89u310eHtkDwoS2mRj5N+=Q@mail.gmail.com>
On Fri, Jul 28, 2023 at 07:07:02PM +0200, Rafael J. Wysocki wrote:
> On Fri, Jul 28, 2023 at 5:01 PM Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > When selecting a state, stop when history tells us 66% of recent idles
> > were at or below our current state.
>
> This is not really about "recent idles" AFAICS. It stops the
> selection when 66% of the total sum of the "hits" and "intercepts"
> signals comes from the current state and the states below it. This
> covers the entire history, while the "recent" ones are counted
> separately.
Ah, bad wording perhaps. I found that 'recent' list teo has very hard to
use, also the regular state isn't that long lived as per the reply on
the previous patch.
next prev parent reply other threads:[~2023-07-29 8:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 14:55 [RFC][PATCH 0/3] cpuidle,teo: Improve TEO tick decisions Peter Zijlstra
2023-07-28 14:55 ` [RFC][PATCH 1/3] cpuidle: Inject tick boundary state Peter Zijlstra
2023-07-28 15:36 ` Rafael J. Wysocki
2023-07-29 8:44 ` Peter Zijlstra
2023-07-31 8:01 ` Rafael J. Wysocki
2023-07-31 9:09 ` Peter Zijlstra
2023-07-31 10:35 ` Rafael J. Wysocki
2023-07-31 11:00 ` Rafael J. Wysocki
2023-07-31 11:38 ` Peter Zijlstra
2023-07-31 16:55 ` Rafael J. Wysocki
2023-07-31 17:27 ` Rafael J. Wysocki
2023-07-31 18:06 ` Peter Zijlstra
2023-08-02 10:34 ` Peter Zijlstra
2023-08-02 12:44 ` Rafael J. Wysocki
2023-08-02 13:23 ` Peter Zijlstra
2023-07-28 14:55 ` [RFC][PATCH 2/3] cpuidle,teo: Improve NOHZ management Peter Zijlstra
2023-07-28 16:56 ` Rafael J. Wysocki
2023-07-28 22:01 ` Peter Zijlstra
2023-07-31 10:17 ` Rafael J. Wysocki
2023-07-31 12:02 ` Peter Zijlstra
2023-07-31 17:20 ` Rafael J. Wysocki
2023-07-28 14:55 ` [RFC][PATCH 3/3] cpuidle,teo: Improve state selection Peter Zijlstra
2023-07-28 17:07 ` Rafael J. Wysocki
2023-07-29 8:46 ` Peter Zijlstra [this message]
2023-07-31 11:46 ` [RFC][PATCH 0/3] cpuidle,teo: Improve TEO tick decisions Anna-Maria Behnsen
2023-07-31 17:51 ` Rafael J. Wysocki
2023-08-02 8:12 ` Anna-Maria Behnsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230729084644.GC3945851@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=anna-maria@linutronix.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=frederic@kernel.org \
--cc=gautham.shenoy@amd.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®