mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Suren Baghdasaryan <surenb@google.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>
Subject: kernel/sched/psi.c:1479:17: error: implicit declaration of function 'kernfs_generic_poll'
Date: Mon, 31 Jul 2023 07:20:12 +0800	[thread overview]
Message-ID: <202307310732.r65EQFY0-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   5d0c230f1de8c7515b6567d9afba1f196fb4e2f4
commit: aff037078ecaecf34a7c2afab1341815f90fba5e sched/psi: use kernfs polling functions for PSI trigger polling
date:   3 weeks ago
config: nios2-randconfig-r011-20230731 (https://download.01.org/0day-ci/archive/20230731/202307310732.r65EQFY0-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230731/202307310732.r65EQFY0-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307310732.r65EQFY0-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from kernel/sched/build_utility.c:97:
   kernel/sched/psi.c: In function 'psi_trigger_poll':
>> kernel/sched/psi.c:1479:17: error: implicit declaration of function 'kernfs_generic_poll' [-Werror=implicit-function-declaration]
    1479 |                 kernfs_generic_poll(t->of, wait);
         |                 ^~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/kernfs_generic_poll +1479 kernel/sched/psi.c

  1464	
  1465	__poll_t psi_trigger_poll(void **trigger_ptr,
  1466					struct file *file, poll_table *wait)
  1467	{
  1468		__poll_t ret = DEFAULT_POLLMASK;
  1469		struct psi_trigger *t;
  1470	
  1471		if (static_branch_likely(&psi_disabled))
  1472			return DEFAULT_POLLMASK | EPOLLERR | EPOLLPRI;
  1473	
  1474		t = smp_load_acquire(trigger_ptr);
  1475		if (!t)
  1476			return DEFAULT_POLLMASK | EPOLLERR | EPOLLPRI;
  1477	
  1478		if (t->of)
> 1479			kernfs_generic_poll(t->of, wait);
  1480		else
  1481			poll_wait(file, &t->event_wait, wait);
  1482	
  1483		if (cmpxchg(&t->event, 1, 0) == 1)
  1484			ret |= EPOLLPRI;
  1485	
  1486		return ret;
  1487	}
  1488	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2023-07-30 23:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-30 23:20 kernel test robot [this message]
2023-08-09 19:34 ` [tip: sched/core] sched/psi: Select KERNFS as needed tip-bot2 for Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202307310732.r65EQFY0-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=peterz@infradead.org \
    --cc=surenb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®