kernel/sched/psi.c:1479:17: error: implicit declaration of function 'kernfs_generic_poll'

kernel/sched/psi.c:1479:17: error: implicit declaration of function 'kernfs_generic_poll'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   5d0c230f1de8c7515b6567d9afba1f196fb4e2f4
commit: aff037078ecaecf34a7c2afab1341815f90fba5e sched/psi: use kernfs polling functions for PSI trigger polling
date:   3 weeks ago
config: nios2-randconfig-r011-20230731 (https://download.01.org/0day-ci/archive/20230731/202307310732.r65EQFY0-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230731/202307310732.r65EQFY0-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307310732.r65EQFY0-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from kernel/sched/build_utility.c:97:
   kernel/sched/psi.c: In function 'psi_trigger_poll':
>> kernel/sched/psi.c:1479:17: error: implicit declaration of function 'kernfs_generic_poll' [-Werror=implicit-function-declaration]
    1479 |                 kernfs_generic_poll(t->of, wait);
         |                 ^~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/kernfs_generic_poll +1479 kernel/sched/psi.c

  1464	
  1465	__poll_t psi_trigger_poll(void **trigger_ptr,
  1466					struct file *file, poll_table *wait)
  1467	{
  1468		__poll_t ret = DEFAULT_POLLMASK;
  1469		struct psi_trigger *t;
  1470	
  1471		if (static_branch_likely(&psi_disabled))
  1472			return DEFAULT_POLLMASK | EPOLLERR | EPOLLPRI;
  1473	
  1474		t = smp_load_acquire(trigger_ptr);
  1475		if (!t)
  1476			return DEFAULT_POLLMASK | EPOLLERR | EPOLLPRI;
  1477	
  1478		if (t->of)
> 1479			kernfs_generic_poll(t->of, wait);
  1480		else
  1481			poll_wait(file, &t->event_wait, wait);
  1482	
  1483		if (cmpxchg(&t->event, 1, 0) == 1)
  1484			ret |= EPOLLPRI;
  1485	
  1486		return ret;
  1487	}
  1488	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

[tip: sched/core] sched/psi: Select KERNFS as needed

[tip-bot2 for Randy Dunlap]

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     98dfdd9ee93995a408192dbbf3dd219ba23e3738
Gitweb:        https://git.kernel.org/tip/98dfdd9ee93995a408192dbbf3dd219ba23e3738
Author:        Randy Dunlap <rdunlap@infradead.org>
AuthorDate:    Sun, 30 Jul 2023 20:07:40 -07:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Wed, 02 Aug 2023 16:19:25 +02:00

sched/psi: Select KERNFS as needed

Users of KERNFS should select it to enforce its being built, so
do this to prevent a build error.

In file included from ../kernel/sched/build_utility.c:97:
../kernel/sched/psi.c: In function 'psi_trigger_poll':
../kernel/sched/psi.c:1479:17: error: implicit declaration of function 'kernfs_generic_poll' [-Werror=implicit-function-declaration]
 1479 |                 kernfs_generic_poll(t->of, wait);

Fixes: aff037078eca ("sched/psi: use kernfs polling functions for PSI trigger polling")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Suren Baghdasaryan <surenb@google.com>
Link: lore.kernel.org/r/202307310732.r65EQFY0-lkp@intel.com
---
 init/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/init/Kconfig b/init/Kconfig
index f7f65af..5e7d488 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -629,6 +629,7 @@ config TASK_IO_ACCOUNTING
 
 config PSI
 	bool "Pressure stall information tracking"
+	select KERNFS
 	help
 	  Collect metrics that indicate how overcommitted the CPU, memory,
 	  and IO capacity are in the system.