* [PATCH] sched/topology: Covered all cpus of same node in asymmetric node setups
@ 2023-07-29 22:22 Bing Huang
2023-07-31 13:36 ` Peter Zijlstra
0 siblings, 1 reply; 2+ messages in thread
From: Bing Huang @ 2023-07-29 22:22 UTC (permalink / raw)
To: dietmar.eggemann
Cc: rostedt, brauner, bristot, bsegall, juri.lelli, linux-kernel,
mgorman, mingo, peterz, vincent.guittot
in asymmetric node setups, if one cpu'sd spans is empty in some depth,
others in same node do
Signed-off-by: Bing Huang <huangbing@kylinos.cn>
---
kernel/sched/topology.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 7cfcfe5d27b9..8c5372ad7694 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -1045,8 +1045,10 @@ build_overlap_sched_groups(struct sched_domain *sd, int cpu)
* Domains should always include the CPU they're built on, so
* check that.
*/
- if (!cpumask_test_cpu(i, sched_domain_span(sibling)))
+ if (!cpumask_test_cpu(i, sched_domain_span(sibling))) {
+ cpumask_or(covered, covered, cpumask_of_node(cpu_to_node(i)));
continue;
+ }
/*
* Usually we build sched_group by sibling's child sched_domain
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] sched/topology: Covered all cpus of same node in asymmetric node setups
2023-07-29 22:22 [PATCH] sched/topology: Covered all cpus of same node in asymmetric node setups Bing Huang
@ 2023-07-31 13:36 ` Peter Zijlstra
0 siblings, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2023-07-31 13:36 UTC (permalink / raw)
To: Bing Huang
Cc: dietmar.eggemann, rostedt, brauner, bristot, bsegall, juri.lelli,
linux-kernel, mgorman, mingo, vincent.guittot
On Sun, Jul 30, 2023 at 06:22:03AM +0800, Bing Huang wrote:
> in asymmetric node setups, if one cpu'sd spans is empty in some depth,
> others in same node do
Sorry, what?!?
> Signed-off-by: Bing Huang <huangbing@kylinos.cn>
> ---
> kernel/sched/topology.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index 7cfcfe5d27b9..8c5372ad7694 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -1045,8 +1045,10 @@ build_overlap_sched_groups(struct sched_domain *sd, int cpu)
> * Domains should always include the CPU they're built on, so
> * check that.
> */
> - if (!cpumask_test_cpu(i, sched_domain_span(sibling)))
> + if (!cpumask_test_cpu(i, sched_domain_span(sibling))) {
> + cpumask_or(covered, covered, cpumask_of_node(cpu_to_node(i)));
> continue;
> + }
>
> /*
> * Usually we build sched_group by sibling's child sched_domain
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-31 13:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-29 22:22 [PATCH] sched/topology: Covered all cpus of same node in asymmetric node setups Bing Huang
2023-07-31 13:36 ` Peter Zijlstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®