From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Surong Pang <surong.pang@unisoc.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Orson.Zhai@unisoc.com" <Orson.Zhai@unisoc.com>,
"Chunyan.Zhang@unisoc.com" <Chunyan.Zhang@unisoc.com>,
"Zhiyong.liu@unisoc.com" <Zhiyong.liu@unisoc.com>,
"Surong.Pang@gmail.com" <Surong.Pang@gmail.com>
Subject: Re: [PATCH] usb: dwc3: gadget: Let pm runtime get/put paired
Date: Tue, 1 Aug 2023 01:06:12 +0000 [thread overview]
Message-ID: <20230801010611.33srb4fymisx6wch@synopsys.com> (raw)
In-Reply-To: <20230801005651.29863-1-surong.pang@unisoc.com>
On Tue, Aug 01, 2023, Surong Pang wrote:
> Pm_runtime_get is called when setting pending_events to true.
> Pm_runtime_put is needed for pairing with pm_runtime_get.
>
> Fixes: fc8bb91bc83e ("usb: dwc3: implement runtime PM")
> Signed-off-by: Surong Pang <surong.pang@unisoc.com>
> ---
> drivers/usb/dwc3/gadget.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 5fd067151fbf..9c835c5f9928 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -4720,5 +4720,6 @@ void dwc3_gadget_process_pending_events(struct dwc3 *dwc)
> dwc3_interrupt(dwc->irq_gadget, dwc->ev_buf);
> dwc->pending_events = false;
> enable_irq(dwc->irq_gadget);
> + pm_runtime_put(dwc->dev);
> }
> }
> --
> 2.17.1
>
You need to properly increment the patch version every new submission
and note what are the new changes. Otherwise Greg won't know which patch
to pick up. Please resubmit at least v2 with note of the changes.
Thanks,
Thinh
next prev parent reply other threads:[~2023-08-01 1:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 0:56 Surong Pang
2023-08-01 1:06 ` Thinh Nguyen [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-07-31 2:33 Surong Pang
2023-08-01 0:49 ` Thinh Nguyen
2023-08-01 4:44 ` gregkh
2023-08-01 23:56 ` Thinh Nguyen
2023-08-04 12:38 ` gregkh
2023-07-28 7:39 [PATCH] usb: dwc3: gadget: let " Surong Pang
2023-07-28 10:45 ` Greg KH
2023-07-29 8:43 ` surong pang
2023-07-30 11:24 ` Greg KH
2023-07-27 0:51 Surong Pang
2023-07-27 8:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801010611.33srb4fymisx6wch@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=Chunyan.Zhang@unisoc.com \
--cc=Orson.Zhai@unisoc.com \
--cc=Surong.Pang@gmail.com \
--cc=Zhiyong.liu@unisoc.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=surong.pang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®