From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Surong Pang <surong.pang@unisoc.com>,
"felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Orson.Zhai@unisoc.com" <Orson.Zhai@unisoc.com>,
"Chunyan.Zhang@unisoc.com" <Chunyan.Zhang@unisoc.com>,
"Zhiyong.liu@unisoc.com" <Zhiyong.liu@unisoc.com>,
"Surong.Pang@gmail.com" <Surong.Pang@gmail.com>
Subject: Re: [PATCH] usb: dwc3: gadget: Let pm runtime get/put paired
Date: Tue, 1 Aug 2023 23:56:26 +0000 [thread overview]
Message-ID: <20230801235616.i2k4rq4xroesuwbf@synopsys.com> (raw)
In-Reply-To: <2023080139-treason-emboss-75be@gregkh>
On Tue, Aug 01, 2023, gregkh@linuxfoundation.org wrote:
> On Tue, Aug 01, 2023 at 12:49:24AM +0000, Thinh Nguyen wrote:
> > Hi,
> >
> > On Mon, Jul 31, 2023, Surong Pang wrote:
> > > Pm_runtime_get is called when setting pending_events to true.
> > > Pm_runtime_put is needed for pairing with pm_runtime_get.
> > >
> > > Fixes: fc8bb91bc83ef ("usb: dwc3: implement runtime PM")
> >
> > Please fix your Fixes tag. Run checkpatch.pl before submit.
>
> I don't see what's wrong with it, one extra character is just fine.
>
This inconsistency bugs me a bit. :)
It's noted in the kernel documentation that it should be tagged with the
first 12 char of the commit id, and the checkpatch also complaints when
it's not.
Just trying to be consistent and request to run for checkpatch and fix
these things. If these issues should be ignored, I'll keep it in mind...
BR,
Thinh
next prev parent reply other threads:[~2023-08-01 23:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 2:33 Surong Pang
2023-08-01 0:49 ` Thinh Nguyen
2023-08-01 4:44 ` gregkh
2023-08-01 23:56 ` Thinh Nguyen [this message]
2023-08-04 12:38 ` gregkh
-- strict thread matches above, loose matches on Subject: below --
2023-08-01 0:56 Surong Pang
2023-08-01 1:06 ` Thinh Nguyen
2023-07-28 7:39 [PATCH] usb: dwc3: gadget: let " Surong Pang
2023-07-28 10:45 ` Greg KH
2023-07-29 8:43 ` surong pang
2023-07-30 11:24 ` Greg KH
2023-07-27 0:51 Surong Pang
2023-07-27 8:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801235616.i2k4rq4xroesuwbf@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=Chunyan.Zhang@unisoc.com \
--cc=Orson.Zhai@unisoc.com \
--cc=Surong.Pang@gmail.com \
--cc=Zhiyong.liu@unisoc.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=surong.pang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®