From: Steven Rostedt <rostedt@goodmis.org>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/rt: move back to RT_GROUP_SCHED and rename it child
Date: Tue, 1 Aug 2023 10:00:30 -0400 [thread overview]
Message-ID: <20230801100030.5efec7e2@gandalf.local.home> (raw)
In-Reply-To: <20230801062714.3424299-1-yajun.deng@linux.dev>
On Tue, 1 Aug 2023 14:27:14 +0800
Yajun Deng <yajun.deng@linux.dev> wrote:
> @@ -228,13 +228,10 @@ void init_tg_rt_entry(struct task_group *tg, struct rt_rq *rt_rq,
> if (!rt_se)
> return;
>
> - if (!parent)
> - rt_se->rt_rq = &rq->rt;
> - else
> - rt_se->rt_rq = parent->my_q;
> -
> + rt_se->rt_rq = parent->my_q;
So when this is called with parent = NULL, this will crash?
-- Steve
> rt_se->my_q = rt_rq;
> rt_se->parent = parent;
> + parent->child = rt_se;
> INIT_LIST_HEAD(&rt_se->run_list);
> }
>
next prev parent reply other threads:[~2023-08-01 14:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 6:27 Yajun Deng
2023-08-01 14:00 ` Steven Rostedt [this message]
2023-08-01 14:02 ` Steven Rostedt
2023-09-19 3:51 Yajun Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801100030.5efec7e2@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®