From: Nishanth Menon <nm@ti.com>
To: "Kumar, Udit" <u-kumar1@ti.com>
Cc: Vaishnav Achath <vaishnav.a@ti.com>, <vigneshr@ti.com>,
<kristo@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<t-konduru@ti.com>, <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Bhavya Kapoor <b-kapoor@ti.com>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-j784s4-evm: Correct Pin mux offset for ospi
Date: Mon, 7 Aug 2023 10:54:59 -0500 [thread overview]
Message-ID: <20230807155459.j36h2477xxdsigqn@overrule> (raw)
In-Reply-To: <5f882fff-4f68-b762-a8f3-a0f228046a52@ti.com>
On 20:33-20230807, Kumar, Udit wrote:
> Thanks Vaishnav.
>
> Hi Nishanth,
>
> On 8/7/2023 8:09 PM, Vaishnav Achath wrote:
> > Hi Udit,
> >
> > On 02/08/23 17:11, Udit Kumar wrote:
> > > [...]
> > > Thank you for the patch,
> > >
> > > For OSPI functionality:
> > >
> > > Tested-by: Vaishnav Achath <vaishnav.a@ti.com>
> > >
> > > before: https://gist.github.com/vaishnavachath/c87275e53f6ae38bacc44c65ed09c733
> > > (QSPI probe fails due to wrong pinmux)
> > > after: https://gist.github.com/vaishnavachath/b5f6147cfae5218815aca94ec0dfd991
> > > (both QSPI, OSPI is functional)
> > >
> > > heads-up :
> > > I see the following warnings for ADC:
> > >
> > > ```
> > > pinctrl-single 4301c068.pinctrl: mux offset out of range: 0x134 (0x120)
> > > pinctrl-single 4301c068.pinctrl: could not add functions for
> > > mcu-adc0-default-pins 308x
> > > pinctrl-single 4301c068.pinctrl: mux offset out of range: 0x154 (0x120)
> > > pinctrl-single 4301c068.pinctrl: could not add functions for
> > > mcu-adc1-default-pins 340x
> > > ```
> > >
> > > mcu_adc0_pins_default and mcu_adc1_pins_default entries needs to have the
> > > wkup_pmx2 base (0x68) subtracted to get the appropriate offsets, not sure if
> > > there is already a patch addressing the same or should be part of this patch.
>
> let me know, if you are ok with other patch to address adc pin mux or I
> should respin with adc changes
adc fixes come separate on top - for the next time please:
Roll these fixes out in a single series.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2023-08-07 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 11:41 Udit Kumar
2023-08-07 14:39 ` Vaishnav Achath
2023-08-07 15:03 ` Kumar, Udit
2023-08-07 15:54 ` Nishanth Menon [this message]
2023-08-07 16:57 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807155459.j36h2477xxdsigqn@overrule \
--to=nm@ti.com \
--cc=b-kapoor@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=t-konduru@ti.com \
--cc=u-kumar1@ti.com \
--cc=vaishnav.a@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®