mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aaron Tomlin <atomlin@atomlin.com>
To: tj@kernel.org
Cc: atomlin@atomlin.com, jiangshanlai@gmail.com,
	linux-kernel@vger.kernel.org, peterz@infradead.org
Subject: Re: [PATCH] workqueue: Rename rescuer kworker
Date: Tue,  8 Aug 2023 12:24:21 +0100	[thread overview]
Message-ID: <20230808112421.3390505-1-atomlin@atomlin.com> (raw)
In-Reply-To: <ZNFxmnGHxV0z5gKA@slm.duckdns.org>

> I'm not necessarily against the rename but you can't, or at least
> shouldn't, modify the cpu affinity of any workqueue worker. You don't
> know what that worker is going to be executing even at the moment when
> the cpu affinity change is committed, let alone in any future. Can you
> please drop that part from the patch description? It doesn't make a lot
> of sense.

Hi Tejun,

Understood - will do. Initially, I wanted to stress the point that
user-mode should not pay any attention to a rescuer kworker's CPU affinity
since by design it can run on any possible CPU.
According to housekeeping_setup() and workqueue_init_early(), if I
understand correctly, when kernel parameter nohz_full is set then each
unbound kworker is not permitted to execute on any CPU in the specified
range i.e. the unbound workqueue cpumask is set based on the housekeeping
cpumask only. So, that's good enough.


Kind regards,

-- 
Aaron Tomlin

      reply	other threads:[~2023-08-08 17:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-07 22:06 Aaron Tomlin
2023-08-07 22:35 ` Tejun Heo
2023-08-08 11:24   ` Aaron Tomlin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230808112421.3390505-1-atomlin@atomlin.com \
    --to=atomlin@atomlin.com \
    --cc=jiangshanlai@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®