mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Aaron Tomlin <atomlin@atomlin.com>
Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org,
	peterz@infradead.org
Subject: Re: [PATCH] workqueue: Rename rescuer kworker
Date: Mon, 7 Aug 2023 12:35:06 -1000	[thread overview]
Message-ID: <ZNFxmnGHxV0z5gKA@slm.duckdns.org> (raw)
In-Reply-To: <20230807220637.3203739-1-atomlin@atomlin.com>

On Mon, Aug 07, 2023 at 11:06:37PM +0100, Aaron Tomlin wrote:
> Each CPU-specific and unbound kworker kthread conforms to a particular
> naming scheme. However, this does not extend to the rescuer kworker.
> At present, a rescuer kworker is simply named according to its
> workqueue's name. This can be cryptic.
> 
> From the context of user-mode, it can be useful to identify a rescuer
> kworker since their CPU affinity cannot be modified and their initial

I'm not necessarily against the rename but you can't, or at least shouldn't,
modify the cpu affinity of any workqueue worker. You don't know what that
worker is going to be executing even at the moment when the cpu affinity
change is committed, let alone in any future. Can you please drop that part
from the patch description? It doesn't make a lot of sense.

Thanks.

-- 
tejun

  reply	other threads:[~2023-08-07 22:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-07 22:06 Aaron Tomlin
2023-08-07 22:35 ` Tejun Heo [this message]
2023-08-08 11:24   ` Aaron Tomlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZNFxmnGHxV0z5gKA@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=atomlin@atomlin.com \
    --cc=jiangshanlai@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®