* [PATCH -next] vfio/fsl-mc: use module_fsl_mc_driver() macro
@ 2023-08-11 9:29 Yang Yingliang
2023-08-11 15:18 ` Alex Williamson
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2023-08-11 9:29 UTC (permalink / raw)
To: linux-kernel, kvm; +Cc: diana.craciun, alex.williamson, yangyingliang
The driver init/exit() function don't do anything special, it
can use the module_fsl_mc_driver() macro to eliminate boilerplate
code.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/vfio/fsl-mc/vfio_fsl_mc.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc.c b/drivers/vfio/fsl-mc/vfio_fsl_mc.c
index f2140e94d41e..8053f13c2be5 100644
--- a/drivers/vfio/fsl-mc/vfio_fsl_mc.c
+++ b/drivers/vfio/fsl-mc/vfio_fsl_mc.c
@@ -604,19 +604,7 @@ static struct fsl_mc_driver vfio_fsl_mc_driver = {
},
.driver_managed_dma = true,
};
-
-static int __init vfio_fsl_mc_driver_init(void)
-{
- return fsl_mc_driver_register(&vfio_fsl_mc_driver);
-}
-
-static void __exit vfio_fsl_mc_driver_exit(void)
-{
- fsl_mc_driver_unregister(&vfio_fsl_mc_driver);
-}
-
-module_init(vfio_fsl_mc_driver_init);
-module_exit(vfio_fsl_mc_driver_exit);
+module_fsl_mc_driver(vfio_fsl_mc_driver);
MODULE_LICENSE("Dual BSD/GPL");
MODULE_DESCRIPTION("VFIO for FSL-MC devices - User Level meta-driver");
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH -next] vfio/fsl-mc: use module_fsl_mc_driver() macro
2023-08-11 9:29 [PATCH -next] vfio/fsl-mc: use module_fsl_mc_driver() macro Yang Yingliang
@ 2023-08-11 15:18 ` Alex Williamson
0 siblings, 0 replies; 2+ messages in thread
From: Alex Williamson @ 2023-08-11 15:18 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, kvm, diana.craciun
On Fri, 11 Aug 2023 17:29:11 +0800
Yang Yingliang <yangyingliang@huawei.com> wrote:
> The driver init/exit() function don't do anything special, it
> can use the module_fsl_mc_driver() macro to eliminate boilerplate
> code.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/vfio/fsl-mc/vfio_fsl_mc.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
Your colleague submitted a nearly identical patch, but also removing
the redundant module owner, 2 days ago:
https://lore.kernel.org/all/20230809131536.4021639-1-lizetao1@huawei.com/
Thanks,
Alex
>
> diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc.c b/drivers/vfio/fsl-mc/vfio_fsl_mc.c
> index f2140e94d41e..8053f13c2be5 100644
> --- a/drivers/vfio/fsl-mc/vfio_fsl_mc.c
> +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc.c
> @@ -604,19 +604,7 @@ static struct fsl_mc_driver vfio_fsl_mc_driver = {
> },
> .driver_managed_dma = true,
> };
> -
> -static int __init vfio_fsl_mc_driver_init(void)
> -{
> - return fsl_mc_driver_register(&vfio_fsl_mc_driver);
> -}
> -
> -static void __exit vfio_fsl_mc_driver_exit(void)
> -{
> - fsl_mc_driver_unregister(&vfio_fsl_mc_driver);
> -}
> -
> -module_init(vfio_fsl_mc_driver_init);
> -module_exit(vfio_fsl_mc_driver_exit);
> +module_fsl_mc_driver(vfio_fsl_mc_driver);
>
> MODULE_LICENSE("Dual BSD/GPL");
> MODULE_DESCRIPTION("VFIO for FSL-MC devices - User Level meta-driver");
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-11 15:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-11 9:29 [PATCH -next] vfio/fsl-mc: use module_fsl_mc_driver() macro Yang Yingliang
2023-08-11 15:18 ` Alex Williamson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®