* [PATCH v1] watchdog: intel-mid_wdt: add MODULE_ALIAS() to allow auto-load
@ 2023-08-11 12:02 Raag Jadav
2023-08-11 12:20 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Raag Jadav @ 2023-08-11 12:02 UTC (permalink / raw)
To: wim, linux, mika.westerberg, andriy.shevchenko
Cc: linux-watchdog, linux-kernel, mallikarjunappa.sangannavar,
pandith.n, Raag Jadav
When built with CONFIG_INTEL_MID_WATCHDOG=m, currently the driver
needs to be loaded manually, for the lack of module alias.
This causes unintended resets in cases where watchdog timer is
set-up by bootloader and the driver is not explicitly loaded.
Add MODULE_ALIAS() to load the driver automatically at boot and
avoid this issue.
Fixes: 87a1ef8058d9 ("watchdog: add Intel MID watchdog driver support")
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/watchdog/intel-mid_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
index 9b2173f765c8..fb7fae750181 100644
--- a/drivers/watchdog/intel-mid_wdt.c
+++ b/drivers/watchdog/intel-mid_wdt.c
@@ -203,3 +203,4 @@ module_platform_driver(mid_wdt_driver);
MODULE_AUTHOR("David Cohen <david.a.cohen@linux.intel.com>");
MODULE_DESCRIPTION("Watchdog Driver for Intel MID platform");
MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:intel_mid_wdt");
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1] watchdog: intel-mid_wdt: add MODULE_ALIAS() to allow auto-load
2023-08-11 12:02 [PATCH v1] watchdog: intel-mid_wdt: add MODULE_ALIAS() to allow auto-load Raag Jadav
@ 2023-08-11 12:20 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2023-08-11 12:20 UTC (permalink / raw)
To: Raag Jadav, wim, mika.westerberg, andriy.shevchenko
Cc: linux-watchdog, linux-kernel, mallikarjunappa.sangannavar, pandith.n
On 8/11/23 05:02, Raag Jadav wrote:
> When built with CONFIG_INTEL_MID_WATCHDOG=m, currently the driver
> needs to be loaded manually, for the lack of module alias.
> This causes unintended resets in cases where watchdog timer is
> set-up by bootloader and the driver is not explicitly loaded.
> Add MODULE_ALIAS() to load the driver automatically at boot and
> avoid this issue.
>
> Fixes: 87a1ef8058d9 ("watchdog: add Intel MID watchdog driver support")
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/intel-mid_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
> index 9b2173f765c8..fb7fae750181 100644
> --- a/drivers/watchdog/intel-mid_wdt.c
> +++ b/drivers/watchdog/intel-mid_wdt.c
> @@ -203,3 +203,4 @@ module_platform_driver(mid_wdt_driver);
> MODULE_AUTHOR("David Cohen <david.a.cohen@linux.intel.com>");
> MODULE_DESCRIPTION("Watchdog Driver for Intel MID platform");
> MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:intel_mid_wdt");
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-11 12:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-11 12:02 [PATCH v1] watchdog: intel-mid_wdt: add MODULE_ALIAS() to allow auto-load Raag Jadav
2023-08-11 12:20 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®