[PATCH 1/1] perf probe: Make synthesize_perf_probe_point() private to probe-event.c

[PATCH 1/1] perf probe: Make synthesize_perf_probe_point() private to probe-event.c

[Arnaldo Carvalho de Melo]

Not used in any other place, so just make it static.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/lkml/
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/probe-event.c | 4 +++-
 tools/perf/util/probe-event.h | 1 -
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 2835d87cb97771f9..1a5b7fa459b23204 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -53,6 +53,8 @@
 bool probe_event_dry_run;	/* Dry run flag */
 struct probe_conf probe_conf = { .magic_num = DEFAULT_PROBE_MAGIC_NUM };
 
+static char *synthesize_perf_probe_point(struct perf_probe_point *pp);
+
 #define semantic_error(msg ...) pr_err("Semantic error :" msg)
 
 int e_snprintf(char *str, size_t size, const char *format, ...)
@@ -2010,7 +2012,7 @@ char *synthesize_perf_probe_arg(struct perf_probe_arg *pa)
 }
 
 /* Compose only probe point (not argument) */
-char *synthesize_perf_probe_point(struct perf_probe_point *pp)
+static char *synthesize_perf_probe_point(struct perf_probe_point *pp)
 {
 	struct strbuf buf;
 	char *tmp, *ret = NULL;
diff --git a/tools/perf/util/probe-event.h b/tools/perf/util/probe-event.h
index 8ad5b1579f1d37b6..7e3b6c3d1f7447a7 100644
--- a/tools/perf/util/probe-event.h
+++ b/tools/perf/util/probe-event.h
@@ -137,7 +137,6 @@ int parse_probe_trace_command(const char *cmd, struct probe_trace_event *tev);
 char *synthesize_perf_probe_command(struct perf_probe_event *pev);
 char *synthesize_probe_trace_command(struct probe_trace_event *tev);
 char *synthesize_perf_probe_arg(struct perf_probe_arg *pa);
-char *synthesize_perf_probe_point(struct perf_probe_point *pp);
 
 int perf_probe_event__copy(struct perf_probe_event *dst,
 			   struct perf_probe_event *src);
-- 
2.37.1

Re: [PATCH 1/1] perf probe: Make synthesize_perf_probe_point() private to probe-event.c

[Ian Rogers]

On Fri, Aug 4, 2023 at 9:38 AM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
> Not used in any other place, so just make it static.
>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Ian Rogers <irogers@google.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Masami Hiramatsu <mhiramat@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Link: https://lore.kernel.org/lkml/
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/util/probe-event.c | 4 +++-
>  tools/perf/util/probe-event.h | 1 -
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 2835d87cb97771f9..1a5b7fa459b23204 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -53,6 +53,8 @@
>  bool probe_event_dry_run;      /* Dry run flag */
>  struct probe_conf probe_conf = { .magic_num = DEFAULT_PROBE_MAGIC_NUM };
>
> +static char *synthesize_perf_probe_point(struct perf_probe_point *pp);
> +
>  #define semantic_error(msg ...) pr_err("Semantic error :" msg)
>
>  int e_snprintf(char *str, size_t size, const char *format, ...)
> @@ -2010,7 +2012,7 @@ char *synthesize_perf_probe_arg(struct perf_probe_arg *pa)
>  }
>
>  /* Compose only probe point (not argument) */
> -char *synthesize_perf_probe_point(struct perf_probe_point *pp)
> +static char *synthesize_perf_probe_point(struct perf_probe_point *pp)
>  {
>         struct strbuf buf;
>         char *tmp, *ret = NULL;
> diff --git a/tools/perf/util/probe-event.h b/tools/perf/util/probe-event.h
> index 8ad5b1579f1d37b6..7e3b6c3d1f7447a7 100644
> --- a/tools/perf/util/probe-event.h
> +++ b/tools/perf/util/probe-event.h
> @@ -137,7 +137,6 @@ int parse_probe_trace_command(const char *cmd, struct probe_trace_event *tev);
>  char *synthesize_perf_probe_command(struct perf_probe_event *pev);
>  char *synthesize_probe_trace_command(struct probe_trace_event *tev);
>  char *synthesize_perf_probe_arg(struct perf_probe_arg *pa);
> -char *synthesize_perf_probe_point(struct perf_probe_point *pp);
>
>  int perf_probe_event__copy(struct perf_probe_event *dst,
>                            struct perf_probe_event *src);
> --
> 2.37.1
>

Re: [PATCH 1/1] perf probe: Make synthesize_perf_probe_point() private to probe-event.c

[Masami Hiramatsu]

On Fri, 4 Aug 2023 13:38:37 -0300
Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Not used in any other place, so just make it static.
> 

Looks good to me. 

Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Thanks!

> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Ian Rogers <irogers@google.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Masami Hiramatsu <mhiramat@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Link: https://lore.kernel.org/lkml/
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>  tools/perf/util/probe-event.c | 4 +++-
>  tools/perf/util/probe-event.h | 1 -
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 2835d87cb97771f9..1a5b7fa459b23204 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -53,6 +53,8 @@
>  bool probe_event_dry_run;	/* Dry run flag */
>  struct probe_conf probe_conf = { .magic_num = DEFAULT_PROBE_MAGIC_NUM };
>  
> +static char *synthesize_perf_probe_point(struct perf_probe_point *pp);
> +
>  #define semantic_error(msg ...) pr_err("Semantic error :" msg)
>  
>  int e_snprintf(char *str, size_t size, const char *format, ...)
> @@ -2010,7 +2012,7 @@ char *synthesize_perf_probe_arg(struct perf_probe_arg *pa)
>  }
>  
>  /* Compose only probe point (not argument) */
> -char *synthesize_perf_probe_point(struct perf_probe_point *pp)
> +static char *synthesize_perf_probe_point(struct perf_probe_point *pp)
>  {
>  	struct strbuf buf;
>  	char *tmp, *ret = NULL;
> diff --git a/tools/perf/util/probe-event.h b/tools/perf/util/probe-event.h
> index 8ad5b1579f1d37b6..7e3b6c3d1f7447a7 100644
> --- a/tools/perf/util/probe-event.h
> +++ b/tools/perf/util/probe-event.h
> @@ -137,7 +137,6 @@ int parse_probe_trace_command(const char *cmd, struct probe_trace_event *tev);
>  char *synthesize_perf_probe_command(struct perf_probe_event *pev);
>  char *synthesize_probe_trace_command(struct probe_trace_event *tev);
>  char *synthesize_perf_probe_arg(struct perf_probe_arg *pa);
> -char *synthesize_perf_probe_point(struct perf_probe_point *pp);
>  
>  int perf_probe_event__copy(struct perf_probe_event *dst,
>  			   struct perf_probe_event *src);
> -- 
> 2.37.1
> 


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>