mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: mediatek: mt7622: fix memory node warning check
@ 2023-08-14  6:50 Eugen Hristev
  2023-09-07  8:30 ` AngeloGioacchino Del Regno
  2023-11-29 13:27 ` AngeloGioacchino Del Regno
  0 siblings, 2 replies; 3+ messages in thread
From: Eugen Hristev @ 2023-08-14  6:50 UTC (permalink / raw)
  To: linux-mediatek
  Cc: krzysztof.kozlowski+dt, linux-arm-kernel, linux-kernel,
	devicetree, matthias.bgg, angelogioacchino.delregno, kernel,
	Eugen Hristev

dtbs_check throws a warning at the memory node:
Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name

fix by adding the address into the node name.

Fixes: 0b6286dd96c0 ("arm64: dts: mt7622: add bananapi BPI-R64 board")
Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
---
 arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 2 +-
 arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts             | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
index e4605d23fdc8..8220a4fd6319 100644
--- a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
+++ b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
@@ -73,7 +73,7 @@ led-1 {
 		};
 	};
 
-	memory {
+	memory@40000000 {
 		reg = <0 0x40000000 0 0x40000000>;
 	};
 
diff --git a/arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts b/arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts
index dad8e683aac5..c435984ca767 100644
--- a/arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts
+++ b/arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts
@@ -55,7 +55,7 @@ key-wps {
 		};
 	};
 
-	memory {
+	memory@40000000 {
 		reg = <0 0x40000000 0 0x20000000>;
 	};
 
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: mediatek: mt7622: fix memory node warning check
  2023-08-14  6:50 [PATCH] arm64: dts: mediatek: mt7622: fix memory node warning check Eugen Hristev
@ 2023-09-07  8:30 ` AngeloGioacchino Del Regno
  2023-11-29 13:27 ` AngeloGioacchino Del Regno
  1 sibling, 0 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-09-07  8:30 UTC (permalink / raw)
  To: Eugen Hristev, linux-mediatek
  Cc: krzysztof.kozlowski+dt, linux-arm-kernel, linux-kernel,
	devicetree, matthias.bgg, kernel

Il 14/08/23 08:50, Eugen Hristev ha scritto:
> dtbs_check throws a warning at the memory node:
> Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
> 
> fix by adding the address into the node name.
> 
> Fixes: 0b6286dd96c0 ("arm64: dts: mt7622: add bananapi BPI-R64 board")
> Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> ---
>   arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 2 +-
>   arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts             | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> index e4605d23fdc8..8220a4fd6319 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> @@ -73,7 +73,7 @@ led-1 {
>   		};
>   	};
>   
> -	memory {
> +	memory@40000000 {
>   		reg = <0 0x40000000 0 0x40000000>;
>   	};
>   
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts b/arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts
> index dad8e683aac5..c435984ca767 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts
> @@ -55,7 +55,7 @@ key-wps {
>   		};
>   	};
>   
> -	memory {
> +	memory@40000000 {
>   		reg = <0 0x40000000 0 0x20000000>;
>   	};
>   



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: mediatek: mt7622: fix memory node warning check
  2023-08-14  6:50 [PATCH] arm64: dts: mediatek: mt7622: fix memory node warning check Eugen Hristev
  2023-09-07  8:30 ` AngeloGioacchino Del Regno
@ 2023-11-29 13:27 ` AngeloGioacchino Del Regno
  1 sibling, 0 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-11-29 13:27 UTC (permalink / raw)
  To: linux-mediatek, Eugen Hristev
  Cc: AngeloGioacchino Del Regno, krzysztof.kozlowski+dt,
	linux-arm-kernel, linux-kernel, devicetree, matthias.bgg, kernel


On Mon, 14 Aug 2023 09:50:42 +0300, Eugen Hristev wrote:
> dtbs_check throws a warning at the memory node:
> Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
> 
> fix by adding the address into the node name.
> 
> 

Applied, thanks!

[1/1] arm64: dts: mediatek: mt7622: fix memory node warning check
      commit: 022597b6e520b5c21894b9693bde215a5d788a17

Best regards,
-- 
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-11-29 13:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-14  6:50 [PATCH] arm64: dts: mediatek: mt7622: fix memory node warning check Eugen Hristev
2023-09-07  8:30 ` AngeloGioacchino Del Regno
2023-11-29 13:27 ` AngeloGioacchino Del Regno

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®