From: Peter Zijlstra <peterz@infradead.org>
To: bigeasy@linutronix.de, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, bsegall@google.com,
boqun.feng@gmail.com, swood@redhat.com, bristot@redhat.com,
dietmar.eggemann@arm.com, mingo@redhat.com, jstultz@google.com,
juri.lelli@redhat.com, mgorman@suse.de, rostedt@goodmis.org,
vschneid@redhat.com, vincent.guittot@linaro.org,
longman@redhat.com, will@kernel.org
Subject: Re: [PATCH 0/6] locking/rtmutex: Avoid PI state recursion through sched_submit_work()
Date: Tue, 15 Aug 2023 18:15:57 +0200 [thread overview]
Message-ID: <20230815161557.GK214207@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20230815110121.117752409@infradead.org>
On Tue, Aug 15, 2023 at 01:01:21PM +0200, Peter Zijlstra wrote:
> Hi!
>
> This is basically the 'same' patches as send earlier by Sebastian here:
>
> https://lkml.kernel.org/r/20230427111937.2745231-1-bigeasy@linutronix.de
>
> I spend a number of days trying to invert rtmutex, only to make a giant mess of
> things and finally conceded that this is the least horrible approach.
>
> There's a bunch of naming differences and I added some asserts that should
> hopefully avoid things from going sideways without notice. I've also updated
> the changelogs to high-light the actual problem. The whole pi_blocked_on
> 'corruption' is a mere consequence of the more fundamental problem that the
> whole PI state recurses.
>
> I've not tested this with the rest of the RT patches stuck on, so very limited
> actual testing happened.
>
> If anybody could please confirm stuff still works as advertised, I'll go queue
> this mess and we can hopefully forget all about it.
>
N/m - 0day found a problem. Futex-PI trips the rt_mutex_schedule()
assertion for not passing through rt_mutex_pre_schedule().
I'll go try and untangle that...
next prev parent reply other threads:[~2023-08-15 16:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 11:01 Peter Zijlstra
2023-08-15 11:01 ` [PATCH 1/6] sched: Constrain locks in sched_submit_work() Peter Zijlstra
2023-08-15 11:01 ` [PATCH 2/6] locking/rtmutex: Avoid unconditional slowpath for DEBUG_RT_MUTEXES Peter Zijlstra
2023-08-15 11:01 ` [PATCH 3/6] sched: Extract __schedule_loop() Peter Zijlstra
2023-08-15 22:33 ` Phil Auld
2023-08-15 22:39 ` Peter Zijlstra
2023-08-16 14:14 ` Phil Auld
2023-08-15 22:42 ` Phil Auld
2023-08-16 10:01 ` Sebastian Andrzej Siewior
2023-08-16 11:39 ` Phil Auld
2023-08-16 12:20 ` Sebastian Andrzej Siewior
2023-08-16 12:48 ` Phil Auld
2023-08-15 11:01 ` [PATCH 4/6] sched: Provide rt_mutex specific scheduler helpers Peter Zijlstra
2023-08-15 11:01 ` [PATCH 5/6] locking/rtmutex: Use " Peter Zijlstra
2023-08-15 11:01 ` [PATCH 6/6] locking/rtmutex: Add a lockdep assert to catch potential nested blocking Peter Zijlstra
2023-08-15 16:15 ` Peter Zijlstra [this message]
2023-08-16 8:58 ` [PATCH 0/6] locking/rtmutex: Avoid PI state recursion through sched_submit_work() Sebastian Andrzej Siewior
2023-08-16 9:42 ` Peter Zijlstra
2023-08-16 10:19 ` Sebastian Andrzej Siewior
2023-08-16 13:46 ` Sebastian Andrzej Siewior
2023-08-16 14:58 ` Peter Zijlstra
2023-08-16 15:22 ` Peter Zijlstra
2023-08-16 15:25 ` Sebastian Andrzej Siewior
2023-08-17 6:59 ` Sebastian Andrzej Siewior
2023-08-17 8:26 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230815161557.GK214207@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bigeasy@linutronix.de \
--cc=boqun.feng@gmail.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jstultz@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=swood@redhat.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®