From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Phil Auld <pauld@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
tglx@linutronix.de, linux-kernel@vger.kernel.org,
bsegall@google.com, boqun.feng@gmail.com, swood@redhat.com,
bristot@redhat.com, dietmar.eggemann@arm.com, mingo@redhat.com,
jstultz@google.com, juri.lelli@redhat.com, mgorman@suse.de,
rostedt@goodmis.org, vschneid@redhat.com,
vincent.guittot@linaro.org, longman@redhat.com, will@kernel.org
Subject: Re: [PATCH 3/6] sched: Extract __schedule_loop()
Date: Wed, 16 Aug 2023 14:20:07 +0200 [thread overview]
Message-ID: <20230816122007.W7OJW3Fx@linutronix.de> (raw)
In-Reply-To: <20230816113945.GA639355@lorien.usersys.redhat.com>
On 2023-08-16 07:39:45 [-0400], Phil Auld wrote:
> I do. Admittedly I'm not an expert in how the wchan unwinding works but
> we have a slightly older version of this patch in our kernel (schedule_loop
> not __schedule_loop). When I added __sched it fixed it. Maybe there
> is something else but that seemed pretty obvious.
>
>
> /* Attach to any functions which should be ignored in wchan output. */
> #define __sched __section(".sched.text")
>
> I can't explain why you are not seeing it.
as peterz pointed out, it is marked __always_inline so the compiler
shouldn't make a separate function out of it.
Could you check with _this_ series? The schedule_loop variant is in RT
and does not have this inline thingy. So it would be good if the issue
you report actually exists in the series that has been posted.
> Cheers,
> Phil
Sebastian
next prev parent reply other threads:[~2023-08-16 12:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 11:01 [PATCH 0/6] locking/rtmutex: Avoid PI state recursion through sched_submit_work() Peter Zijlstra
2023-08-15 11:01 ` [PATCH 1/6] sched: Constrain locks in sched_submit_work() Peter Zijlstra
2023-08-15 11:01 ` [PATCH 2/6] locking/rtmutex: Avoid unconditional slowpath for DEBUG_RT_MUTEXES Peter Zijlstra
2023-08-15 11:01 ` [PATCH 3/6] sched: Extract __schedule_loop() Peter Zijlstra
2023-08-15 22:33 ` Phil Auld
2023-08-15 22:39 ` Peter Zijlstra
2023-08-16 14:14 ` Phil Auld
2023-08-15 22:42 ` Phil Auld
2023-08-16 10:01 ` Sebastian Andrzej Siewior
2023-08-16 11:39 ` Phil Auld
2023-08-16 12:20 ` Sebastian Andrzej Siewior [this message]
2023-08-16 12:48 ` Phil Auld
2023-08-15 11:01 ` [PATCH 4/6] sched: Provide rt_mutex specific scheduler helpers Peter Zijlstra
2023-08-15 11:01 ` [PATCH 5/6] locking/rtmutex: Use " Peter Zijlstra
2023-08-15 11:01 ` [PATCH 6/6] locking/rtmutex: Add a lockdep assert to catch potential nested blocking Peter Zijlstra
2023-08-15 16:15 ` [PATCH 0/6] locking/rtmutex: Avoid PI state recursion through sched_submit_work() Peter Zijlstra
2023-08-16 8:58 ` Sebastian Andrzej Siewior
2023-08-16 9:42 ` Peter Zijlstra
2023-08-16 10:19 ` Sebastian Andrzej Siewior
2023-08-16 13:46 ` Sebastian Andrzej Siewior
2023-08-16 14:58 ` Peter Zijlstra
2023-08-16 15:22 ` Peter Zijlstra
2023-08-16 15:25 ` Sebastian Andrzej Siewior
2023-08-17 6:59 ` Sebastian Andrzej Siewior
2023-08-17 8:26 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230816122007.W7OJW3Fx@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=boqun.feng@gmail.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jstultz@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=swood@redhat.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®