mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.de>,
	Mark Brown <broonie@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Claudiu Beznea <claudiu.beznea@microchip.com>,
	Olivier Moysan <olivier.moysan@foss.st.com>,
	Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Subject: [PATCH v2 22/25] ASoC: dmaengine: Use iov_iter for process callback, too
Date: Tue, 15 Aug 2023 21:01:33 +0200	[thread overview]
Message-ID: <20230815190136.8987-23-tiwai@suse.de> (raw)
In-Reply-To: <20230815190136.8987-1-tiwai@suse.de>

Along with the conversion to PCM copy ops, use the iov_iter for the
pointer to be passed to the dmaengine process callback, too.  It
avoids the direct reference of iter_iov_addr(), and it can potentially
help for the drivers to access memory properly (although both atmel
and stm drivers don't use the given buffer address at all for now).

Reviewed-by: Mark Brown <broonie@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Claudiu Beznea <claudiu.beznea@microchip.com>
Cc: Olivier Moysan <olivier.moysan@foss.st.com>
Cc: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 include/sound/dmaengine_pcm.h         | 2 +-
 sound/soc/atmel/mchp-pdmc.c           | 2 +-
 sound/soc/soc-generic-dmaengine-pcm.c | 5 ++---
 sound/soc/stm/stm32_sai_sub.c         | 2 +-
 4 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/include/sound/dmaengine_pcm.h b/include/sound/dmaengine_pcm.h
index 2df54cf02cb3..c9a8bce9a785 100644
--- a/include/sound/dmaengine_pcm.h
+++ b/include/sound/dmaengine_pcm.h
@@ -142,7 +142,7 @@ struct snd_dmaengine_pcm_config {
 			struct snd_pcm_substream *substream);
 	int (*process)(struct snd_pcm_substream *substream,
 		       int channel, unsigned long hwoff,
-		       void *buf, unsigned long bytes);
+		       struct iov_iter *buf, unsigned long bytes);
 	dma_filter_fn compat_filter_fn;
 	struct device *dma_dev;
 	const char *chan_names[SNDRV_PCM_STREAM_LAST + 1];
diff --git a/sound/soc/atmel/mchp-pdmc.c b/sound/soc/atmel/mchp-pdmc.c
index c79c73e6791e..b3afcf25b4a9 100644
--- a/sound/soc/atmel/mchp-pdmc.c
+++ b/sound/soc/atmel/mchp-pdmc.c
@@ -962,7 +962,7 @@ static int mchp_pdmc_dt_init(struct mchp_pdmc *dd)
 /* used to clean the channel index found on RHR's MSB */
 static int mchp_pdmc_process(struct snd_pcm_substream *substream,
 			     int channel, unsigned long hwoff,
-			     void *buf, unsigned long bytes)
+			     struct iov_iter *buf, unsigned long bytes)
 {
 	struct snd_pcm_runtime *runtime = substream->runtime;
 	u8 *dma_ptr = runtime->dma_area + hwoff +
diff --git a/sound/soc/soc-generic-dmaengine-pcm.c b/sound/soc/soc-generic-dmaengine-pcm.c
index f2cb75781566..ff2166525dbc 100644
--- a/sound/soc/soc-generic-dmaengine-pcm.c
+++ b/sound/soc/soc-generic-dmaengine-pcm.c
@@ -296,18 +296,17 @@ static int dmaengine_copy(struct snd_soc_component *component,
 	struct dmaengine_pcm *pcm = soc_component_to_pcm(component);
 	int (*process)(struct snd_pcm_substream *substream,
 		       int channel, unsigned long hwoff,
-		       void *buf, unsigned long bytes) = pcm->config->process;
+		       struct iov_iter *buf, unsigned long bytes) = pcm->config->process;
 	bool is_playback = substream->stream == SNDRV_PCM_STREAM_PLAYBACK;
 	void *dma_ptr = runtime->dma_area + hwoff +
 			channel * (runtime->dma_bytes / runtime->channels);
-	void *ptr = (void __force *)iter_iov_addr(buf);
 
 	if (is_playback)
 		if (copy_from_iter(dma_ptr, bytes, buf) != bytes)
 			return -EFAULT;
 
 	if (process) {
-		int ret = process(substream, channel, hwoff, ptr, bytes);
+		int ret = process(substream, channel, hwoff, buf, bytes);
 		if (ret < 0)
 			return ret;
 	}
diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c
index 271ec5b3378d..39f9b4654fa2 100644
--- a/sound/soc/stm/stm32_sai_sub.c
+++ b/sound/soc/stm/stm32_sai_sub.c
@@ -1233,7 +1233,7 @@ static const struct snd_soc_dai_ops stm32_sai_pcm_dai_ops = {
 
 static int stm32_sai_pcm_process_spdif(struct snd_pcm_substream *substream,
 				       int channel, unsigned long hwoff,
-				       void *buf, unsigned long bytes)
+				       struct iov_iter *buf, unsigned long bytes)
 {
 	struct snd_pcm_runtime *runtime = substream->runtime;
 	struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
-- 
2.35.3


  parent reply	other threads:[~2023-08-15 19:03 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-15 19:01 [PATCH v2 00/25] ALSA: Generic PCM copy ops using iov_iter Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 01/25] iov_iter: Export import_ubuf() Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 02/25] ALSA: pcm: Add copy ops with iov_iter Takashi Iwai
2023-09-02  5:30   ` Al Viro
2023-09-02  6:00     ` Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 03/25] ALSA: core: Add memory copy helpers between iov_iter and iomem Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 04/25] ALSA: dummy: Convert to generic PCM copy ops Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 05/25] ALSA: gus: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 06/25] ALSA: emu8000: " Takashi Iwai
2023-09-02  5:36   ` Al Viro
2023-09-02  6:01     ` Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 07/25] ALSA: es1938: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 08/25] ALSA: korg1212: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 09/25] ALSA: nm256: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 10/25] ALSA: rme32: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 11/25] ALSA: rme96: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 12/25] ALSA: hdsp: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 13/25] ALSA: rme9652: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 14/25] ALSA: sh: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 15/25] ALSA: xen: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 16/25] ALSA: pcmtest: Update comment about " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 17/25] media: solo6x10: Convert to generic " Takashi Iwai
2023-08-18  7:48   ` Hans Verkuil
2023-08-15 19:01 ` [PATCH v2 18/25] ASoC: component: Add " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 19/25] ASoC: mediatek: Convert to " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 20/25] ASoC: qcom: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 21/25] ASoC: dmaengine: " Takashi Iwai
2023-08-15 19:01 ` Takashi Iwai [this message]
2023-08-15 19:01 ` [PATCH v2 23/25] ALSA: doc: Update description for the new " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 24/25] ASoC: pcm: Drop obsoleted PCM copy_user ops Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 25/25] ALSA: pcm: Drop obsoleted PCM copy_user and copy_kernel ops Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230815190136.8987-23-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnaud.pouliquen@foss.st.com \
    --cc=broonie@kernel.org \
    --cc=claudiu.beznea@microchip.com \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olivier.moysan@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®